GNOME Firmware FTBFS
I noticed this in the snap build.
:: ../src/src/gfu-main.c: In function ‘gfu_main_build_report_devices_payload’:
:: ../src/src/gfu-main.c:572:14: warning: implicit declaration of function ‘fwupd_remote_get_enabled’; did you mean ‘fwupd_remote_get_age’? [-Wimplicit-function-declaration]
:: 572 | if (!fwupd_remote_get_enabled(self->remote_lvfs)) {
:: | ^~~~~~~~~~~~~~~~~~~~~~~~
:: | fwupd_remote_get_age
:: ../src/src/gfu-main.c:572:14: warning: nested extern declaration of ‘fwupd_remote_get_enabled’ [-Wnested-externs]
:: [119/119] Linking target src/gnome-firmware
:: FAILED: src/gnome-firmware
:: cc -o src/gnome-firmware src/gnome-firmware.p/meson-generated_.._gnome-firmware-resources.c.o src/gnome-firmware.p/gfu-main.c.o src/gnome-firmware.p/gfu-common.c.o src/gnome-firmware.p/gfu-device-row.c.o src/gnome-firmware.p/gfu-release-row.c.o -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-z,now '-Wl,-rpath,$ORIGIN/../subprojects/fwupd/libfwupd:$ORIGIN/../subprojects/libjcat/libjcat:$ORIGIN/../subprojects/libxmlb/src:/snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu' -Wl,-rpath-link,/build/gnome-firmware/parts/gnome-firmware/build/subprojects/fwupd/libfwupd -Wl,-rpath-link,/build/gnome-firmware/parts/gnome-firmware/build/subprojects/libjcat/libjcat -Wl,-rpath-link,/build/gnome-firmware/parts/gnome-firmware/build/subprojects/libxmlb/src -Wl,-rpath-link,/snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu -Wl,--start-group subprojects/fwupd/libfwupd/libfwupd.so.3.0.0 subprojects/libjcat/libjcat/libjcat.so.1.0.0 subprojects/libxmlb/src/libxmlb.so.1.0.0 /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libgtk-4.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libpangocairo-1.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libpango-1.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libharfbuzz.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libcairo-gobject.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libcairo.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libgraphene-1.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libgio-2.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libgobject-2.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libglib-2.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libjson-glib-1.0.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libgnutls.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libhogweed.so -lgpgme -lgpg-error /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libcurl.so /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libadwaita-1.so -Wl,--end-group
:: /snap/gnome-42-2204-sdk/current/usr/bin/ld: warning: libxmlb.so.2, needed by /snap/gnome-42-2204-sdk/current/usr/lib/x86_64-linux-gnu/libappstream.so.4, may conflict with libxmlb.so.1
:: /snap/gnome-42-2204-sdk/current/usr/bin/ld: src/gnome-firmware.p/gfu-main.c.o: in function `gfu_main_build_report_devices_payload':
:: /build/gnome-firmware/parts/gnome-firmware/build/../src/src/gfu-main.c:572: undefined reference to `fwupd_remote_get_enabled'
I didn't look at G-F code, but I guess it forgot to migrate from fwupd_remote_get_enabled
to fwupd_remote_has_flag
.