Skip to content

build: use gtk4-update-icon-cache

Bobby Rong requested to merge bobby285271/contrast:gtk4-update-icon-cache into master

Otherwise the post install script will fail if GTK 3 is not installed.

Thanks for reviewing this!

Running custom install script '/build/source/build-aux/meson_post_install.py'
--- stdout ---
Updating icon cache...

--- stderr ---
Traceback (most recent call last):
  File "/build/source/build-aux/meson_post_install.py", line 10, in <module>
    call(['gtk-update-icon-cache', '-qtf', path.join(DATA_DIR, 'icons/hicolor')])
  File "/nix/store/x24kxyqwqg2ln8kh9ky342kdcmhbng3h-python3-3.9.9/lib/python3.9/subprocess.py", line 349, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/nix/store/x24kxyqwqg2ln8kh9ky342kdcmhbng3h-python3-3.9.9/lib/python3.9/subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/x24kxyqwqg2ln8kh9ky342kdcmhbng3h-python3-3.9.9/lib/python3.9/subprocess.py", line 1821, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gtk-update-icon-cache'

FAILED: install script '/build/source/build-aux/meson_post_install.py' exit code 1, stopped
FAILED: meson-install 
/nix/store/r3iy0vd59l90vx6kp0z83nxghy93qdjf-meson-0.60.3/bin/meson install --no-rebuild
ninja: build stopped: subcommand failed.

Merge request reports