Jonas Ådahl authored Nov 02, 2021 and Rastersoft committed Jan 08, 2022

The desktop icons extension can get into a state where the desktop no longer
takes mouse input.

This happens if a user starts a rubber banding operation and then drags
the mouse to somewhere on screen that has a pop up menu, and then pops
the menu up.

This commit addresses the bug by limiting the grab actor to the
backgrounds, and by explicitly ending the rubber banding operation
when one of the icons own menus is shown.

One side effect of limiting the grab actor to the backgrounds, is the
rubber banding code never gets to see motion outside of the backgrounds
anymore. In order to keep drag operations feeling fluid when the user moves
toward the edge of the screen, this commit also overrides the
grab helpers captured-event handler so those motion events keep coming.

We also start to end the rubber band if for any reason the grab it had
was released.

It prompts 'fileItem is undefined' when saving file.

Fixes:
#200

Xiaoguang Wang authored Mar 17, 2021 and Rastersoft committed Jun 03, 2021

When the icon can't be found, the icon is empty on desktop.

Imitate the behavior of Nautilus canvas WRT double clicks being
handled on all of the icon(s) without accounting for the double
click distance. As the extension does already lean on Nautilus
look & feel, it seems to make sense doing this.

This is not as crucial for mice as it is for touchscreens, where
the default 5px limit may be a bit on the short side depending
on device sensitivity.

Sergio Costas authored Jul 08, 2020 and Rastersoft committed Dec 06, 2020

When several files are selected and the user tries to drag them, only
one is dragged.

This patch fixes it.

Fix #211

Since around about mutter 3.37, `clutter_actor_get_transformed_position`
no longer forces/guarantees allocation has actually happened, and if not
will just return NaN values. Those NaNs propagated into the gnome-shell
drag-and-drop functions which can't handle them and so dragging would fail,
or worse, never complete and lock the user out of interacting with the
desktop.

Now we force allocation of the actor being dragged before requesting the
drag begins and the gnome-shell drag-and-drop functions work properly.
You still can't drag and drop into Nautilus windows but at least the icons
now animate, snap back, and don't lock the mouse.

We have to predicate this fix on `get_fixed_position` existing as a way
of testing the newer allocation API (and the bug itself) exists. Just like
we did in 72b20c9c.

Fixes:
#224
https://bugs.launchpad.net/bugs/1898462

Sergio Costas authored Jun 03, 2020 and Rastersoft committed Nov 29, 2020

Since the environment for use an external GPU is set only for
.desktop files, this patch ensures that it is shown only for
those files.

It is not possible to start applications with the dedicated graphics card after the change to the native switcheroo controller.
It looks like the unpack function of the GLib Variant does not fully process the "GPUs" data structure.
Added code to look up the atributes where needed.

Daniel van Vugt authored Nov 24, 2020 and Rastersoft committed Nov 28, 2020

If an existing one hadn't run yet then we could end up with two or more
idlers scheduled to call `this._layoutChildren()`. And both would appear
to succeed, except that the second and subsequent ones would silently
fail `clutter_actor_add_child` in `st_bin_set_child`, called from:

```
    _addFileItemTo(fileItem, column, row, coordinatesAction) {
        let placeholder = this.layout.get_child_at(column, row);
        placeholder.child = fileItem;
```

But `StBin` doesn't check for such failure and keeps a copy of its own
`priv->child` even for those actors that it failed to parent. So for
those, `st_bin_remove` would never be called and some time later this
assertion will fail:

```
st_bin_destroy (ClutterActor *actor)
{
  StBinPrivate *priv = st_bin_get_instance_private (ST_BIN (actor));

  if (priv->child)
    clutter_actor_destroy (priv->child);
  g_assert (priv->child == NULL);
```

Arguably `st_bin_set_child` should have detected the failure of
`clutter_actor_add_child` in the first place and so not kept a copy of
`priv->child`. But regardless, calling `_layoutChildren()` too many times
is the root cause. So don't do that.

Fixes: https://bugs.launchpad.net/bugs/1898005
but may also fix some leaks.

While the desktop will work even in previous versions, some features
would just be broken, so it's time to bump again the dependency

Old classes are gone, we need to follow this new pattern now

We don't have to manage this via dbus anymore as the shell exposes these
properties now.

While it has not anymore the switcheroo xml interface exported, so the
extension should ship it instead.

Otherwise new shell will complain about the multiple arguments