Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • S squeekboard
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 129
    • Issues 129
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • World
  • Phosh
  • squeekboard
  • Merge requests
  • !581

Decouple event handling from concrete logic

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged dcz requested to merge event into master Nov 28, 2022
  • Overview 1
  • Commits 10
  • Pipelines 1
  • Changes 16

This makes the event loop handling and the threaded driver no longer dependent on a concrete implementation of the state and events being handled. This makes the handler easier to understand without wondering what is inherent to it, and what is incidental.

Additional benefits from the decoupling:

  • more robust tests of event loop won't fail when the main state is broken (TODO)
  • all handling for the main loop is close together now
  • possible to reuse the same loop for new actors if needed
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: event