Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • phosh phosh
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 238
    • Issues 238
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • World
  • Phosh
  • phoshphosh
  • Merge requests
  • !863

Handle application specific 'enable' notfication setting

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Administrator requested to merge allow-to-disable-notifications into main Jul 24, 2021
  • Overview 9
  • Commits 6
  • Pipelines 7
  • Changes 16

This makes the per app "Notifications" toggle in g-c-c work.

This needed some tweaks to the source_id used for the PhoshNotificationBanner which in turn requried us to keep the desktop_id around too.

I'll unwip after brushing up the tests and more testing (mostly cobbled this together during the GTK BoF)

/cc @zbrown would be great to hear if this matches what you proposed in #168

Signed-off-by: Guido Günther guido.gunther@puri.sm

Helps #168

Edited Apr 12, 2023 by Guido Günther
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: allow-to-disable-notifications