Skip to content

Queue draw instead of committing the surface

Guido Günther requested to merge guidog/phosh:scale-crash into main

Otherwise we can crash as GTK might not have yet attached a new buffer, see #1171 (closed)

The code changes itself were quick but adding tests was a bit more involved as I didn't want to add more to the screenshot tests (as they're very much order dependent already). I went for pytests and also the "real" shell rather then our testlib ensuring we exercise that in the tests in non trivial ways (and since running the shell as library in the same process is nice but fiddly at the same time). This will hopefully evolve into exercising this more. I have a couple of ideas how to expand this but lets land baseline support first.

The pytest is currently not run via meson but we could hook that up too.

Closes: #1171 (closed)

@gautham_x @arun-mani-j please have a look, when you get a chance.

Merge request reports

Loading