From 5e43de1a31de56f279019dae5c9248f088cffa50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Wed, 5 Nov 2025 12:43:48 +0100 Subject: [PATCH 1/3] plugin-list-box: Don't warn on missing icon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Otherwise we fail on every system that has phosh plugins installed. Closes: https://gitlab.gnome.org/World/Phosh/phosh-mobile-settings/-/issues/92 Fixes: 6cd666c ("plugin-list-box: Don't warn on missing icon") Signed-off-by: Guido Günther Part-of: --- src/ms-plugin-list-box.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ms-plugin-list-box.c b/src/ms-plugin-list-box.c index 85716c7b..43aa8d10 100644 --- a/src/ms-plugin-list-box.c +++ b/src/ms-plugin-list-box.c @@ -297,7 +297,7 @@ ms_plugin_list_box_scan_phosh_plugins (MsPluginListBox *self) g_warning ("Plugin '%s' has no type. Please fix", name); if (icon_name == NULL) - g_warning ("Failed to get icon for %s plugin", name); + g_debug ("Failed to get icon for %s plugin", name); if (!g_strv_contains ((const char *const *)types, self->plugin_type)) continue; -- GitLab From 3a672fb3ec565aa724d946ce1f888747a48d2c45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Wed, 5 Nov 2025 12:47:51 +0100 Subject: [PATCH 2/3] feedback-panel: Don't warn when operation got cancelled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This can happen in tests Fixes: f56f820 ("feedback-panel: Check for mobile friendly alarm app") Signed-off-by: Guido Günther Part-of: --- src/ms-feedback-panel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ms-feedback-panel.c b/src/ms-feedback-panel.c index a07ef0c3..195455af 100644 --- a/src/ms-feedback-panel.c +++ b/src/ms-feedback-panel.c @@ -845,7 +845,8 @@ on_check_alarm_app_ready (GObject *source_object, GAsyncResult *res, gpointer us &err); if (!success) { - g_warning ("Failed to check for alarm app: %s", err->message); + if (!success && !g_error_matches (err, G_IO_ERROR, G_IO_ERROR_CANCELLED)) + g_warning ("Failed to check for alarm app: %s", err->message); return; } -- GitLab From e091fa6a4a1c913ad887fee155ed423efdcf391c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Wed, 5 Nov 2025 12:48:34 +0100 Subject: [PATCH 3/3] packaging: Require phosh plugins during the build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This makes sure we test plugin related code paths which is the common case on phosh installations. Signed-off-by: Guido Günther Part-of: --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index 9c7891e6..802b5b6f 100644 --- a/debian/control +++ b/debian/control @@ -25,6 +25,7 @@ Build-Depends: gsettings-desktop-schemas , phoc , phosh (>= 0.40.0~) , + phosh-plugins (>= 0.40.0~) , xauth , xvfb , xwayland , -- GitLab