From 2ce325a77e9cf62e4f5cec107ad4a08a87c89fed Mon Sep 17 00:00:00 2001 From: "Anna (cybertailor) Vyalkova" Date: Sun, 24 Aug 2025 22:11:09 +0500 Subject: [PATCH 1/2] ms-tweaks-utils: Use G_GNUC_PRINTF macro in function declaration gnu_printf is not recognized by Clang. Fixes: f8dd824b4 ("pmos-tweaks: Add initial UI code parts") Signed-off-by: Anna (cybertailor) Vyalkova Part-of: --- src/conf-tweaks/ms-tweaks-utils.c | 1 - src/conf-tweaks/ms-tweaks-utils.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf-tweaks/ms-tweaks-utils.c b/src/conf-tweaks/ms-tweaks-utils.c index 9c5a921f..1c5ee413 100644 --- a/src/conf-tweaks/ms-tweaks-utils.c +++ b/src/conf-tweaks/ms-tweaks-utils.c @@ -73,7 +73,6 @@ ms_tweaks_util_get_key_by_value_string (GHashTable *hash_table, } -[[gnu::format (gnu_printf, 4, 5)]] void ms_tweaks_log (const char *restrict log_domain, GLogLevelFlags log_level, diff --git a/src/conf-tweaks/ms-tweaks-utils.h b/src/conf-tweaks/ms-tweaks-utils.h index 8231dd95..1758dd17 100644 --- a/src/conf-tweaks/ms-tweaks-utils.h +++ b/src/conf-tweaks/ms-tweaks-utils.h @@ -48,4 +48,4 @@ void ms_tweaks_log (const char *restrict log_domain, GLogLevelFlags log_level, const char *restrict name, const char *restrict message, - ...); + ...) G_GNUC_PRINTF(4, 5); -- GitLab From 75e08e10dfafc9265c627ebbdb14be9537311e3e Mon Sep 17 00:00:00 2001 From: "Anna (cybertailor) Vyalkova" Date: Mon, 25 Aug 2025 18:59:47 +0500 Subject: [PATCH 2/2] ms-tweaks-utils: Ignore -Wformat-nonliteral warning Otherwise "-Werror=format=2" makes build fail with Clang. Fixes: f8dd824b4 ("pmos-tweaks: Add initial UI code parts") Signed-off-by: Anna (cybertailor) Vyalkova Part-of: --- src/conf-tweaks/ms-tweaks-utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf-tweaks/ms-tweaks-utils.c b/src/conf-tweaks/ms-tweaks-utils.c index 1c5ee413..0fda98d8 100644 --- a/src/conf-tweaks/ms-tweaks-utils.c +++ b/src/conf-tweaks/ms-tweaks-utils.c @@ -84,7 +84,10 @@ ms_tweaks_log (const char *restrict log_domain, char *restrict format_with_prefix = g_strconcat ("[Setting \"", name, "\"] ", format, NULL); va_start (args, format); +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wformat-nonliteral" g_logv (log_domain, log_level, format_with_prefix, args); +#pragma GCC diagnostic pop va_end (args); g_free (format_with_prefix); } -- GitLab