Skip to content

gtk-shell: Use a single path for freeing resources

Guido Günther requested to merge guidog/phoc:gtk-shell-illegal-access into main

Otherwise we might hit an asan asertion when the client crashes:

phoc[2566]: =================================================================
phoc[2566]: ==2566==ERROR: AddressSanitizer: heap-use-after-free on address 0x50c001893948 at pc 0x5573399abcb6 bp 0x7ffea3b072d0 sp 0x7ffea3b072c8
phoc[2566]: WRITE of size 8 at 0x50c001893948 thread T0
phoc[2566]:     #0 0x5573399abcb5 in handle_wlr_surface_handle_destroy ../src/gtk-shell.c:164
phoc[2566]:     #1 0x7ff8720f2b4b in wl_signal_emit_mutable ../src/wayland-server.c:2314
phoc[2566]:     #2 0x557339c2daf7 in surface_handle_resource_destroy ../subprojects/wlroots-0.19.x/types/wlr_compositor.c:730
phoc[2566]:     #3 0x7ff8720f11d6 in remove_and_destroy_resource ../src/wayland-server.c:757
phoc[2566]:     #4 0x7ff8720f7c3f in for_each_helper ../src/wayland-util.c:430
phoc[2566]:     #5 0x7ff8720f81f2 in wl_map_for_each ../src/wayland-util.c:444
phoc[2566]:     #6 0x7ff8720f19e4 in wl_client_destroy ../src/wayland-server.c:961
phoc[2566]:     #7 0x7ff8720f1b3c in destroy_client_with_error ../src/wayland-server.c:331
phoc[2566]:     #8 0x7ff8720f1b3c in wl_client_connection_data ../src/wayland-server.c:460
phoc[2566]:     #9 0x7ff8720f4cf1 in wl_event_loop_dispatch ../src/event-loop.c:1105
…

Signed-off-by: Guido Günther agx@sigxcpu.org

Merge request reports