Skip to content

server: Make all members private

Guido Günther requested to merge guidog/phoc:server-private into main

We didn't have cleanups for some time so here we go:

Use consistent access via member functions.

* treewide: Use phoc_server_get_desktop()

  We had about all combinations:
  
  - Fetching the server, then the desktop
  - Fetching the server, then using server->desktop directly
  - Using phoc_server_get_desktop ()
  - Using phoc_server_get_default ()->desktop
  
  As we want PhocDesktop in all cases use
  
    PhocDesktop *desktop = phoc_server_get_desktop (phoc_server_get_default ());
  
  consistently. Only in the few places that use server and desktop use
  
    PhocDesktop *desktop = phoc_server_get_desktop (server);
  
  We also move fetching the desktop to the top of functions and clean up
  some minor misindents along the way.
  
* server: Make desktop private

  This makes sure we only access the desktop that way.
  
* server: Make session startup related variables private

* server: Make init flag private

* treewide: Add and use phoc_server_get_input()

  This brings it in line with phoc_server_get_desktop() making
  an explicit server variable unnecessary in many functions.
  
* server: Make input private

* server: Add and use phoc_server_get_config()

  This gets it in line with phoc_server_get_desktop()
  
* server: Make config private

* server: Make flags private

* server: Fix doc string

* server: Add and use phoc_server_get_debug_flags()

  This gets it in line with phoc_server_get_desktop()
  
* server: Make debug flags private

* treewide: Add and use phoc_server_get_wl_display()

  This gets it in line with phoc_server_get_desktop()
  
* server: Make wl_display private

* server: Make wl_source private

* server: Make wlr_subcompositor private

* treewide: Add and use phoc_server_get_backend()

  This gets it in line with phoc_server_get_desktop()
  
* server: Make backend private

* treewide: Use phoc_server_get_render()

  This gets it in line with phoc_server_get_desktop()
  
* server: Make renderer private

* treewide: Add and use phoc_server_get_compositor()

  This gets it in line with phoc_server_get_desktop()
  
* server: Make compositor private

* server: Make data device manager private

* server: Drop private data

  As the server is not derivable we can use `self` directly now
  that all data members are private.

Works toward merging desktop and server into one object.

Merge request reports