Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • F Freeze Breaks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Teams
  • Releng
  • Freeze Breaks
  • Issues
  • #3
Closed
Open
Issue created Sep 03, 2020 by António Fernandes@antoniof🐚

Feature Freeze break request for nautilus port to Tracker 3

MR: GNOME/nautilus!553 (merged) CC @sthursfield @carlosg

Maintainers approval

The MR has mine and @oholy's approvals on the condition that the Release Team approves.

Summary

  • Changes nautilus dependencies to version 3 of tracker and tracker-miners, instead of version 2.
  • Some feature behavior changes for Starred files. No changes for search.
  • No UI or string changes.

Benefits

This allows disabling tracker 2 by default, minimizing duplicate indexing (by tracker 2 and tracker 3 miners).

This assumes all conditions are met for the "tracker 3 by default" scenario outlined in GNOME/Initiatives#17 (comment 904359).

As a fallback scenario, if other conditions for "tracker 3 by default" are not met, this MR is not to be merged.

Testing

The changes were tested by Sam and Ondrej, both under JHBuild and flatpak, and with a gnome-os virtual machine.

No change in behavior is expected in the search functionality. Regressions were found and fixed.

Feature changes

It was no possible to preserve behavior for starred files with tracker 3, due to file vs. content separation.

This allowed us to redesign the implementation and as such address long standing bugs:

  • silently failing to star files which were not indexed yet (newly added files).
  • silently failing to star files due to private tracker heuristics (e.g. blacklisted filenames)
  • not allowing to star files outside indexed directories

Automatic migration of starred files is included, which prevents data loss on upgrade.

Known regression

As a regression of this MR, starred files lose their star when moving/renaming (like broken Bookmarks). I believe this is fixable by updating and adapting another MR (GNOME/nautilus!112). This other merge request is not ready yet, but it may be a candidate for hard code freeze break, or simply waiting for 3.38.1 to provide the regression fix.

Assignee
Assign to
Time tracking