Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Faces of GNOME Faces of GNOME
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 18
    • Issues 18
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Teams
  • EngagementEngagement
  • Websites
  • Faces of GNOMEFaces of GNOME
  • Merge requests
  • !96

patch (docker): uncomplicate volumes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Kevin Samuel requested to merge kevinnls/people-of-gnome:feat/uncomplicate-docker into main May 30, 2022
  • Overview 1
  • Commits 3
  • Pipelines 4
  • Changes 3

volumes need not be mounted; declaration suffices

changes

  1. docker-compose.yml

    remove all volumes mounts

  2. Dockerfile

    declare volumes at end

    Changing the volume from within the Dockerfile: If any build steps change the data within the volume after it has been declared, those changes will be discarded.

    source

  3. README.md

    • remove mounts from instructions
    • compose installation is a lot simpler now and default on Linux with convenience script
      • documented at https://docs.docker.com/compose/install/#install-compose-on-linux-systems
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feat/uncomplicate-docker