1. 24 Mar, 2020 4 commits
    • Jean Felder's avatar
    • Jean Felder's avatar
      artistsview: Correctly select the first artist on launch · 5804f9b5
      Jean Felder authored
      On some setups (mostly flatpak), the first artist from the
      ArtistsView's sidebar may not be selected on launch.
      Indeed, it relies on listening to the artists-loaded signal from the
      CoreModel to select the first artist once the artists model is
      loaded. However, this signal may already have been emitted when the
      ArtistView is built. In that case, the first artist will never be
      Now, ArtistsView instead directly listens to the artists model for
      changes and uses an initial state variable (untouched_list) to check
      if it is needed to activate a row.
      The artists-loaded signal from CoreModel is now unused. It can be
    • Jean Felder's avatar
      albumsview: Prevent a selection-mode trigger on launch · e86d4d32
      Jean Felder authored
      On some setups (mostly flatpak) selection-mode can be triggered on
      launch when show_all is called in AlbumsView.
      Indeed, if at least one AlbumCover has been loaded before the show_all
      call, its check button will become visible. Because of a property
      binding, this will change the AlbumCover selection-mode property to
      True. This selection-mode change is then propagated up to the Window.
      Fix the issue by removing the show_all call and making AlbumsView
      visible by default.
    • Marinus Schraal's avatar
      coremodel: Don't bind player validation · 0089ca26
      Marinus Schraal authored
      Since fb9878fa starting to play a song from a new set player playlist
      is relatively slow. It is however unneeded to bind validation back to
      the main model song as it is just a short-lived playability check for
      local songs.
      Remove the validation property binding to remedy the slowness.
  2. 23 Mar, 2020 1 commit
    • Marinus Schraal's avatar
      grltrackerplaylists: Add location filter to Playlist · 8641f63f
      Marinus Schraal authored
      Since 41c60ec7 all the songs in the Playlist are matched to a songs
      in the main songs model. The main songs model only contains songs from
      the filtered location, so any songs in a playlist outside of this
      location crashes Music as the hash match fails.
      Add a location filter to the songs queries in Playlist to prevent this
      from happening.
  3. 18 Mar, 2020 3 commits
    • Jean Felder's avatar
      gnome-music.in: Do not use pyexecdir variable · 85041828
      Jean Felder authored
      'pyexecdir' was used by JHBuild installations to find the associated
      pygobject module. JHBuild is no longer used for development
      purpose. Nowadays, flatpak is the preferred framework.
    • Jean Felder's avatar
      gnome-music.in: Do not change the module search path on installation · f2ad6321
      Jean Felder authored
      This can lead to some unexpected behaviors. See: #377.
      The search path changes are only needed for `local-music` (i.e.: to
      launch GNOME Music from the source tree).
      Closes: #377
    • bbbw's avatar
      searchview: Fix crash in FlowBox allocations · 99225107
      bbbw authored
      If a search is performed and allocation occurs and hides some results,
      the 'visible' property of the widget in the FlowBox will be assigned
      False. However, when a new search is performed, this property is not
      updated to True, but the old value is kept. So, if the search results
      for artist or albums happen to overlap with previously hidden results,
      then last_child in _on_artist_flowbox_size_allocate() and
      last_visible_child in _on_album_flowbox_size_allocate() can be None,
      which will cause a crash.
      To fix this, every time a new search is triggered all FlowBox widgets
      set 'visible' to True.
      Fixes #372
  4. 14 Mar, 2020 1 commit
    • Jean Felder's avatar
      coverstack: Do not update the cover on destroy · fb3f4232
      Jean Felder authored
      On rare occasions, the CoverStack can be destroyed while the art is
      updated. This can result in an error once the art is retrieved because
      the CoverStack does not have children anymore.
  5. 13 Mar, 2020 1 commit
  6. 12 Mar, 2020 1 commit
    • Jean Felder's avatar
      meson: Add pango dependency · d323c7c2
      Jean Felder authored
      Since commit 2aa733b7, the SongsView
      uses tabular number to display songs duration.
      This is only possible since pango 1.44 because PangoAttribute needs to
      be a boxed type (see
      By adding an explicit pango dependency, it prevents using Music
      without the proper pango dependency.
      Related: #374
  7. 10 Mar, 2020 1 commit
  8. 09 Mar, 2020 1 commit
  9. 07 Mar, 2020 2 commits
  10. 06 Mar, 2020 1 commit
  11. 05 Mar, 2020 1 commit
  12. 03 Mar, 2020 1 commit
  13. 02 Mar, 2020 6 commits
  14. 01 Mar, 2020 3 commits
  15. 29 Feb, 2020 1 commit
  16. 28 Feb, 2020 1 commit
    • Jean Felder's avatar
      grltrackerplaylists: Restore smart playlists update · d920337a
      Jean Felder authored
      This feature was lost during the core rewrite.
      Everytime a change is triggered, two smart playlists might need to be
       * the PlayerPlaylist (active_playlist)
       * the currently actively viewed playlist
      Besides, a smart playlist needs to be updated every time it becomes
      An update method is introduced to update a smart playlist content. The
      model of the SmartPlaylist is queried and compared with the previous
      one to perform the correct insert and remove operations.
  17. 26 Feb, 2020 4 commits
  18. 24 Feb, 2020 1 commit
  19. 23 Feb, 2020 4 commits
  20. 22 Feb, 2020 2 commits