GitLab

On some setups (mostly flatpak), the first artist from the
ArtistsView's sidebar may not be selected on launch.
Indeed, it relies on listening to the artists-loaded signal from the
CoreModel to select the first artist once the artists model is
loaded. However, this signal may already have been emitted when the
ArtistView is built. In that case, the first artist will never be
selected.

Now, ArtistsView instead directly listens to the artists model for
changes and uses an initial state variable (untouched_list) to check
if it is needed to activate a row.

The artists-loaded signal from CoreModel is now unused. It can be
removed.

On some setups (mostly flatpak) selection-mode can be triggered on
launch when show_all is called in AlbumsView.
Indeed, if at least one AlbumCover has been loaded before the show_all
call, its check button will become visible. Because of a property
binding, this will change the AlbumCover selection-mode property to
True. This selection-mode change is then propagated up to the Window.

Fix the issue by removing the show_all call and making AlbumsView
visible by default.

Since fb9878fa starting to play a song from a new set player playlist
is relatively slow. It is however unneeded to bind validation back to
the main model song as it is just a short-lived playability check for
local songs.

Remove the validation property binding to remedy the slowness.

Since 41c60ec7 all the songs in the Playlist are matched to a songs
in the main songs model. The main songs model only contains songs from
the filtered location, so any songs in a playlist outside of this
location crashes Music as the hash match fails.

Add a location filter to the songs queries in Playlist to prevent this
from happening.

'pyexecdir' was used by JHBuild installations to find the associated
pygobject module. JHBuild is no longer used for development
purpose. Nowadays, flatpak is the preferred framework.

This can lead to some unexpected behaviors. See: #377.

The search path changes are only needed for `local-music` (i.e.: to
launch GNOME Music from the source tree).

Closes: #377

If a search is performed and allocation occurs and hides some results,
the 'visible' property of the widget in the FlowBox will be assigned
False. However, when a new search is performed, this property is not
updated to True, but the old value is kept. So, if the search results
for artist or albums happen to overlap with previously hidden results,
then last_child in _on_artist_flowbox_size_allocate() and
last_visible_child in _on_album_flowbox_size_allocate() can be None,
which will cause a crash.

To fix this, every time a new search is triggered all FlowBox widgets
set 'visible' to True.

Fixes #372

On rare occasions, the CoverStack can be destroyed while the art is
updated. This can result in an error once the art is retrieved because
the CoverStack does not have children anymore.

Since commit 2aa733b7, the SongsView
uses tabular number to display songs duration.

This is only possible since pango 1.44 because PangoAttribute needs to
be a boxed type (see
GNOME/pygobject#312)

By adding an explicit pango dependency, it prevents using Music
without the proper pango dependency.

Related: #374

On search Grilo would search online sources by default as well. This is
unwanted as it is a privacy issue.

Currently Music has no UI to enable/disable this by user request, go the
safe route and disable it for stable release.

Closes #317

Validation is only set in PlayerPlaylist, so having the property binding
one-way is fine.

Every playlist type was binding the state and validation properties
seperately. Unify this in one function.

Playlist songs do not receive change notifications as they are created
as separate CoreSong's from the main song model.

To fix this, create a binding for all properties between the main
CoreSong and the Playlist equivalent.

The player model needs to set state towards the main playlist model to
keep the different CoreSong's in sync.

Make the binding between the coresongs bidirectional.

When reacting to the items-changed signal on the current playlist model,
all items were removed & added one at a time. This would result in
changes possibly stopping the playing playlist, as the playlist could
effectively become empty.

Instead make the signal handler smarter and splice the changes in
one go.

The tracker:id should refer to the song, not the url.

This feature was lost during the core rewrite.

Everytime a change is triggered, two smart playlists might need to be
updated:
 * the PlayerPlaylist (active_playlist)
 * the currently actively viewed playlist
Besides, a smart playlist needs to be updated every time it becomes
visible.

An update method is introduced to update a smart playlist content. The
model of the SmartPlaylist is queried and compared with the previous
one to perform the correct insert and remove operations.

On a playlist deletion, stop the the player and hide the player
toolbar if the player playlist is the playlist which is deleted.

This feature was lost during the core rewrite.

Everything can be done with only one function.

Removes warning in section `Coding Style` about the project being in a mixed-style state.
The codebase now fully adheres to the style standard defined in PEP-8.
My editor defaults to inserting a newline at the end of opened files,
the newline it added is removed.