1. 15 Jul, 2019 2 commits
  2. 14 Jul, 2019 8 commits
    • Sam Thursfield's avatar
      Merge branch 'sam/raw-warning-fix' into 'master' · 323aa7e3
      Sam Thursfield authored
      tracker-extract-raw.c: Fix compile warning
      
      See merge request GNOME/tracker-miners!87
      323aa7e3
    • Sam Thursfield's avatar
      Replace TrackerDomainOntology class with a simpler function · 2148096b
      Sam Thursfield authored
      This allows us to remove some code from libtracker-miners-common, but
      the motivation is actually to fix a name conflict between
      libtracker-common and libtracker-miners-common.
      
      Previously we were prevented from linking statically to
      libtracker-miner, and prevented from using link-time optimization,
      due to the duplicate GTypes.
      
      The code is now diverged from that in libtracker-common, but it's
      unlikely to see major changes because the "domain ontology" format is
      part of Tracker's public API.
      
      Fixes: GNOME/tracker#116
      2148096b
    • Sam Thursfield's avatar
      tracker-extract-raw.c: Fix compile warning · 209b3ec8
      Sam Thursfield authored
      There is some witchcraft in GLib's definition of g_clear_pointer(). The
      function definition is overridden by a macro in `glib/gmem.h`, and the
      macro generates this warning if we cast the 'destroy' parameter to the
      expected type:
      
          [101/264] Compiling C object 'src/tracker-extract/ec38c81@@extract-raw@sha/tracker-extract-raw.c.o'.
          In file included from /usr/include/glib-2.0/glib/glist.h:32,
                           from /usr/include/glib-2.0/glib/ghash.h:33,
                           from /usr/include/glib-2.0/glib.h:50,
                           from /usr/include/glib-2.0/gobject/gbinding.h:28,
                           from /usr/include/glib-2.0/glib-object.h:23,
                           from /usr/include/gexiv2/gexiv2-metadata.h:14,
                           from /usr/include/gexiv2/gexiv2.h:13,
                           from ../src/tracker-extract/tracker-extract-raw.c:24:
          ../src/tracker-extract/tracker-extract-raw.c: In function ‘tracker_extract_get_metadata’:
          ../src/tracker-extract/tracker-extract-raw.c:462:24: warning: function called through a non-compatible type
            g_clear_pointer (&ed, (GDestroyNotify) raw_exif_data_free);
                                  ^
      
      Removing the cast prevents the warning from appearing.
      209b3ec8
    • Sam Thursfield's avatar
      Merge branch 'sam/config.h-subproject-warning' into 'master' · 7d28aa87
      Sam Thursfield authored
      Rename config.h to config-miners.h
      
      See merge request GNOME/tracker-miners!84
      7d28aa87
    • Sam Thursfield's avatar
      Rename config.h to config-miners.h · 54144c9a
      Sam Thursfield authored
      This fixes compile warnings which show up when we build with
      -Dtracker_core=subproject. This is an example of the kind of
      warning:
      
          [7/186] Compiling C object 'subprojects/tracker/src/tracker-store/7bb4675@@tracker-store@exe/tracker-config.c.o'.
          In file included from ../subprojects/tracker/src/tracker-store/tracker-config.c:21:
          subprojects/tracker/./config.h:25: warning: "GETTEXT_PACKAGE" redefined
             25 | #define GETTEXT_PACKAGE "tracker"
                |
          In file included from <command-line>:
          ./config.h:25: note: this is the location of the previous definition
             25 | #define GETTEXT_PACKAGE "tracker-miners"
                |
      54144c9a
    • Sam Thursfield's avatar
      Merge branch 'sam/g-add-private' into 'master' · f3550b4a
      Sam Thursfield authored
      Use G_ADD_PRIVATE() instead of g_type_class_add_private()
      
      Closes tracker#115
      
      See merge request GNOME/tracker-miners!85
      f3550b4a
    • Sam Thursfield's avatar
      tracker-extract-gstreamer.c: Add comment · 21ed37cd
      Sam Thursfield authored
      21ed37cd
    • Sam Thursfield's avatar
      Merge branch 'fix_gstreamer_segfault_tags' into 'master' · 815fab61
      Sam Thursfield authored
      tracker-extract-gstreamer.c: Set empty tags list if no tags were found
      
      See merge request GNOME/tracker-miners!86
      815fab61
  3. 13 Jul, 2019 1 commit
    • nightuser's avatar
      tracker-extract-gstreamer.c: Set empty tags list if no tags were found · b009126f
      nightuser authored
      If entry doesn't has tags then `tracker_toc_add_entry` receives NULL
      instead of the tag list. But this function immediately tries to make a
      reference to the tag list and fails on NULL pointer. And every function
      in `tracker-cue-sheet.c` assumes that the list is non-NULL.
      
      Now it creates empty tag list if an entry doesn't contain tags. It
      shouldn't have any impact since in normal case tag list is copied.
      b009126f
  4. 12 Jul, 2019 1 commit
  5. 11 Jul, 2019 3 commits
  6. 10 Jul, 2019 11 commits
    • Sam Thursfield's avatar
      Merge branch 'sam/ft-traceback-fix' into 'master' · bc494246
      Sam Thursfield authored
      functional-tests: Remove a double-traceback
      
      See merge request GNOME/tracker-miners!82
      bc494246
    • Sam Thursfield's avatar
      Merge branch 'sam/static-libtracker-miners-common' into 'master' · aea42998
      Sam Thursfield authored
      build: libtracker-miners-common should be a static library
      
      See merge request GNOME/tracker-miners!83
      aea42998
    • Sam Thursfield's avatar
      build: libtracker-miners-common should be a static library · 65b1d237
      Sam Thursfield authored
      This library is API-unstable helper code. In the Autotools build system
      we only linked to it statically and didn't install it.
      
      Fixes a regression introduced in 8c1ff9cf, where we stopped installing
      the library but didn't make it static, which totally broke installed
      versions of Tracker.
      65b1d237
    • Sam Thursfield's avatar
      functional-tests: Remove a double-traceback · d6a50949
      Sam Thursfield authored
      Before:
      
          Traceback (most recent call last):
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/helpers.py", line 403, in await_resource_inserted
              self.loop.run_checked()
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/mainloop.py", line 58, in run_checked
              raise self._exception
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/helpers.py", line 294, in _graph_updated_timeout_cb
              raise GraphUpdateTimeoutException()
          common.utils.helpers.GraphUpdateTimeoutException
      
          During handling of the above exception, another exception occurred:
      
          Traceback (most recent call last):
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/minertest.py", line 145, in setUp
              super(CommonTrackerMinerFTSTest, self).setUp()
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/minertest.py", line 82, in setUp
              self.create_test_data()
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/minertest.py", line 117, in create_test_data
              self.tracker.await_resource_inserted(NFO_DOCUMENT, url=self.uri(tf))
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/helpers.py", line 405, in await_resource_inserted
              raise GraphUpdateTimeoutException("Timeout waiting for resource: class %s, URL %s, title %s" % (rdf_class, url, title))
          common.utils.helpers.GraphUpdateTimeoutException: Timeout waiting for resource: class http://www.semanticdesktop.org/ontologies/2007/03/22/nfo#Document, URL file:///home/tracker/tracker-tests/tmp6bkbec7d/test-monitored/dir1/file2.txt, title None
      
      After:
      
          Traceback (most recent call last):
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/minertest.py", line 145, in setUp
              super(CommonTrackerMinerFTSTest, self).setUp()
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/minertest.py", line 82, in setUp
              self.create_test_data()
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/minertest.py", line 117, in create_test_data
              self.tracker.await_resource_inserted(NFO_DOCUMENT, url=self.uri(tf))
            File "/builds/GNOME/tracker-miners/tests/functional-tests/common/utils/helpers.py", line 405, in await_resource_inserted
              raise GraphUpdateTimeoutException("Timeout waiting for resource: class %s, URL %s, title %s" % (rdf_class, url, title))
          common.utils.helpers.GraphUpdateTimeoutException: Timeout waiting for resource: class http://www.semanticdesktop.org/ontologies/2007/03/22/nfo#Document, URL file:///home/tracker/tracker-tests/tmp6bkbec7d/test-monitored/dir1/file2.txt, title None
      d6a50949
    • Sam Thursfield's avatar
      Merge branch 'sam/test-warning-fixes' into 'master' · 6055f5ed
      Sam Thursfield authored
      Avoid g_critical() errors when unable to connect to upower
      
      Closes #75
      
      See merge request GNOME/tracker-miners!81
      6055f5ed
    • Sam Thursfield's avatar
      Avoid g_critical() errors when unable to connect to upower · 0d11b245
      Sam Thursfield authored
      This removes two g_critical() errors that are seen when running the
      tests in CI.
      
      Before:
      
          (tracker-miner-fs:7050): libupower-glib-WARNING **: 14:31:50.109: Couldn't connect to proxy: Could not connect: No such file or directory
      
          (tracker-miner-fs:7050): GLib-GObject-CRITICAL **: 14:31:50.109: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
      
          (tracker-miner-fs:7050): GLib-GObject-CRITICAL **: 14:31:50.109: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
      
          ** (tracker-miner-fs:7050): WARNING **: 14:31:50.109: Unable to connect to UPower
      
      After:
      
          (tracker-miner-fs:12620): libupower-glib-WARNING **: 14:38:52.337: Couldn't connect to proxy: Could not connect: No such file or directory
      
          ** (tracker-miner-fs:12620): WARNING **: 14:38:52.337: Unable to connect to UPower
      
      Fixes GNOME/tracker-miners#75
      0d11b245
    • Sam Thursfield's avatar
      Merge branch 'sam/build-fixes' into 'master' · acb65649
      Sam Thursfield authored
      Fix some broken-by-default aspects of the developer experience
      
      See merge request GNOME/tracker-miners!80
      acb65649
    • Sam Thursfield's avatar
      Merge branch 'wip/jfelder/audio-writeback' into 'master' · 1d545b0e
      Sam Thursfield authored
      writeback: Add GStreamer based writeback module
      
      See merge request GNOME/tracker-miners!48
      1d545b0e
    • Sam Thursfield's avatar
      build: Compile GSettings schemas after install · 1bace075
      Sam Thursfield authored
      This isn't needed in the common case of distro package builds, as the
      distro package will already provide a hook. However, our README.md
      tells developers to install into a prefix like ~/opt/tracker, and
      that is broken by default because GLib will complain that none of the
      settings schemas are installed.
      1bace075
    • Sam Thursfield's avatar
      build: Include libdir in rpath · 6a9199a8
      Sam Thursfield authored
      This fixes the case where Tracker is installed into a non-standard
      prefix such as /opt/tracker and then fails to start with an error
      such as this:
      
              /opt/tracker/bin/tracker: error while loading shared libraries: libtracker-control-2.0.so.0: cannot open shared object file: No such file or directory
      6a9199a8
    • Sam Thursfield's avatar
      build: Remove FIXME · b3f5cdfb
      Sam Thursfield authored
      This was already fixed in tracker.git
      (GNOME/tracker!64) so
      it presumably doesn't apply to tracker-miners.
      b3f5cdfb
  7. 08 Jul, 2019 10 commits
  8. 05 Jul, 2019 4 commits