1. 23 Jan, 2020 3 commits
  2. 21 Jan, 2020 1 commit
  3. 20 Jan, 2020 3 commits
  4. 19 Jan, 2020 1 commit
  5. 15 Jan, 2020 1 commit
  6. 14 Jan, 2020 1 commit
  7. 12 Jan, 2020 2 commits
  8. 11 Jan, 2020 2 commits
  9. 10 Jan, 2020 1 commit
  10. 04 Dec, 2019 7 commits
  11. 03 Dec, 2019 1 commit
  12. 02 Dec, 2019 13 commits
    • Mike Fleetwood's avatar
      Stop requesting partition paths of free space and metadata · 047a2481
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      In GParted_Core::set_device_partitions() the partition path is being
      queried from libparted.  However this is done before the switch
      statement on the type of the partition, so is called for all libparted
      partition objects including PED_PARTITION_FREESPACE and
      PED_PARTITION_METADATA ones.  As libparted numbers these partition
      objects as -1, it returns paths like "/dev/sda-1".
      
      Additionally when using GParted, with it's default DMRaid handling, on a
      dmraid started array this results in paths like
      "/dev/mapper/isw_ecccdhhiga_MyArray-1" being passed to
      is_dmraid_device() and make_path_dmraid_compatible().  Fortunately
      make_path_dmraid_compatible() does nothing and returns the same name.
      Call chain looks like:
      
          GParted_Core::set_device_partitions()
            get_partition_path(lp_partition)
              // where:
              // lp_partition->disk->dev->path = "/dev/mapper/isw_ecccdhhiga_MyArray"
              // lp_partition->type == PED_PARTITION_FREESPACE |
              //                       PED_PARTITION_METADATA
              //              ->num == -1
              ped_partition_get_path(lp_partition)
                return "/dev/mapper/isw_ecccdhhiga_MyArray-1"
              dmraid.is_dmraid_supported()
              dmraid.is_dmraid_device("/dev/mapper/isw_ecccdhhiga_MyArray-1")
                return true
              dmraid.make_path_dmraid_compatible("/dev/mapper/isw_ecccdhhiga_MyArray-1")
                return "/dev/mapper/isw_ecccdhhiga_MyArray-1"
      
      Fix by moving the get_partition_path() call inside the switch statement
      so that it is only called for PED_PARTITION_NORMAL,
      PED_PARTITION_LOGICAL and PED_PARTITION_EXTENDED partition types.
      
      Relevant commits:
      *   53c49349
          Simplify logic in set_device_partitions method
      
      *   81986c09
          Ensure partition path name is compatible with dmraid (#622217)
      047a2481
    • Mike Fleetwood's avatar
      Make 4 internally used only DMRaid methods private · fa682d37
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      fa682d37
    • Mike Fleetwood's avatar
      Recognise ATARAID members started by dmraid (#75) · 21cad97d
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      This is not strictly necessary as members are already recognised using
      blkid since this commit earlier in the sequence "Recognise ATARAID
      members (#75)".  However it makes sure active members are recognised
      even if blkid is not available and matches how file system detection
      queries the SWRaid_Info module.
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      21cad97d
    • Mike Fleetwood's avatar
      Display array device as mount point of dmraid started ATARAID members (#75) · bb865aaa
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      This matches how the array device is displayed as the mount point for
      mdadm started ATARAID members by "Display array device as mount point of
      mdadm started ATARAID members (#75)" earlier in this patchset.
      
      Extend the DMRaid module member cache to save the array device name and
      use as needed to display as the mount point.
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      bb865aaa
    • Mike Fleetwood's avatar
      Detect busy status of dmraid started ATARAID members (#75) · caec2287
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      Again this is to stop GParted allowing overwrite operations being
      performed on an ATARAID member while the array is actively using the
      member.  This time for dmraid started arrays using the kernel DM (Device
      Mapper) driver.
      
      The DMRaid module already uses dmraid to report active array names:
      
          # dmraid -sa -c
          isw_ecccdhhiga_MyArray
      
      To find active members in this array, (1) use udev to lookup the kernel
      device name:
      
          # udevadm info --query=name /dev/mapper/isw_ecccdhhiga_MyArray
          dm-0
      
      (2) list the member names exposed by the kernel DM driver through the
      /sys file system.
      
          # ls /sys/block/dm-0/slaves
          sdc  sdd
          # ls -l /sys/block/dm-0/slaves
          lrwxrwxrwx 1 root root 0 Nov 24 09:52 sdc -> ../../../../pci0000:00/0000:00:0d.0/ata3/host2/target2:0:0/2:0:0:0/block/sdc
          lrwxrwxrwx 1 root root 0 Nov 24 09:52 sdc -> ../../../../pci0000:00/0000:00:0d.0/ata4/host3/target3:0:0/3:0:0:0/block/sdd
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      caec2287
    • Mike Fleetwood's avatar
      Enable basic supported actions for ATARAID members (#75) · 425dfa37
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      When an ATARAID member is inactive allow basic supported actions of
      copy and move to be performed like with other recognised but only basic
      supported types.
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      425dfa37
    • Mike Fleetwood's avatar
      Prevent unmount of busy ATARAID members (#75) · 1f1f44ff
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      Since earlier commit "Display array device as mount point of mdadm
      started ATARAID members (#75)" GParted allows attempting to unmout a
      busy ATARAID member as if it was a file system.  This is not a valid
      thing to do, so disallow it.
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      1f1f44ff
    • Mike Fleetwood's avatar
      Display array uuid of mdadm recognised ATARAID members (#75) · f6c86835
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      f6c86835
    • Mike Fleetwood's avatar
      Display array device as mount point of mdadm started ATARAID members (#75) · 538c866d
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      This matches how other non-file systems are handled, by displaying the
      access reference in the mount point column.  For LVM Physical Volumes
      the Volume Group name is displayed [1] and for an active Linux Software
      RAID array the array device is displayed [2].
      
      [1] 8083f11d
          Display LVM2 VGNAME as the PV's mount point (#160787)
      
      [2] f6c2f00d
          Populate member mount point with SWRaid array device (#756829)
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      538c866d
    • Mike Fleetwood's avatar
      Detect busy status of mdadm started ATARAID members (#75) · 6e990ea4
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      This stops GParted allowing overwrite operations (such as create
      partition table or format with a whole device file system) being
      performed on an ATARAID member while the array is actively using the
      member.
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      6e990ea4
    • Mike Fleetwood's avatar
      Display correct type of mdadm recognised ATARAID members (#75) · ef6794b7
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      The previous commit, made mdadm recognised IMSM and DDF type ATARAID
      members get displayed as "linux-raid" (Linux Software RAID array
      member).  This was because of query method 1 in detect_filesystems().
      
      Fix this now by exposing and using the fstype of the member from the
      SWRaid_Info cache.
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      ef6794b7
    • Mike Fleetwood's avatar
      Parse ATARAID members from mdadm output and /proc/mdstat (#75) · 73bf8bef
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      Since mdadm release 3.0 (2009-06-02) [1] it has also supported external
      metadata formats IMSM (Intel Matrix Storage Manager) and DDF, previously
      only managed by dmraid.
      
      A number of distributions have switched to use mdadm and kernel MD
      (Multiple Devices) driver for managing these Firmware / BIOS / ATARAID
      arrays.  These include: Fedora >= 14 [2], RHEL / CentOS >= 6 [3],
      SLES >= 12 [4], Ubuntu >= 16.04 LTS.
      
      Therefore additionally parse members in these ATARAID arrays included in
      mdadm output, and when activated using the kernel MD driver, in file
      /proc/mdstat.  Add fstype to the SWRaid_Info cache records to
      distinguish members apart.  So far the rest of the GParted code
      continues to treat all members as FS_LINUX_SWRAID.  This will be
      resolved in following commits.
      
      Note that this in no way affects how GParted shows and partitions the
      array device itself, even those managed by dmraid and use the GParted
      DMRaid module.  It only affects how GParted shows the member drives
      themselves.
      
      [1] mdadm ANNOUNCE-3.0 file
          https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/tree/ANNOUNCE-3.0?h=mdadm-3.0
      
      [2] Fedora 14, Storage Administration Guide, 12.5. Linux RAID Subsystem
          https://docs.fedoraproject.org/en-US/Fedora/14/html/Storage_Administration_Guide/raid-subsys.html
          "...  Fedora 14 uses mdraid with external metadata to access ISW /
          IMSM (Intel firmware RAID) sets.  mdraid sets are configured and
          controlled through the mdadm utility."
      
      [3] RHEL 6, Storage Administration Guide, 17.3. Linux RAID Subsystem
          https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/storage_administration_guide/raid-subsys
          "mdraid also supports other metadata formats, known as external
          metadata.  Red Hat Enterprise Linux 6 uses mdraid with external
          metadata to access ISW / IMSM (Intel firmware RAID) sets.  mdraid
          sets are configured and controlled through the mdadm utility."
      
      [4] SUSE Linux Enterprise Server 12 Release Notes, 7.2.3 Driver for IMSM
          and DDF
          https://www.suse.com/releasenotes/x86_64/SUSE-SLES/12/#fate-316007
          "For IMSM and DDF RAIDs the mdadm driver is used unconditionally."
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      73bf8bef
    • Mike Fleetwood's avatar
      Recognise ATARAID members (#75) · aea6200d
      Mike Fleetwood authored and Curtis Gedak's avatar Curtis Gedak committed
      PATCHSET OVERVIEW
      
      A user had a Firmware / BIOS / ATARAID array of 2 devices configured as
      a RAID 0 (stripe) set.  On top of that was a GPT with the OS partitions.
      GParted displays the following errors on initial load and subsequent
      refresh:
      
              Libparted Error
          (-) Invalid argument during seek for read on /dev/sda
                                [ Retry ] [ Cancel ] [ Ignore ]
      
              Libparted Error
          (-) The backup GPT table is corrupt, but the
              primary appears OK, so that will be used.
                                    [  Ok  ] [ Cancel ]
      
      This is an Intel Software RAID array which stores metadata at the end of
      each member device, and so the first 128 KiB stripe of the set is stored
      in the first 128 KiB of the first member device /dev/sda which includes
      the GPT for the whole RAID 0 device.  Hence when libparted reads member
      device /dev/sda it finds a GPT describing a block device twice it's
      size and in results the above errors when trying to read the backup GPT.
      
      A more dangerous scenario occurs when using 2 devices configured in an
      Intel Software RAID 1 (mirrored) set with GPT on top.  On refresh
      GParted display this error for both members, /dev/sda and /dev/sdb:
      
              Libparted Warning
          /!\ Not all of the space available to /dev/sda appears to be used,
              you can fix the GPT to use all of the space (an extra 9554
              blocks) or continue with the current setting?
                                                        [  Fix  ] [ Ignore ]
      
      Selecting [Fix] gets libparted to re-write the backup GPT to the end of
      the member device, overwriting the ISW metadata!  Do that twice and both
      copies of the metadata are gone!
      
      Worked example of this more dangerous mirrored set case.  Initial setup:
      
          # dmraid -s
          *** Group superset isw_caffbiaegi
          --> Subset
          name   : isw_caffbiaegi_MyMirror
          size   : 16768000
          stride : 128
          type   : mirror
          status : ok
          subsets: 0
          devs   : 2
          spares : 0
      
          # dmraid -r
          /dev/sda: isw, "isw_caffbiaegi", GROUP, ok, 16777214 sectors, data@ 0
          /dev/sdb: isw, "isw_caffbiaegi", GROUP, ok, 16777214 sectors, data@ 0
      
          # wipefs /dev/sda
          offset               type
          ---------------------------------------------
          0x200                gpt   [partition table]
          0x1fffffc00          isw_raid_member   [raid]
      
      Run GParted and click [Fix] on /dev/sda.  Now the first member has gone:
      
          # dmraid -s
          *** Group superset isw_caffbiaegi
          --> *Inconsistent* Subset
          name   : isw_caffbiaegi_MyMirror
          size   : 16768000
          stride : 128
          type   : mirror
          status : inconsistent
          subsets: 0
          devs   : 1
          spares : 0
      
          # dmraid -r
          /dev/sdb: isw, "isw_caffbiaegi", GROUP, ok, 16777214 sectors, data@ 0
      
          # wipefs /dev/sda
          offset               type
          ---------------------------------------------
          0x200                gpt   [partition table]
      
      Click [Fix] on /dev/sdb.  Now all members of the array are gone:
      
          # dmraid -s
          no raid disks
      
          # dmraid -r
          no raid disks
      
          # wipefs /dev/sdb
          offset               type
          ---------------------------------------------
          0x200                gpt   [partition table]
      
      So GParted must not run libparted partition table scanning on the member
      devices in ATARAID arrays.  Only on the array device itself.
      
      In terms of the UI GParted must show disks which are ATARAID members as
      whole disk devices with ATARAID member content and detect array busy
      status to avoid allowing active members from being overwritten while in
      use.
      
      THIS COMMIT
      
      Recognise ATARAID member devices and display in GParted as whole device
      "ataraid" file systems.  Because they are recognised as whole device
      content ("ataraid" file systems) this alone stops GParted running the
      libparted partition table scanning and avoids the above errors.
      
      The list of dmraid supported formats is matched by the signatures
      recognised by blkid:
      
          $ dmraid -l
          asr     : Adaptec HostRAID ASR (0,1,10)
          ddf1    : SNIA DDF1 (0,1,4,5,linear)
          hpt37x  : Highpoint HPT37X (S,0,1,10,01)
          hpt45x  : Highpoint HPT45X (S,0,1,10)
          isw     : Intel Software RAID (0,1,5,01)
          jmicron : JMicron ATARAID (S,0,1)
          lsi     : LSI Logic MegaRAID (0,1,10)
          nvidia  : NVidia RAID (S,0,1,10,5)
          pdc     : Promise FastTrack (S,0,1,10)
          sil     : Silicon Image(tm) Medley(tm) (0,1,10)
          via     : VIA Software RAID (S,0,1,10)
          dos     : DOS partitions on SW RAIDs
      
          $ fgrep -h _raid_member util-linux/libblkid/src/superblocks/*.c
                  .name           = "adaptec_raid_member",
                  .name           = "ddf_raid_member",
                  .name           = "hpt45x_raid_member",
                  .name           = "hpt37x_raid_member",
                  .name           = "isw_raid_member",
                  .name           = "jmicron_raid_member",
                  .name           = "linux_raid_member",
                  .name           = "lsi_mega_raid_member",
                  .name           = "nvidia_raid_member",
                  .name           = "promise_fasttrack_raid_member",
                  .name           = "silicon_medley_raid_member",
                  .name           = "via_raid_member",
      
      As they are all types of Firmware / BIOS / ATARAID arrays, report all
      members as a single "ataraid" file system type.  (Except for
      "linux_raid_member" in the above blkid source listing which is Linux
      Software RAID).
      
      Closes #75 - Errors with GPT on RAID 0 ATARAID array
      aea6200d
  13. 01 Dec, 2019 2 commits
  14. 28 Nov, 2019 1 commit
  15. 14 Nov, 2019 1 commit