• Daniel Boles's avatar
    Notebook: Don’t show raw underline/markup in popup · 7fd9f2d3
    Daniel Boles authored
    If @menu_label == NULL, we create a default page->menu_label. This took
    @tab_label.get_label() and passed that to page->menu_label.set_text().
    This is wrong because we set the plain text of the menu_label from the
    rich text of @tab_label. So, if @tab_label used mnemonics or markup, our
    menu_label got the raw underline or markup tags shown in it as raw text.
    
    As we call set_text() on the menu Label, the fix is to be symmetric: use
    @tab_label’s get_text() as source, as that strips underlines and markup.
    
    It’s not worth making the default Label ‘inherit’ :use-underline/markup;
    that’s a slippery slope, and users wanting such things can just create a
    fully fledged GtkLabel to pass as @menu_label to suppress the default.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705509
    7fd9f2d3
Name
Last commit
Last update
.gitlab-ci Loading commit data...
build Loading commit data...
demos Loading commit data...
docs Loading commit data...
examples Loading commit data...
gdk Loading commit data...
gtk Loading commit data...
libgail-util Loading commit data...
m4 Loading commit data...
m4macros Loading commit data...
modules Loading commit data...
po Loading commit data...
po-properties Loading commit data...
tests Loading commit data...
testsuite Loading commit data...
.gitlab-ci.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
HACKING Loading commit data...
INSTALL.in Loading commit data...
MAINTAINERS Loading commit data...
Makefile.am Loading commit data...
Makefile.decl Loading commit data...
NEWS Loading commit data...
NEWS.pre-1-0 Loading commit data...
README.commits Loading commit data...
README.in Loading commit data...
README.win32 Loading commit data...
acinclude.m4 Loading commit data...
autogen.sh Loading commit data...
config.h.win32.in Loading commit data...
configure.ac Loading commit data...
gail-3.0.pc.in Loading commit data...
gdk-3.0.pc.in Loading commit data...
git.mk Loading commit data...
gtk+-3.0.pc.in Loading commit data...
gtk+-unix-print-3.0.pc.in Loading commit data...
gtk+.doap Loading commit data...
gtk-zip.sh.in Loading commit data...
make-pot Loading commit data...
makefile.msc Loading commit data...
sanitize-la.sh Loading commit data...