1. 14 Jun, 2014 2 commits
    • Matthias Clasen's avatar
      gtk-update-icon-cache: Add an --include-image-data option · a666827d
      Matthias Clasen authored
      Now that we don't include the image data by default anymore,
      lets add an option that  does it.
    • Jasper St. Pierre's avatar
      updateiconcache: Don't include image data by default anymore · 6f92c794
      Jasper St. Pierre authored
      Since large images are in the icon cache, and apps don't tend to use that
      many icons anymore, simply don't include image data and instead make apps
      load files from disk. Additionally, since they're stored in GdkPixbuf data,
      that means that we have to first convert them either to a cairo_surface_t,
      which requires converting pixel data to be premulitplied, or an OpenGL
      texture, which requires a whole GPU upload anyway.
      So, even with the icon cache, the goal of icons through zero-copy, mmap()'d
      data from disk just isn't doable with the icon cache format we have. The
      icon cache on my disk is nearing 100MB, since we include a bunch of
      high-resolution application icons, that I doubt would be used by apps at all.
      Removing this inefficient pixel data makes memory usage for all applications
      go down, with no speed loss.
      The icon cache also, however, has an index of what icons are in each folder,
      which prevents a readdir() and allows GTK+ to know what icon is where without
      having to do a bunch of stat(); calls. Keeping this data is good for GTK+,
      so we should still keep the index.
      It doesn't make sense to remove any code for mapping pixel data from the icon
      cache. There's a plan in the works to have a symbolic icon cache that does
      pixel math on 16x16 icons to prevent slow SVG rendering. 16x16 pixels are
      fairly small, and such images are flat colors, which should compress easily,
      so the icon cache would be worthwhile here. So let's keep the code around
      in preparation for that case.
  2. 07 Feb, 2014 1 commit
  3. 21 Jan, 2014 1 commit
  4. 21 Feb, 2013 1 commit
  5. 04 Nov, 2012 1 commit
  6. 02 Oct, 2012 1 commit
  7. 27 Feb, 2012 1 commit
  8. 05 Jan, 2012 1 commit
  9. 03 Oct, 2011 1 commit
    • Chun-wei Fan's avatar
      Bug 660730: Use GStatBuf for portability · eb8c2dfa
      Chun-wei Fan authored
      Thanks to Kean Johnston for pointing this out.
      There are a few places in GTK that use "struct stat",
      and then g_stat(), rather than using GStatBuf.This breaks things on
      Windows. Since the size of struct stat can vary depending on other
      flags specified, this has the potential to cause overwrites and is
      trivial to fix.
      Based on patch submitted by Kean Johnston
  10. 29 Apr, 2011 1 commit
  11. 24 Jan, 2011 1 commit
  12. 24 Nov, 2010 1 commit
  13. 22 Nov, 2010 1 commit
  14. 03 Sep, 2009 1 commit
  15. 24 Aug, 2009 1 commit
  16. 18 Jun, 2009 1 commit
  17. 12 Jun, 2009 1 commit
    • Matthias Clasen's avatar
      Add a missing newline · 3f20ccd7
      Matthias Clasen authored
      There was a missing newline in one of the g_printerr messages
      in updateiconcache.c. String change.
  18. 11 May, 2009 2 commits
  19. 04 Aug, 2008 1 commit
  20. 18 Jul, 2008 1 commit
  21. 22 Jun, 2008 1 commit
    • Johan Dahlin's avatar
      Include "config.h" instead of <config.h> Command used: find -name · d97cdbdf
      Johan Dahlin authored
      2008-06-21  Johan Dahlin  <jdahlin@async.com.br>
          * *.[ch]: Include "config.h" instead of <config.h>
          Command used:
          find -name \*.[ch]|xargs perl -p -i -e 's/^#include <config.h>/#include "config.h"/g'
          Rubberstamped by Mitch and Tim
      svn path=/trunk/; revision=20669
  22. 07 Jun, 2008 1 commit
    • Tor Lillqvist's avatar
      Bug 536990 - updateiconcache.c: 'close ()' is redundant · 3610acff
      Tor Lillqvist authored
      2008-06-07  Tor Lillqvist  <tml@novell.com>
      	Bug 536990 - updateiconcache.c: 'close ()' is redundant
      	* gtk/updateiconcache.c (build_cache): Drop redundant close()
      	calls. fclose() on a fdopen()ed strema closes the underlying file
      svn path=/trunk/; revision=20327
  23. 03 Jun, 2008 1 commit
    • Tor Lillqvist's avatar
      Use g_open(). · 727a9145
      Tor Lillqvist authored
      2008-06-03  Tor Lillqvist  <tml@novell.com>
      	* gtk/updateiconcache.c (build_cache): Use g_open().
      svn path=/trunk/; revision=20303
  24. 29 May, 2008 1 commit
    • Tor Lillqvist's avatar
      Bug 535526 - updateiconcache.c: using open/close without prototype · 776c5094
      Tor Lillqvist authored
      2008-05-29  Tor Lillqvist  <tml@novell.com>
      	Bug 535526 - updateiconcache.c: using open/close without prototype
      	* gtk/updateiconcache.c: Include <io.h> if _MSC_VER. Also, use
      	g_utime() instead of utime() for UTF-8 pathname support on Windows
      	when available.
      svn path=/trunk/; revision=20238
  25. 27 May, 2008 1 commit
    • Tor Lillqvist's avatar
      Use simpler mode for open() on Windows. (No S_I?GRP and S_I?OTH bits are · ff89f905
      Tor Lillqvist authored
      2008-05-27  Tor Lillqvist  <tml@novell.com>
      	* gtk/updateiconcache.c (build_cache): Use simpler mode for open()
      	on Windows. (No S_I?GRP and S_I?OTH bits are defined in
      	<sys/stat.h> on Windows, and the mode used in open() doesn't
      	matter much as there are no rwxrwxrwx bits on Windows anyway.)
      	Open file in binary mode. Passing "b" to fdopen() later isn't
      svn path=/trunk/; revision=20190
  26. 25 May, 2008 1 commit
    • Cody Russell's avatar
      Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and · 6b06d71c
      Cody Russell authored
      2008-05-25  Cody Russell  <bratsche@gnome.org>
              Bug 523562 - gtk-update-icon-cache core dumps when run concurrently and
              when options are missing
              * gtk/updateiconcache.c: Open the cache file (O_CREAT | O_EXCL) so     
              that other processes that try to open it will fail gracefully.  Also
              fix a crasher caused by lack of a NULL check.  Report and patch
              by Erwann Chenede.
      svn path=/trunk/; revision=20167
  27. 05 Feb, 2008 3 commits
  28. 30 Jan, 2008 1 commit
    • Michael Natterer's avatar
      use the right type for "subparser_data" and remove the (gpointer*) cast. · 63af2cd0
      Michael Natterer authored
      2008-01-30  Michael Natterer  <mitch@imendio.com>
      	* gtk/gtkbuilderparser.c (parse_custom): use the right type for
      	"subparser_data" and remove the (gpointer*) cast. Fixes bogus
      	aliasing warning.
      	* gtk/updateiconcache.c (add_string): cast const gchar* to
      	gpointer when inserting in a GHashTable.
      	* tests/testcalendar.c (calendar_detail_cb): remove const from
      	return value since it's a newly allocated string.
      	(calendar_update_details): free the detail.
      svn path=/trunk/; revision=19431
  29. 12 Oct, 2007 1 commit
  30. 07 Sep, 2007 1 commit
  31. 01 May, 2007 1 commit
    • Matthias Clasen's avatar
      Add an icon cache validator. · 2a801133
      Matthias Clasen authored
      2007-05-01  Matthias Clasen  <mclasen@redhat.com>
              * gtk/gtkiconcachvalidator.[hc]: Add an icon cache validator.
              * gtk/updateiconcache.c: Validate the generated cache before
              moving it in place. Also add a --validate option to validate
              an existing icon cache.
              * gtk/gtkiconcache.c: Validate icon caches before using them.
              * gtk/Makefile.am: Integrate it.
      svn path=/trunk/; revision=17753
  32. 09 Mar, 2007 1 commit
  33. 15 Feb, 2007 1 commit
  34. 27 Jan, 2007 1 commit
  35. 02 Jan, 2007 2 commits
    • Matthias Clasen's avatar
      Include locale.h · 7bf87cf2
      Matthias Clasen authored
      svn path=/trunk/; revision=17026
    • Matthias Clasen's avatar
      Call setlocale(). · 78c7c07f
      Matthias Clasen authored
      2007-01-02  Matthias Clasen  <mclasen@redhat.com>
              * gtk/updateiconcache.c (main): Call setlocale().
              * gtk/gtkfilesel.c:
              * gtk/gtkfilesystemunix.c:
              * gtk/gtkfilesystemwin32.c:
              * gtk/gtkfilechoosersettings.c:
              * gtk/updateiconcache.c: Consistently use folder instead of
              directory in translated messages.  (#344584, Javier F. Serrador)
      svn path=/trunk/; revision=17024