1. 13 Mar, 2018 1 commit
    • Daniel Boles's avatar
      FileChooserWidget: Fix leaks in .get_subtitle() · 0f3396d7
      Daniel Boles authored
      Now that subtitle's default value "Searching" for OPERATION_MODE_SEARCH
      is duplicated as it should be, we cannot reassign other strings to it
      anymore, as that resulted in the original dupe of "Searching" leaking.
      
      Fix this by only assigning the dup'd "Searching" after trying to get
      more specific values, not before. We therefore need to set it to NULL
      during its declaration, and that means we needn't in the final else.
      0f3396d7
  2. 12 Mar, 2018 1 commit
    • Daniel Boles's avatar
      FileChooserWidget: Avoid crash freeing static str · 9d8fadee
      Daniel Boles authored
      Having a FileChooserDialog in location-entry mode then pressing
      <primary>f to move to search mode would crash with an invalid free().
      
      In that case, FileChooserWidget.get_subtitle() returned a static string
      straight from gettext. This crashed when the GBinding from :subtitle to
      FileChooserDialog’s HeaderBar:subtitle shortly tried to free the string.
      
      Fix by duplicating the string before returning it, like all other paths.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=791004
      9d8fadee
  3. 01 Mar, 2018 1 commit
  4. 31 Aug, 2017 1 commit
  5. 22 May, 2017 1 commit
  6. 17 Feb, 2017 2 commits
  7. 16 Feb, 2017 1 commit
  8. 18 Nov, 2016 1 commit
  9. 29 Aug, 2016 1 commit
  10. 16 Aug, 2016 1 commit
  11. 11 Aug, 2016 1 commit
  12. 04 Aug, 2016 1 commit
  13. 08 Jul, 2016 1 commit
  14. 26 May, 2016 1 commit
  15. 05 Apr, 2016 1 commit
  16. 25 Mar, 2016 1 commit
  17. 05 Mar, 2016 2 commits
  18. 28 Feb, 2016 1 commit
  19. 24 Feb, 2016 1 commit
  20. 16 Feb, 2016 1 commit
  21. 13 Feb, 2016 2 commits
  22. 04 Feb, 2016 1 commit
    • LRN's avatar
      Don't do remote checks on NULL files · 4a49d8d1
      LRN authored
      Calling _gtk_file_consider_as_remote() with a NULL argument
      results in warnings being thrown.
      
      Note that query->priv->location being NULL is a state that does
      not seem to be invalid by itself.
      
      This could happen if you do search-as-you-type in a filechooser,
      which has a filter that does not match anything *and* the current
      "place" selected is "Recent".
      
      https://bugzilla.gnome.org/show_bug.cgi?id=761552
      4a49d8d1
  23. 31 Jan, 2016 1 commit
  24. 30 Jan, 2016 1 commit
  25. 20 Jan, 2016 1 commit
  26. 14 Jan, 2016 1 commit
  27. 25 Nov, 2015 1 commit
  28. 22 Nov, 2015 1 commit
  29. 13 Nov, 2015 1 commit
  30. 16 Oct, 2015 1 commit
  31. 02 Oct, 2015 3 commits
  32. 16 Sep, 2015 1 commit
  33. 01 Sep, 2015 1 commit
  34. 23 Aug, 2015 1 commit
  35. 04 Aug, 2015 1 commit