1. 27 Jan, 2018 1 commit
  2. 26 Jan, 2018 1 commit
    • Timm Bäder's avatar
      menu: Guard against NULL toplevel · 136b8853
      Timm Bäder authored
      This can happen, as indicated by GtkMenu explicitly connecting to
      ::destroy of its toplevel window. Do the same thing in GtkComboBox.
      136b8853
  3. 24 Jan, 2018 2 commits
  4. 22 Jan, 2018 3 commits
    • Daniel Boles's avatar
      Widget: Don’t call reset() on NULL EventController · b8e24304
      Daniel Boles authored
      GtkGesture is a GtkEventController. gtk_event_controller_dispose() calls
      _gtk_widget_remove_controller(). That NULLs the pointer-to-Controller in
      our EventControllerData but does not delete said ECData from our GList.
      
      Subsequently, if that same Widget gets unparent()ed, that method calls
      unset_state_flags(), which leads to doing reset_controllers() if we are
      insensitive. Now, unlike most most other loops over the GList of ECData,
      reset_controllers() does not skip nodes whose pointer-to-Controller is
      NULL. So, we call gtk_event_controller_reset(NULL) and get a CRITICAL.
      
      This surfaced in a gtkmm program. The Gesture is destroyed before the
      Widget. The Widget then gets dispose()d, which calls unparent()… boom.
      I didn’t find an MCVE yet but would hope this logic is correct anyway:
      
      The simplest fix is to make the loop in gtk_widget_reset_controllers()
      skip GList nodes with a NULL Controller pointer, like most other such
      loops, so we avoid passing the NULL to gtk_event_controller_reset().
      
      In other, live cases, _gtk_widget_run_controllers() loops over the GList
      and removes/frees nodes having NULL Controllers, so that should suffice.
      But this clearly was not getting a chance to happen in the failing case.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=792624
      b8e24304
    • Administrator's avatar
      Update Esperanto translation · 814c55d4
      Administrator authored
      814c55d4
    • Juan Pablo Ugarte's avatar
      GtkGestureMultiPress: check event state before emiting released signal · beed1f66
      Juan Pablo Ugarte authored
      Fix bug 771986 "Inconsistent 'row-activated' signal emission before \
      drag'n'drop, 'activate-on-single-click'=TRUE, 'reorderable'=TRUE"
      beed1f66
  5. 21 Jan, 2018 2 commits
  6. 19 Jan, 2018 5 commits
  7. 17 Jan, 2018 1 commit
  8. 16 Jan, 2018 2 commits
  9. 15 Jan, 2018 2 commits
    • Piotr Drąg's avatar
      Update Polish translation · bb844e44
      Piotr Drąg authored
      bb844e44
    • Matthias Clasen's avatar
      emoji: Skip overly wide fallback rendering · 9e3b8145
      Matthias Clasen authored
      Some emoji fonts (such as Emoji One), render Emoji sequences
      such as some of the family variations using multiple individual
      glyphs. This rendering is too wide and breaks our grid layout.
      Therefore, we will just skip any sequence whose rendering is
      more than twice as wide as a simple smiley.
      9e3b8145
  10. 13 Jan, 2018 1 commit
  11. 12 Jan, 2018 3 commits
  12. 09 Jan, 2018 3 commits
  13. 08 Jan, 2018 2 commits
  14. 07 Jan, 2018 12 commits