1. 02 May, 2016 2 commits
    • Carlos Soriano Sánchez's avatar
      testnotebookdnd: add one GtkListBox as tab content · 264b2b78
      Carlos Soriano Sánchez authored
      To make sure we test regressions on widgets that bubble up motion
      handling and can trigger the motion handling code path on GtkNotebook.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=764395
      264b2b78
    • Carlos Soriano Sánchez's avatar
      gtknotebook: avoid tab dnd from content · ddb0740a
      Carlos Soriano Sánchez authored
      Before commit 6c1bee23 we were setting an attribute of GtkNotebook
      to track the pressed button if the pressed button happened on the
      tab itself.
      Later in the motion handling code we were checking whether the private
      pressed button attribute was set or not in order to handle a tab dnd
      or not.
      
      In commit 6c1bee23 the code changed and set the pressed button
      variable unconditionally, which means, a motion event from within the
      tab content triggered a tab reordering.
      
      This happened only if the children hierarchy have a widget that bubbles
      up both button press event, which sets the private pressed button
      attribute; and motion events, which started the tab dnd checking the
      private pressed button attribute.
      A widget that experienced the regression was GtkListBox.
      
      In order to fix it, set the button pressed variable only when it press
      the tab itself, not the content.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=764395
      ddb0740a
  2. 01 May, 2016 28 commits
  3. 30 Apr, 2016 1 commit
  4. 29 Apr, 2016 8 commits
  5. 28 Apr, 2016 1 commit