1. 30 Nov, 2004 1 commit
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · d5323add
      Federico Mena Quintero authored
      2004-11-29  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c (trap_activate_cb): Don't handle
      	Enter if we are in SELECT_FOLDER or CREATE_FOLDER actions.  This
      	lets us navigate thei file system more easily.
      	(gtk_file_chooser_default_should_respond): If we are in
      	SELECT_FOLDER or CREATE_FOLDER modes, return TRUE if something is
      	selected.
      d5323add
  2. 20 Nov, 2004 4 commits
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · dc478e86
      Federico Mena Quintero authored
      2004-11-20  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c (list_icon_data_func): Set an empty
      	icon if we are on the editable row:  if we don't set the cell
      	renderer at all, it will reuse the last thing it painted.
      dc478e86
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · e44612e7
      Federico Mena Quintero authored
      2004-11-19  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #141077.  Based on a patch by Christian Neumair <chris@gnome-de.org>:
      
      	* gtk/gtkfilechooserdefault.c (new_folder_button_clicked):
      	Desensitize the "new folder" button.
      	(edited_idle_cb): Sensitize the button back.
      e44612e7
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · a006f662
      Federico Mena Quintero authored
      2004-11-19  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #158477:
      
      	* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
      	Remove the "save_extra_align" and "browse_extra_align" fields; use
      	a single "extra_align" field.
      	(save_widgets_create): Don't create the save_extra_align.
      	(browse_widgets_create): Don't create the browse_extra_align.
      	(gtk_file_chooser_default_constructor): Create the extra_align
      	here.
      	(set_extra_widget): Add the extra widget to the alignment here,
      	and remove the old one if necessary.
      	(update_appearance): No need to frob the extra widget's alignments
      	anymore.
      	(gtk_file_chooser_default_set_property): No need to call
      	update_appearance() anymore when we set the extra widget.
      
      2004-11-19  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_initial_focus): Don't set the cursor if
      	we are still loading.
      a006f662
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · 74c14630
      Federico Mena Quintero authored
      2004-11-18  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fixes #155744:
      
      	Try to load the whole file system model within a specified time.
      
      	* gtk/gtkfilechooserdefault.c (set_list_model): Don't create and
      	set the sort model here.  Instead, set up a timer in which we'll
      	try to load the file system model.
      	(load_set_model): Create and set the sort model here.
      	(load_setup_timer): New function to set up a timer and switch to
      	the LOAD_LOADING state.
      	(load_remove_timer): New function to unset the timer and switch to
      	the LOAD_FINISHED state.
      	(browse_files_model_finished_loading_cb): Remove the timer if
      	needed and set the file system and sort model; switch to the
      	LOAD_FINISHED state.
      	(gtk_file_chooser_default_finalize): Remove the load timer.
      	(gtk_file_chooser_default_init): Start in the LOAD_FINISHED state.
      74c14630
  3. 19 Nov, 2004 1 commit
    • Manish Singh's avatar
      gdk/linux-fb/gdkgc-fb.c gdk/win32/gdkgc-win32.c · 60b30ff5
      Manish Singh authored
      Fri Nov 19 14:54:09 2004  Manish Singh  <yosh@gimp.org>
      
              * gdk/linux-fb/gdkgc-fb.c
              * gdk/win32/gdkgc-win32.c
              * gdk/win32/gdkwindow-win32.c
              * gtk/gtkaboutdialog.c
              * gtk/gtkaction.c
              * gtk/gtkactiongroup.c
              * gtk/gtkcellrendererprogress.c
              * gtk/gtkcellview.c
              * gtk/gtkcolorbutton.c
              * gtk/gtkcombobox.c
              * gtk/gtkcomboboxentry.c
              * gtk/gtkentrycompletion.c
              * gtk/gtkfilechooserbutton.c
              * gtk/gtkmenutoolbutton.c
              * gtk/gtkrc.c
              * gtk/gtksettings.c
              * gtk/gtkstyle.c
              * gtk/gtktoggletoolbutton.c
              * gtk/gtktoolbutton.c
              * gtk/gtktoolitem.c
              * gtk/gtktreemodelfilter.c
              * gtk/gtktreeselection.c
              * gtk/gtktreeviewcolumn.c
              * gtk/gtkuimanager.c: get rid of unnecessary casts.
      
              * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
              cast away the const for g_value_set_enum. This is after the g_warning,
              so this is a hack to begin with.
      
              * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
              add a cast to GTK_FILE_CHOOSER for impl here.
      60b30ff5
  4. 16 Nov, 2004 1 commit
  5. 07 Nov, 2004 2 commits
    • Matthias Clasen's avatar
      Show files in folder modes. (#157013, Nickolay V. Shmyrev) · 297a55d0
      Matthias Clasen authored
      2004-11-07  Matthias Clasen  <mclasen@redhat.com>
      
      	Show files in folder modes. (#157013, Nickolay V. Shmyrev)
      
      	* gtk/gtkfilechooserdefault.c (create_file_list): Use a selection
      	function to determine which rows can be selected.
      	(update_appearance): Always show files. Also queue a redraw.
      	(set_list_model): Always show files.
      	(list_select_func): The selection function used for the file list.
      	Don't allow to select files when in select/create folder mode.
      	(list_row_activated): Don't activate files in folder modes.
      	(list_icon_data_func, list_mtime_data_func, list_size_data_func):
      	Render files insensitive in folder modes.
      297a55d0
    • Matthias Clasen's avatar
      Jump through a few hoops to make the tooltip on the filter combo box work · 14ed2bef
      Matthias Clasen authored
      2004-11-06  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (file_pane_create): Jump through
      	a few hoops to make the tooltip on the filter combo box work
      	a bit better. This fixes #157273 and #157074.
      14ed2bef
  6. 04 Nov, 2004 1 commit
  7. 25 Oct, 2004 1 commit
    • Matthias Clasen's avatar
      Add a public setting for button ordering (#74669, Owen Taylor) · 8ab4fd45
      Matthias Clasen authored
      2004-10-25  Matthias Clasen  <mclasen@redhat.com>
      
      	Add a public setting for button ordering (#74669, Owen Taylor)
      
      	* gtk/gtksettings.c (gtk_settings_class_init): Add a
      	gtk-alternative-button-order setting.
      
      	* gtk/gtkdialog.h:
      	* gtk/gtkdialog.c (gtk_alternative_dialog_button_order): A
      	getter for the alternative button order setting.
      	* gtk/gtkdialog.c (gtk_dialog_set_alternative_button_order):
      	New function to install an alternative button order for a
      	dialog.
      
      	* gtk/gtkfilesel.c (gtk_file_selection_init):
      	* gtk/gtkfontsel.c (gtk_font_selection_dialog_init):
      	* gtk/gtkmessagedialog.c (gtk_message_dialog_add_buttons):
      	* gtk/gtkcolorseldialog.c (gtk_color_selection_dialog_init):
      	* gtk/gtkfilechooserdefault.c (location_popup_handler):
      	Set up an alternative button order.
      8ab4fd45
  8. 24 Oct, 2004 2 commits
    • Matthias Clasen's avatar
      Fix the build. · 6e950029
      Matthias Clasen authored
      6e950029
    • Matthias Clasen's avatar
      If the location dialog is brought up by typing '/', insert the slash in · a2997a60
      Matthias Clasen authored
      2004-10-24  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (location_popup_handler): If the
      	location dialog is brought up by typing '/', insert the slash
      	in the entry.  (#155370, Warren Togami)
      
      2004-10-23  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (tree_view_keybinding_cb)
      	(trap_activate_cb): Accept shift-/ for bringing up the location
      	popup, since German and French keyboards generate such
      	events.  (#154163, Frederic Crozat)
      a2997a60
  9. 22 Oct, 2004 1 commit
    • Matthias Clasen's avatar
      Use the new file DND api. · a811584d
      Matthias Clasen authored
      2004-10-22  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_drag_data_received)
      	(gtk_file_chooser_button_init): Use the new file DND api.
      
      	* gtk/gtkdnd.h:
      	* gtk/gtkdnd.c (gtk_drag_dest_add_uri_targets)
      	(gtk_drag_source_add_uri_targets):
      
      	* gtk/gtkselection.h:
      	* gtk/gtkselection.c (gtk_target_list_add_uri_targets):
      	(gtk_selection_data_set_uris):
      	(gtk_selection_data_get_uris): New functions to allow
      	handling file DND "without knowing jack shit".
      
      	* configure.in: Bump glib requirement to 2.5.4.
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Use
      	g_uri_list_extract_uris().
      a811584d
  10. 14 Oct, 2004 3 commits
  11. 08 Oct, 2004 2 commits
  12. 07 Oct, 2004 1 commit
  13. 26 Sep, 2004 2 commits
  14. 23 Sep, 2004 1 commit
    • Matthias Clasen's avatar
      Add some tooltips. · c09081f8
      Matthias Clasen authored
      2004-09-23  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c: Add some tooltips.
      c09081f8
  15. 22 Sep, 2004 2 commits
  16. 21 Sep, 2004 1 commit
  17. 20 Sep, 2004 1 commit
  18. 17 Sep, 2004 2 commits
    • Matthias Clasen's avatar
      Scroll to the selected row. (#143868, Christian Persch) · 627dc11c
      Matthias Clasen authored
      2004-09-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (select_func): Scroll to the selected
      	row.  (#143868, Christian Persch)
      627dc11c
    • Matthias Clasen's avatar
      Remove leftover debug code. · 350559de
      Matthias Clasen authored
      2004-09-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render): Remove
      	leftover debug code.
      
      	Improve the behaviour of the file chooser in save mode. Fixes bugs
      	#151031, #151608, #151994 reported by Owen Taylor and Alexander
      	Larsson.
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
      	(location_entry_create): Propagate the action to the file
      	chooser entries.
      	(gtk_file_chooser_default_should_respond): Switch folders if
      	the user enters a directory name in the entry and clear the entry
      	after switching folders.
      	(gtk_file_chooser_default_should_respond, shortcuts_row_activated_cb):
      	Move focus to the file list when activating a shortcut.
      	(gtk_file_chooser_default_should_respond): Handle the case where the
      	user clicks on "Save" after selecting a folder in the file list.
      
      	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
      	Propagate the action to the file chooser entries.
      
      	* gtk/gtkfilechooserentry.h:
      	* gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_action):
      	(_gtk_file_chooser_entry_get_action): New functions to propagate
      	the GtkFileChooserAction of the file chooser to the file chooser
      	entry.
      	(check_completion_callback): If we are in save mode, only do
      	inline completion for directories.
      350559de
  19. 26 Aug, 2004 1 commit
    • Manish Singh's avatar
      initialize path so we don't potentially use an undefined pointer. · 95674320
      Manish Singh authored
      Wed Aug 25 17:14:58 2004  Manish Singh  <yosh@gimp.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_search_activate): initialize
              path so we don't potentially use an undefined pointer.
      
              * gtk/gtkfilechooserdefault.c (shortcuts_list_create): add G_CALLBACK
              cast for tree_view_keybinding_cb.
      
              * gtk/gtkfilechooserdefault.c (location_entry_create): cast to
              GTK_FILE_CHOOSER_ENTRY for _gtk_file_chooser_entry_set_file_part()
              calls.
      
              * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_start_editing):
              cast to GTK_COMBO_BOX for gtk_combo_box_set_active_iter() call.
      
              * gtk/gtkselection.c (selection_get_text_plain): make len a gsize,
              since that's what g_convert_with_fallback() expects.
      95674320
  20. 25 Aug, 2004 2 commits
    • Jonathan Blandford's avatar
      Don't handle the event if we have no children. · 8bc41273
      Jonathan Blandford authored
      Tue Aug 24 02:06:37 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtktreeview.c
              (gtk_tree_view_real_expand_collapse_cursor_row): Don't handle the
              event if we have no children.
      
              * gtk/gtkfilechooserdefault.c (trap_activate_cb):
              (tree_view_keybinding_cb):Since GtkTreeView has a keybinding
               attached to '/', we need to catch keypresses before the TreeView
               gets them.
              (gtk_file_chooser_default_class_init): add '/' to be a keybinding
              to the C-l dialog.
              (location_entry_create): Clear the text to "" when loading a file.
              This has a much better feel than putting the currently selected
              in.
              * #include <errno.h>
      8bc41273
    • Matthias Clasen's avatar
      Use get_file_info() rather than trying get_folder() and checking for an · e4ef01a7
      Matthias Clasen authored
      2004-08-25  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (check_is_folder): Use get_file_info() rather
      	than trying get_folder() and checking for an error directly because older
      	versions of the gnome-vfs backend don't return an error
      	immediately.  (#150852, Zack Cerza )
      e4ef01a7
  21. 18 Aug, 2004 2 commits
    • Manish Singh's avatar
      Initialize height from fixed_height before we do anything, so it always · ba6fc3cc
      Manish Singh authored
      Wed Aug 18 16:18:00 2004  Manish Singh  <yosh@gimp.org>
      
              * gtk/gtktreeview.c (gtk_tree_view_row_inserted): Initialize height
              from fixed_height before we do anything, so it always has a valid
              value.
      
              * gtk/gtkfilechooserdefault.c (shortcuts_reload_icons): Fix call
              to gtk_tree_model_get (missing "," in param list).
      ba6fc3cc
    • Federico Mena Quintero's avatar
      Merged from 2.4: · 65ddedd1
      Federico Mena Quintero authored
      2004-08-18  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from 2.4:
      
      	Fixes #149251:
      
      	* gtk/gtkfilechooserdefault.c: Renamed SHORTCUTS_COL_PATH to
      	SHORTCUTS_COL_DATA.  Add SHORTCUTS_COL_IS_VOLUME, to determine
      	easily whether the SHORTCUTS_COL_DATA points to a GtkFilePath or a
      	GtkFileSystemVolume.
      	(shortcuts_model_create): Create a boolean column for
      	SHORTCUTS_COL_IS_VOLUME.
      	(shortcuts_reload_icons): Simplify with the use of the
      	SHORTCUTS_COL_IS_VOLUME column.  Don't leak the pixbuf.
      	(shortcuts_insert_path): Add the SHORTCUTS_COL_IS_VOLUME data.
      	(shortcuts_free_row_data): New helper function; frees the data
      	columns for an iter.
      	(shortcuts_remove_rows): Don't take a callback for freeing the
      	data; free everything here instead.  Use
      	shortcuts_free_row_data().
      	(volume_remove_cb): Removed.
      	(remove_bookmark_cb): Removed.
      	(remove_row_cb): Make this a single generic function to delete
      	rows.
      	(shortcuts_add_volumes): Use remove_row_cb().
      	(shortcuts_add_bookmarks): Likewise.
      	(struct _GtkFileChooserDefault): Removed the
      	shortcuts_current_folder_is_volume field.
      	(shortcuts_add_current_folder): Oops, don't free the volume.
      	(remove_current_folder_cb): Removed.
      	(shortcut_find_position): Simplify through the use of the
      	SHORTCUTS_COL_IS_VOLUME column.
      	(remove_selected_bookmarks): Assert that we don't get a volume.
      	(shortcuts_reorder): Likewise; also, plug a leak.
      	(gtk_file_chooser_default_remove_shortcut_folder): Simplify
      	through the use of shortcuts_remove_rows().
      	(gtk_file_chooser_default_list_shortcut_folders): Assert that we
      	don't get a volume.
      	(shortcuts_activate_iter): Simplify.
      	(home_folder_handler): Simplify by using
      	shortcuts_activate_iter().
      	(shortcuts_free): New function; frees all the data columns.
      	(gtk_file_chooser_default_finalize): Unref the
      	shortcuts_filter_model and the shortcuts model data first.
      65ddedd1
  22. 17 Aug, 2004 1 commit
    • Matthias Clasen's avatar
      New widget to go along with GtkFontButton and GtkColorButton for use in · a3aa10e5
      Matthias Clasen authored
      2004-08-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserbutton.[hc]: New widget to go along with
      	GtkFontButton and GtkColorButton for use in preference dialogs.
      	Replaces GnomeFileEntry.  (#148108, James M. Cape)
      
      	* gtk/gtk.h: Include gtkfilechooserbutton.h
      
      	* gtk/Makefile.am (gtk_public_h_sources): Add gtkfilechooserbutton.h
      	(gtk_c_sources): Add gtkfilechooserbutton.c
      
      	* gtk/gtk.symbols: Add the GtkFileChooserButton symbols.
      
      	* gtk/gtkfilechooserutils.[hc]: Make the delegate quark available.
      
      	* gtk/gtkfilechooserentry.[hc] (_gtk_file_chooser_entry_new): Allow
      	to suppress tab-eating using the new eat_tabs argument. Adjust all
      	callers.
      
      	* tests/testfilechooserbutton.c: Test for GtkFileChooserButton.
      
      	* tests/Makefile.am (noinst_PROGRAMS): Add testfilechooserbutton
      a3aa10e5
  23. 14 Aug, 2004 1 commit
    • Tor Lillqvist's avatar
      gtk/gtkfilechooserdefault.c (shortcuts_append_home, · ae6d3a22
      Tor Lillqvist authored
      2004-08-14  Tor Lillqvist  <tml@iki.fi>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_append_home,
      	shortcuts_append_desktop, set_local_only)
      	* gtk/gtkfilesystemwin32.c (gtk_file_system_win32_render_icon)
      	* gtk/gtkpathbar.c (find_button_type, _gtk_path_bar_set_file_system):
      	Guard against g_get_home_dir() returning NULL. (#150007)
      ae6d3a22
  24. 13 Aug, 2004 1 commit
  25. 12 Aug, 2004 2 commits
    • Matthias Clasen's avatar
      Underscore-prefix gtk_file_system_module_get_type(). Underscore-prefix · e4ec4f37
      Matthias Clasen authored
      2004-08-12  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilesystem.c: Underscore-prefix gtk_file_system_module_get_type().
      	* gtk/gtkfilechooserdefault.c: Underscore-prefix shortcuts_model_filter_get_type().
      
      	* gtk/gtkimmodule.c: Make gtk_im_module_get_type() static.
      	* gtk/gtk.symbols:
      	* gtk/gtkinternals.h: Remove the no longer exported get_type functions.
      e4ec4f37
    • Federico Mena Quintero's avatar
      Fix #149422, #143457: · c710d479
      Federico Mena Quintero authored
      2004-08-11  Federico Mena Quintero  <federico@ximian.com>
      
      	Fix #149422, #143457:
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_should_respond): Rewrite to take the
      	current focus into account, the contents of the save entry, and
      	the last focus for the shortcuts list.
      	(switch_to_selected_folder): We don't need an assertion on the
      	action here.
      c710d479
  26. 09 Aug, 2004 1 commit
    • Matthias Clasen's avatar
      Add hidden aliases for exported symbols which are used internally in order · 3612aee5
      Matthias Clasen authored
      Mon Aug  9 12:48:04 2004  Matthias Clasen  <maclas@gmx.de>
      
      	Add hidden aliases for exported symbols which are
      	used internally in order to get rid of many PLT
      	entries.  (#145519, Arjan van de Ven)
      
      	* gtk/Makefile.am: Add rules to generate gtk.def and
      	from gtk.symbols, and make make check check the abi
      	with abicheck.sh.
      	(gtk_private_h_sources): Add gtkinternals.h
      	(gtk_built_private_headers): Add gtkalias.h
      	(gtk_extra_sources): Add gtk.symbols
      	(EXTRA_DIST): Add makegtkalias.pl and abicheck.sh
      
      	* gtk/gtk.symbols: New file. Definition of the GTK+ ABI.
      	The file can be processed by cpp to filter out certain
      	subsets of symbols.
      
      	* gtk/abicheck.sh: New file. Script to check the actually
      	symbols exported from libgtk-x11.2.0.so against the symbols
      	found in gtk.symbols.
      
      	* gtk/makegtkalias.pl: New file. Perl script to generate the
      	header containing the alias definitions for internally used
      	exported symbols from a list of symbols.
      
      	* gtk/gtkinternals.h: New file. An uninstalled header listing
      	symbols which must be exported for some reason and do not appear
      	in any other header.
      
      	* gtk/*.c: Include gtkalias.h
      3612aee5