1. 05 Jan, 2005 2 commits
  2. 02 Jan, 2005 1 commit
    • Tor Lillqvist's avatar
      Add -lole32, needed for CoTaskMemFree in get_special_folder() below. · c668f46d
      Tor Lillqvist authored
      2005-01-02  Tor Lillqvist  <tml@iki.fi>
      
      	* gtk/Makefile.am (libgtk_target_ldflags): Add -lole32, needed for
      	CoTaskMemFree in get_special_folder() below.
      
      	* gtk/gtkfilesystem.h: Implement case-insensitive path compare on
      	Win32 using _gtk_file_system_win32_path_compare().
      
      	* gtk/gtk.symbols: Add _gtk_file_system_win32_path_compare.
      
      	* gtk/gtkfilechooserbutton.c (model_add_special)
      	* gtk/gtkfilechooserdefault.c (shortcuts_append_desktop): Use
      	_gtk_file_system_win32_get_desktop() to get correct Desktop folder
      	on Win32. (#144003)
      
      	* gtk/gtkfilesystemwin32.c: Remove unnecessary includes. Do
      	consider all drives "mounted", including floppies. Trying to
      	inspect the contents of a nonexistent floppy will cause errors
      	later that are handled normally, no need to avoid them
      	completely. Keep the drive type in the GtkFileSystemVolume.
      	Support UNC paths. (#161797) Fix error message capitalizations
      	as in gtkfilesystemunix.c.
      
      	(gtk_file_system_win32_init): Start one timeout per
      	GtkFileSystemWin32.
      
      	(gtk_file_system_win32_finalize): Remove the timeout.
      
      	(get_special_folder): Copied from GLib.
      
      	(_gtk_file_system_win32_get_desktop): New function, uses
      	get_special_folder().
      
      	(gtk_file_system_win32_list_volumes): Don't start a timeout at
      	each call to this function. Don't assume A: and B: are floppies.
      
      	(gtk_file_system_win32_get_volume_for_path): Don't assume all
      	volumes are drive roots, i.e. support share roots of UNC paths
      	(\\server\share).
      
      	(gtk_file_system_win32_get_folder): Don't assume errno is set
      	after g_file_test() returns FALSE. It isn't on Win32 (and even on
      	Unix I don't think one should assume anything about errno after
      	g_file_test()).
      
      	(gtk_file_system_win32_volume_get_is_mounted): Always return TRUE.
      
      	(gtk_file_system_win32_volume_get_display_name): Don't call
      	GetVolumeInformation() on drives A: or B: if they are removable,
      	as they might then be floppies, causing an unnecessary
      	delay. (#157820)
      
      	(gtk_file_system_win32_volume_render_icon): Use network icon for
      	unrecognized drive types.
      
      	(canonicalize_filename, gtk_file_system_win32_parse): Don't get
      	confused by UNC paths.
      
      	(bookmarks_serialize): Use _gtk_file_system_win32_path_compare()
      	for case-insensitive UTF-8 path comparison.
      
      	(extract_icon): Use SHGetFileInfo() which is faster than
      	ExtractAssociatedIcon(). Icon extraction is still slow, though,
      	needs work.
      
      	(win32_pseudo_mime_lookup): Don't use the same icon for all
      	shortcuts or executables. Cache only other file type icons.
      
      	(gtk_file_system_win32_render_icon): Use network stock icon for
      	remote drives and UNC server share roots. Compare home directory
      	case-insensitively. Do lookup icons also for executable files,
      	after all, it's these files that can have individual icons in the
      	first place. Yes, it can be slow. Needs work.
      
      	(filename_is_drive_root): Require also the slash after the colon.
      
      	(filename_is_server_share): New function.
      
      	(_gtk_file_system_win32_path_compare): New function, does
      	case-folded UTF-8 comparison.
      
      	* gtk/gtkfilesystemwin32.h: Declare
      	_gtk_file_system_win32_path_compare().
      c668f46d
  3. 30 Dec, 2004 1 commit
  4. 19 Dec, 2004 1 commit
    • Matthias Clasen's avatar
      Add missing GDK_THREADS_ENTER/LEAVE. · 947fcbbd
      Matthias Clasen authored
      2004-12-18  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserentry.c (check_completion_callback)
      	(load_directory_callback): Add missing GDK_THREADS_ENTER/LEAVE.
      
      	* gtk/gtkfilechooserdefault.c (edited_idle_cb)
      	(shortcuts_drag_outside_idle_cb): Add missing
      	GDK_THREADS_ENTER/LEAVE.  (#161604)
      
      	* gtk/gtkfilechooserdefault.c (selection_check_foreach_cb):
      	(list_select_func): Don't call gtk_file_info_get_is_folder()
      	on NULL.
      947fcbbd
  5. 15 Dec, 2004 2 commits
    • Matthias Clasen's avatar
      Don't try to filter if impl->current_filter is NULL. (#161329, R. · 43f85261
      Matthias Clasen authored
      2004-12-15  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (get_is_file_filtered): Don't
      	try to filter if impl->current_filter is NULL.  (#161329,
      	R. McFarland)
      43f85261
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · 9f558a15
      Federico Mena Quintero authored
      2004-12-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #145470:
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_initial_focus): Queue a pending
      	operation to select the first row if we are not finished loading
      	yet.
      	(gtk_file_chooser_default_class_init): Override GtkWidget::map().
      	(gtk_file_chooser_default_map): New ::map() handler; refresh the
      	file and bookmark lists.
      
      	* gtk/gtkfilechooserdialog.c (gtk_file_chooser_dialog_class_init):
      	Override GtkWidget::map() and GtkWidget::unmap().
      	(gtk_file_chooser_dialog_constructor): Don't call initial_focus()
      	here.
      	(gtk_file_chooser_dialog_map): Map the file chooser widget if
      	needed.  Call initial_focus() here.
      	(gtk_file_chooser_dialog_unmap): Unmap the file chooser widget.
      	When we are re-mapped, the widget will get mapped as well and it
      	will have a chance to refresh.
      9f558a15
  6. 09 Dec, 2004 2 commits
  7. 03 Dec, 2004 1 commit
  8. 02 Dec, 2004 1 commit
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · bc63304b
      Federico Mena Quintero authored
      2004-12-02  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #159656:
      
      	* gtk/gtkfilechooserdefault.c (PendingOp): New enumeration for the
      	pending operation to perform when finishing loading a folder.
      	(struct _GtkFileChooserDefault): New fields 'pending_op' and
      	'pending_select_path'.
      	(pending_op_queue): New utility function.
      	(pending_op_process): New utility function.
      	(gtk_file_chooser_default_select_path): Don't select the path
      	immediately; delay it until the folder is finished loading.
      	(browse_files_model_finished_loading_cb): Process the pending
      	operation.
      	(browse_files_select_first_row): New utility function.
      	(gtk_file_chooser_default_initial_focus): Use
      	browse_files_select_first_row().
      	(gtk_file_chooser_default_should_respond): Queue an operation to
      	select the first row once we load the child folder.
      	(up_folder_handler): Queue an operation to select the current
      	folder once we load the parent folder.
      	(gtk_file_chooser_default_finalize): Free the pending_select_path.
      bc63304b
  9. 30 Nov, 2004 1 commit
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · d5323add
      Federico Mena Quintero authored
      2004-11-29  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c (trap_activate_cb): Don't handle
      	Enter if we are in SELECT_FOLDER or CREATE_FOLDER actions.  This
      	lets us navigate thei file system more easily.
      	(gtk_file_chooser_default_should_respond): If we are in
      	SELECT_FOLDER or CREATE_FOLDER modes, return TRUE if something is
      	selected.
      d5323add
  10. 20 Nov, 2004 4 commits
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · dc478e86
      Federico Mena Quintero authored
      2004-11-20  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c (list_icon_data_func): Set an empty
      	icon if we are on the editable row:  if we don't set the cell
      	renderer at all, it will reuse the last thing it painted.
      dc478e86
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · e44612e7
      Federico Mena Quintero authored
      2004-11-19  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #141077.  Based on a patch by Christian Neumair <chris@gnome-de.org>:
      
      	* gtk/gtkfilechooserdefault.c (new_folder_button_clicked):
      	Desensitize the "new folder" button.
      	(edited_idle_cb): Sensitize the button back.
      e44612e7
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · a006f662
      Federico Mena Quintero authored
      2004-11-19  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fix #158477:
      
      	* gtk/gtkfilechooserdefault.c (struct _GtkFileChooserDefault):
      	Remove the "save_extra_align" and "browse_extra_align" fields; use
      	a single "extra_align" field.
      	(save_widgets_create): Don't create the save_extra_align.
      	(browse_widgets_create): Don't create the browse_extra_align.
      	(gtk_file_chooser_default_constructor): Create the extra_align
      	here.
      	(set_extra_widget): Add the extra widget to the alignment here,
      	and remove the old one if necessary.
      	(update_appearance): No need to frob the extra widget's alignments
      	anymore.
      	(gtk_file_chooser_default_set_property): No need to call
      	update_appearance() anymore when we set the extra widget.
      
      2004-11-19  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	* gtk/gtkfilechooserdefault.c
      	(gtk_file_chooser_default_initial_focus): Don't set the cursor if
      	we are still loading.
      a006f662
    • Federico Mena Quintero's avatar
      Merged from gtk-2-4: · 74c14630
      Federico Mena Quintero authored
      2004-11-18  Federico Mena Quintero  <federico@ximian.com>
      
      	Merged from gtk-2-4:
      
      	Fixes #155744:
      
      	Try to load the whole file system model within a specified time.
      
      	* gtk/gtkfilechooserdefault.c (set_list_model): Don't create and
      	set the sort model here.  Instead, set up a timer in which we'll
      	try to load the file system model.
      	(load_set_model): Create and set the sort model here.
      	(load_setup_timer): New function to set up a timer and switch to
      	the LOAD_LOADING state.
      	(load_remove_timer): New function to unset the timer and switch to
      	the LOAD_FINISHED state.
      	(browse_files_model_finished_loading_cb): Remove the timer if
      	needed and set the file system and sort model; switch to the
      	LOAD_FINISHED state.
      	(gtk_file_chooser_default_finalize): Remove the load timer.
      	(gtk_file_chooser_default_init): Start in the LOAD_FINISHED state.
      74c14630
  11. 19 Nov, 2004 1 commit
    • Manish Singh's avatar
      gdk/linux-fb/gdkgc-fb.c gdk/win32/gdkgc-win32.c · 60b30ff5
      Manish Singh authored
      Fri Nov 19 14:54:09 2004  Manish Singh  <yosh@gimp.org>
      
              * gdk/linux-fb/gdkgc-fb.c
              * gdk/win32/gdkgc-win32.c
              * gdk/win32/gdkwindow-win32.c
              * gtk/gtkaboutdialog.c
              * gtk/gtkaction.c
              * gtk/gtkactiongroup.c
              * gtk/gtkcellrendererprogress.c
              * gtk/gtkcellview.c
              * gtk/gtkcolorbutton.c
              * gtk/gtkcombobox.c
              * gtk/gtkcomboboxentry.c
              * gtk/gtkentrycompletion.c
              * gtk/gtkfilechooserbutton.c
              * gtk/gtkmenutoolbutton.c
              * gtk/gtkrc.c
              * gtk/gtksettings.c
              * gtk/gtkstyle.c
              * gtk/gtktoggletoolbutton.c
              * gtk/gtktoolbutton.c
              * gtk/gtktoolitem.c
              * gtk/gtktreemodelfilter.c
              * gtk/gtktreeselection.c
              * gtk/gtktreeviewcolumn.c
              * gtk/gtkuimanager.c: get rid of unnecessary casts.
      
              * gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
              cast away the const for g_value_set_enum. This is after the g_warning,
              so this is a hack to begin with.
      
              * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
              add a cast to GTK_FILE_CHOOSER for impl here.
      60b30ff5
  12. 16 Nov, 2004 1 commit
  13. 07 Nov, 2004 2 commits
    • Matthias Clasen's avatar
      Show files in folder modes. (#157013, Nickolay V. Shmyrev) · 297a55d0
      Matthias Clasen authored
      2004-11-07  Matthias Clasen  <mclasen@redhat.com>
      
      	Show files in folder modes. (#157013, Nickolay V. Shmyrev)
      
      	* gtk/gtkfilechooserdefault.c (create_file_list): Use a selection
      	function to determine which rows can be selected.
      	(update_appearance): Always show files. Also queue a redraw.
      	(set_list_model): Always show files.
      	(list_select_func): The selection function used for the file list.
      	Don't allow to select files when in select/create folder mode.
      	(list_row_activated): Don't activate files in folder modes.
      	(list_icon_data_func, list_mtime_data_func, list_size_data_func):
      	Render files insensitive in folder modes.
      297a55d0
    • Matthias Clasen's avatar
      Jump through a few hoops to make the tooltip on the filter combo box work · 14ed2bef
      Matthias Clasen authored
      2004-11-06  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (file_pane_create): Jump through
      	a few hoops to make the tooltip on the filter combo box work
      	a bit better. This fixes #157273 and #157074.
      14ed2bef
  14. 04 Nov, 2004 1 commit
  15. 25 Oct, 2004 1 commit
    • Matthias Clasen's avatar
      Add a public setting for button ordering (#74669, Owen Taylor) · 8ab4fd45
      Matthias Clasen authored
      2004-10-25  Matthias Clasen  <mclasen@redhat.com>
      
      	Add a public setting for button ordering (#74669, Owen Taylor)
      
      	* gtk/gtksettings.c (gtk_settings_class_init): Add a
      	gtk-alternative-button-order setting.
      
      	* gtk/gtkdialog.h:
      	* gtk/gtkdialog.c (gtk_alternative_dialog_button_order): A
      	getter for the alternative button order setting.
      	* gtk/gtkdialog.c (gtk_dialog_set_alternative_button_order):
      	New function to install an alternative button order for a
      	dialog.
      
      	* gtk/gtkfilesel.c (gtk_file_selection_init):
      	* gtk/gtkfontsel.c (gtk_font_selection_dialog_init):
      	* gtk/gtkmessagedialog.c (gtk_message_dialog_add_buttons):
      	* gtk/gtkcolorseldialog.c (gtk_color_selection_dialog_init):
      	* gtk/gtkfilechooserdefault.c (location_popup_handler):
      	Set up an alternative button order.
      8ab4fd45
  16. 24 Oct, 2004 2 commits
    • Matthias Clasen's avatar
      Fix the build. · 6e950029
      Matthias Clasen authored
      6e950029
    • Matthias Clasen's avatar
      If the location dialog is brought up by typing '/', insert the slash in · a2997a60
      Matthias Clasen authored
      2004-10-24  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (location_popup_handler): If the
      	location dialog is brought up by typing '/', insert the slash
      	in the entry.  (#155370, Warren Togami)
      
      2004-10-23  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (tree_view_keybinding_cb)
      	(trap_activate_cb): Accept shift-/ for bringing up the location
      	popup, since German and French keyboards generate such
      	events.  (#154163, Frederic Crozat)
      a2997a60
  17. 22 Oct, 2004 1 commit
    • Matthias Clasen's avatar
      Use the new file DND api. · a811584d
      Matthias Clasen authored
      2004-10-22  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_drag_data_received)
      	(gtk_file_chooser_button_init): Use the new file DND api.
      
      	* gtk/gtkdnd.h:
      	* gtk/gtkdnd.c (gtk_drag_dest_add_uri_targets)
      	(gtk_drag_source_add_uri_targets):
      
      	* gtk/gtkselection.h:
      	* gtk/gtkselection.c (gtk_target_list_add_uri_targets):
      	(gtk_selection_data_set_uris):
      	(gtk_selection_data_get_uris): New functions to allow
      	handling file DND "without knowing jack shit".
      
      	* configure.in: Bump glib requirement to 2.5.4.
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drop_uris): Use
      	g_uri_list_extract_uris().
      a811584d
  18. 14 Oct, 2004 3 commits
  19. 08 Oct, 2004 2 commits
  20. 07 Oct, 2004 1 commit
  21. 26 Sep, 2004 2 commits
  22. 23 Sep, 2004 1 commit
    • Matthias Clasen's avatar
      Add some tooltips. · c09081f8
      Matthias Clasen authored
      2004-09-23  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c: Add some tooltips.
      c09081f8
  23. 22 Sep, 2004 2 commits
  24. 21 Sep, 2004 1 commit
  25. 20 Sep, 2004 1 commit
  26. 17 Sep, 2004 2 commits
    • Matthias Clasen's avatar
      Scroll to the selected row. (#143868, Christian Persch) · 627dc11c
      Matthias Clasen authored
      2004-09-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkfilechooserdefault.c (select_func): Scroll to the selected
      	row.  (#143868, Christian Persch)
      627dc11c
    • Matthias Clasen's avatar
      Remove leftover debug code. · 350559de
      Matthias Clasen authored
      2004-09-17  Matthias Clasen  <mclasen@redhat.com>
      
      	* gtk/gtkcellrenderertext.c (gtk_cell_renderer_text_render): Remove
      	leftover debug code.
      
      	Improve the behaviour of the file chooser in save mode. Fixes bugs
      	#151031, #151608, #151994 reported by Owen Taylor and Alexander
      	Larsson.
      
      	* gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_set_property):
      	(location_entry_create): Propagate the action to the file
      	chooser entries.
      	(gtk_file_chooser_default_should_respond): Switch folders if
      	the user enters a directory name in the entry and clear the entry
      	after switching folders.
      	(gtk_file_chooser_default_should_respond, shortcuts_row_activated_cb):
      	Move focus to the file list when activating a shortcut.
      	(gtk_file_chooser_default_should_respond): Handle the case where the
      	user clicks on "Save" after selecting a folder in the file list.
      
      	* gtk/gtkfilechooserbutton.c (gtk_file_chooser_button_set_property):
      	Propagate the action to the file chooser entries.
      
      	* gtk/gtkfilechooserentry.h:
      	* gtk/gtkfilechooserentry.c (_gtk_file_chooser_entry_set_action):
      	(_gtk_file_chooser_entry_get_action): New functions to propagate
      	the GtkFileChooserAction of the file chooser to the file chooser
      	entry.
      	(check_completion_callback): If we are in save mode, only do
      	inline completion for directories.
      350559de