1. 27 Jan, 1999 1 commit
    • Tim Janik's avatar
      assert ref_count>0. · 90c7ea0b
      Tim Janik authored
      Wed Jan 27 09:19:07 1999  Tim Janik  <timj@gtk.org>
      
              * gdk/gdkcolor.c (gdk_colormap_unref): assert ref_count>0.
      90c7ea0b
  2. 26 Jan, 1999 5 commits
    • Owen Taylor's avatar
      New functions to set the colormap or visual of an existing widget. These · 8e979f59
      Owen Taylor authored
      Mon Jan 25 20:05:22 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkwidget.c (gtk_widget_set_{visual,colormap}):
      	New functions to set the colormap or visual
      	of an existing widget. These functions should not
      	be called on a widget that has previosly been
      	realized.
      8e979f59
    • Owen Taylor's avatar
      Changed log · 84c1a710
      Owen Taylor authored
      84c1a710
    • Owen Taylor's avatar
      New functions to set the colormap or visual of an existing widget. These · df403d59
      Owen Taylor authored
      Mon Jan 25 20:05:22 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkwidget.c (gtk_widget_set_{visual,colormap}):
      	New functions to set the colormap or visual
      	of an existing widget. These functions should not
      	be called on a widget that has previosly been
      	realized.
      
      	* gtk/gtkcolorsel.c (gtk_color_selection_dialog_init):
      	Set the visual and colormap on the toplevel dialog,
      	then push them for the child widgets. As opposed
      	to push/pop in _new(), this way, things will work
      	properly with gtk_widget_new().
      df403d59
    • Owen Taylor's avatar
      Queue a redraw on the tab area when a tab changes size. (Includes · 65dd58ff
      Owen Taylor authored
      Mon Jan 25 19:41:56 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtknotebook.c (gtk_notebook_page_allocate): Queue
      	a redraw on the tab area when a tab changes size.
      	(Includes improvements from Lars Hamann)
      65dd58ff
    • Owen Taylor's avatar
      Back out the last solution to updating problem. And try a different one · d355451c
      Owen Taylor authored
      Mon Jan 25 19:00:13 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkcolorsel.c (gtk_color_selection_value_events):
      	 Back out the last solution to updating problem. And
      	 try a different one that is less dependent on
      	 the state of the widget. Just redraw the value_marker
      	 when it gets mapped. Somebody needs to analyze
      	 this widget more carefully and figure out
      d355451c
  3. 25 Jan, 1999 3 commits
    • Owen Taylor's avatar
      Removed some GTK_WIDGET_DRAWABLE() tests - we need to update the value · 08f1e809
      Owen Taylor authored
      Mon Jan 25 17:48:03 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkcolorsel.c: Removed some GTK_WIDGET_DRAWABLE()
      	tests - we need to update the value bar's contents
      	even when the widget is unmapped.
      08f1e809
    • Owen Taylor's avatar
      Don't define ENABLE_NLS unless we have a working NLS. (This should keep · 7d5e1b0c
      Owen Taylor authored
      Mon Jan 25 15:47:46 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* acinclude.m4 (ac_result): Don't define ENABLE_NLS
      	 unless we have a working NLS. (This should keep
      	 libintl.h from being included when it doesn't
      	 exist).
      7d5e1b0c
    • Jiri (George) Lebl's avatar
      set RECEIVES_DEFAULT on init, and a button press on the widget doesn't · 4b8095d5
      Jiri (George) Lebl authored
      Mon Jan 25 11:05:10 1999  George Lebl  <jirka@5z.com>
      
              * gtk/gtkbutton.c: set RECEIVES_DEFAULT on init, and a
                button press on the widget doesn't grab default anymore
      
              * gtk/gtkcheckbutton.c,gtk/gtkoptionmenu.c,gtk/gtkradiobutton.c:
                unset RECEIVES_DEFAULT on init
      
              * gtk/gtkwidget.[ch]: add a RECEIVES_DEFAULT flag to widget
                flags
      
              * gtk/gtkwindow.c,gtk/gtkplug.c: on pressing <enter>, activate
                the focused widget if it is a RECEIVES_DEFAULT widget,
                no matter what the current default_widget is
      
              * gtk/gtkwindow.c: on focus change, migrate the HAS_DEFAULT
                flag to CAN_DEFAULT widgets if they RECEIVE_DEFAULT as well
                or migrate it back to the default_widget if the focus widget
                doesn't "RECEIVE_DEFAULT"
      4b8095d5
  4. 24 Jan, 1999 3 commits
    • Owen Taylor's avatar
      Byteswap · 8ac2b1dd
      Owen Taylor authored
      Sun Jan 24 18:09:24 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gdk/gdkdnd.c (motif_read_initiator_info): Byteswap
      8ac2b1dd
    • Owen Taylor's avatar
      Fix reversed assertion. (Pointed out by Austin Donnelly · a1cc053b
      Owen Taylor authored
      Sun Jan 24 12:17:39 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gdk/gdkcolor.c (gdk_colormap_real_destroy): Fix
      	 reversed assertion.
      	 (Pointed out by Austin Donnelly <austin@greenend.org.uk>)
      
      	* gtk/gtkruler.c (gtk_ruler_expose): Remove unecessary
      	 and harmful call to gtk_paint_box(). We are going
      	 to paint onto the backing store later anyways.
      a1cc053b
    • Sergey I. Panov's avatar
      tiny style corrections · 42ffb372
      Sergey I. Panov authored
      42ffb372
  5. 23 Jan, 1999 4 commits
    • Owen Taylor's avatar
      X expects longs, not uint32 for XChangeProperty, when format == 32. · 79fbe482
      Owen Taylor authored
      Sat Jan 23 11:15:39 1999  Owen Taylor  <otaylor@gtk.org>
      
      	* gdk/gdkdnd.c (gdk_window_register_dnd): X expects
      	 longs, not uint32 for XChangeProperty, when
      	 format == 32.
      
      	* gdk/gdkdnd.c (motif_read_initiator_info): Byte-swap
      	 the MotifInitiatorInfo structure if necessary.
      
       	* gdk/gdkdnd.c: When extracting and constructing
               Motif DND messages, don't use data.s[], data.l[]
      	 since on 64bit architectures, these won't necessarily
      	 be in the same place with data.b[].
      
       	* gtk/testdnd.c (target_drag_drop): Return TRUE for
      	 drag_drop within the drop zone.
      
      	* gtk/gtkdnd.c (gtk_drag_dest_handle_event): Only send
      	 a XmTRANSFER_FAILURE if no drop site is found, not
      	 on every drop!
      79fbe482
    • Owen Taylor's avatar
      Add flags field to GtkTargetEntry table. · 6a690c6d
      Owen Taylor authored
      Fri Jan 22 19:22:39 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkeditable.c: Add flags field to
      	 GtkTargetEntry table.
      
      	* gdk/gdkwindow.c (gdk_window_is_viewable): Treat foreign
      	 windows as always viewable, since we can't track their
      	 map-state reliably without speed problems. (Fixes
      	 problem where updating didn't occur properly within
      	 GtkPlug)
      6a690c6d
    • Jeff Garzik's avatar
      Don't search selection list twice. (real_select_row): Remove extra ';', · 0e9b9e32
      Jeff Garzik authored
      Sat Jan 23 13:41:00 1999  Jeff Garzik  <jgarzik@pobox.com>
      
              * gtk/gtkctree.c
              (tree_delete): Don't search selection list twice.
              (real_select_row): Remove extra ';', add default for clarity.
      0e9b9e32
    • Lars Hamann's avatar
      removed extra gtk_spin_button_update calls again. unblock dnd signal · f37d395c
      Lars Hamann authored
      Sat Jan 23 01:44:43 1999  Lars Hamann  <lars@gtk.org>
      
      	* gtk/gtkspinbutton.c (gtk_spin_button_get_value_as_int)
      	(gtk_spin_button_get_value_as_float): removed extra
       	gtk_spin_button_update calls again.
      	* gtk/gtkclist.c (gtk_clist_unmap): unblock dnd signal handler if
      	neccessary
      	* gtk/gtknotebook.c (gtk_notebook_button_press): grab_focus before
      	switch_page
      	(gtk_notebook_set_shape): don't use cur_page if it's NULL.
      f37d395c
  6. 22 Jan, 1999 3 commits
    • Jeff Garzik's avatar
      Fix recent change to match existing coding style. · ad987142
      Jeff Garzik authored
      Fri Jan 22 12:20:54 1999  Jeff Garzik  <jgarzik@pobox.com>
      
              * gtk/gtktooltips.c:
              Fix recent change to match existing coding style.
      ad987142
    • Tim Janik's avatar
      take value_spacing into account for GTK_POS_LEFT. · 060c32e4
      Tim Janik authored
      Fri Jan 22 07:33:44 1999  Tim Janik  <timj@gtk.org>
      
              * gtk/gtkvscale.c (gtk_vscale_pos_trough): take value_spacing into
              account for GTK_POS_LEFT.
      
              * gtk/gtkradiobutton.c (gtk_radio_button_set_group): use
              gtk_toggle_button_set_active () to set the new state.
              (gtk_radio_button_new): only _set_group if group != NULL.
              (gtk_radio_button_clicked): reference the widget.
              (gtk_radio_button_init): make radio buttons active upon
              startup.
      060c32e4
    • Sergey I. Panov's avatar
      A few updates. · cb4bf065
      Sergey I. Panov authored
      cb4bf065
  7. 21 Jan, 1999 14 commits
    • Jeff Garzik's avatar
      Check args for NULL. (gtk_selection_default_handler): Replace manual list · ba58aa20
      Jeff Garzik authored
      Thu Jan 21 17:13:12 1999  Jeff Garzik  <jgarzik@pobox.com>
      
              * gtk/gtkselection.c:
              (gtk_selection_property_notify): Check args for NULL.
              (gtk_selection_default_handler):
              Replace manual list count with call to g_list_length.
              Remove signedness of temp var 'count' to agree with usage.
              Slight spacing adjustment for readability.
      
              * gtk/gtkbox.c, gtk/gtklayout.c, gtk/gtkselection.c:
              Init a few ptrs to NULL, to quiet warnings.
      ba58aa20
    • Manish Singh's avatar
      Shut up cvs · cb2eb293
      Manish Singh authored
      -Yosh
      cb2eb293
    • Owen Taylor's avatar
      [ Tried to commit wrong file last time ] · a0fa647a
      Owen Taylor authored
      Thu Jan 21 16:03:02 1999  Owen Taylor  <otaylor@redhat.com>
      
      
      	* gtk/gtktreeitem.c: Add a paint routine, fix up bugs
      	in drawing where if the expose area was contained
      	completely in the right side of the tree the background
      	wasn't redraw, etc.
      a0fa647a
    • Owen Taylor's avatar
      Code cleanup. · 6878910a
      Owen Taylor authored
      Thu Jan 21 16:03:02 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkbutton.c (gtk_button_expose): Code cleanup.
      
      	* gtk/gtktree.c: Add a paint routine, fix up bugs
      	in drawing where if the expose area was contained
      	completely in the right side of the tree the background
      	wasn't redraw, etc.
      
      	* gtk/gtkwidget.c (gtk_widget_clip_rect): Fix a bug
      	in clipping draw regions while propagating them
      	upwards.
      6878910a
    • Owen Taylor's avatar
      Pushing and popping the visual/cmap in the init() function does no good, · d1d9c5bf
      Owen Taylor authored
      Thu Jan 21 12:20:51 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkcolorsel.c (gtk_color_selection_dialog_new):
      	Pushing	and popping the visual/cmap in the init()
      	function does no good, because the window itself needs
      	to be create with that visual/cmap.
      
      	So do it in the new() function instead.
      
      	This will require people doing gtk_widget_new() to do
      	the push/pop themselves, but I don't see any way around
      	it other than digging in and tweaking the window
      	widget's colormap and visual ourselves, which
      	is highly non-kosher, but would be safe...
      d1d9c5bf
    • Tristan Tarrant's avatar
      Updated Italian texts · a46ac625
      Tristan Tarrant authored
      a46ac625
    • Timur Bakeyev's avatar
      It was reported by Owen Taylor <otaylor@redhat.com>, that LC_ALL produce · 7cef9377
      Timur Bakeyev authored
      
      Thu Jan 21 16:04:35 1999  Timur Bakeyev <mc@bat.ru>
      
      	* gtk/gtkrc.c (gtk_rc_init): It was reported by Owen Taylor
      	<otaylor@redhat.com>, that LC_ALL produce unparsable garbage
      	on some glibc'ed systems and HP/UX. So, falling to LC_CTYPE.
      7cef9377
    • Owen Taylor's avatar
      Set and read the XdndActionList property defined in the Xdnd spec. We do · fea53a95
      Owen Taylor authored
      Thu Jan 21 02:11:44 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* Set and read the XdndActionList property defined
      	in the Xdnd spec. We do this always, not just for
      	XdndActionAsk like the spec says, but if we don't
      	find it, we fall back to actions = suggested_action,
      	which is compatible with the language of the spec.
      fea53a95
    • Jeff Garzik's avatar
      Move not-null assertion before pointer de-ref. · 8dc58cb2
      Jeff Garzik authored
              * gdk/gdkdnd.c (gdk_drag_context_unref):
              Move not-null assertion before pointer de-ref.
      
              * gdk/gdkevents.c (gdk_event_queue_find_first):
              Fix infinite loop bug.  Someone should look at this further to
              make sure the events_pending tests are correct.
      8dc58cb2
    • Owen Taylor's avatar
      Default handling for drops should be keyed on GTK_DRAG_DEFAULT_DROP not · e7b04a53
      Owen Taylor authored
      Thu Jan 21 00:44:47 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkdnd.c (gtk_drag_dest_drop): Default handling
      	for drops should be keyed on GTK_DRAG_DEFAULT_DROP
      	not GTK_DRAG_DEFAULT_MOTION.
      e7b04a53
    • Jeff Garzik's avatar
      Don't search entire row list twice for element being removed. · a646da3f
      Jeff Garzik authored
              * gtk/gtkclist.c (real_remove_row):
              Don't search entire row list twice for element being removed.
      
              * gtk/gtkmenushell.c (gtk_menu_shell_insert):
              Replaced hand-coded implementation of g_list_insert with
              call to g_list_insert.
      
              * gtk/gtktooltips.c
                (gtk_tooltips_destroy_data, gtk_tooltips_layout_text):
              tooltipsdata->row test not-null test now properly encompasses
              both g_list_* calls.
      a646da3f
    • Lars Hamann's avatar
      few cleanups. (gtk_notebook_key_press): call select page function for · 1a58d9b3
      Lars Hamann authored
      Thu Jan 21 02:47:36 1999  Lars Hamann  <lars@gtk.org>
      
      	* gtk/gtknotebook.c (gtk_notebook_focus): few cleanups.
      	(gtk_notebook_key_press): call select page function for
      	GDK_DOWN key in case of tab_pos == TOP. Changed other
      	positions accordingly.
      1a58d9b3
    • Owen Taylor's avatar
      Start off with the cursor for "no drop" since if we'll get a status if we · 21993dcb
      Owen Taylor authored
      Wed Jan 20 19:57:14 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtkdnd.c (gtk_drag_begin): Start off with the
      	cursor for "no drop" since if we'll get a status
      	if we are over a drag window, but none if we aren't
      	over one.
      21993dcb
    • Jeff Garzik's avatar
      . Free 'nprefix', closing a memory leak. Spaced out the code a bit to make · 6e3e247b
      Jeff Garzik authored
      .
              * gtk/gtkcombo.c (gtk_combo_entry_key_press):
              Free 'nprefix', closing a memory leak.
              Spaced out the code a bit to make it more readable.
      
              * gtk/gtkhbox.[ch] (gtk_hbox_new),
                gtk/gtkvbox.[ch] (gtk_vbox_new):
              Change 'homogenous' arg from gint to gboolean.
      
              * gtk/gtktogglebutton.[ch]:
              New function gtk_toggle_button_get_active().
      6e3e247b
  8. 20 Jan, 1999 5 commits
    • Federico Mena Quintero's avatar
      Allow button 2 to act as GDK_ACTION_ASK. Also, allow MOD1 to specify · df21a706
      Federico Mena Quintero authored
      1999-01-20  Federico Mena Quintero  <federico@nuclecu.unam.mx>
      
      	* gtk/gtkdnd.c (gtk_drag_get_event_action): Allow button 2 to act
      	as GDK_ACTION_ASK.  Also, allow MOD1 to specify GDK_ACTION_ASK
      	only if that action is enabled in the actions argument.
      df21a706
    • Raja R Harinath's avatar
      New variable. Define to $prefix/$DATADIRNAME/locale. This will point to · 255005f0
      Raja R Harinath authored
      	* configure.in (gtklocaledir): New variable.  Define to
      	$prefix/$DATADIRNAME/locale.  This will point to the directory
      	where po/Makefile actually installs the message translation
      	tables.
      	* gtk/Makefile.am (INCLUDES): Define GTK_LOCALEDIR to
      	$(gtklocaledir) rather than $prefix/share/locale.
      255005f0
    • Timur I. Bakeyev's avatar
      Under some systems (notably, BSDI), there is no LC_MESSAGES category in · 5ce6bea6
      Timur I. Bakeyev authored
      
      Under some systems (notably, BSDI), there is no LC_MESSAGES category in
      locale.h. In this case it is good guess to relay on the value of LC_ALL
      (in fact, LC_CTYPE will be more precise).
      5ce6bea6
    • Owen Taylor's avatar
      Instead of drawing a background pixmap in with gdk_draw_pixmap(), set it · 6205bbbf
      Owen Taylor authored
      Wed Jan 20 13:06:51 1999  Owen Taylor  <otaylor@redhat.com>
      
      	* gtk/gtktext.[ch] (clear_[focus_]area): Instead of drawing
      	a background pixmap in with gdk_draw_pixmap(), set
      	it as a tile pixmap for a GC. This should speed
      	up things considerably and also will hide a bug
      	where text->first_onscreen_ver_pixel is being
      	corrupted, causing the bg pixmap drawing code to generate
      	graphics exposes.
      6205bbbf
    • Lars Hamann's avatar
      only call grab_add if pointer_grab succeeds. (gtk_list_unmap): remove · 0543c806
      Lars Hamann authored
      Tue Jan 19 22:15:10 1999  Lars Hamann  <lars@gtk.org>
      
      	* gtk/gtklist.c
      	(gtk_list_button_press):  only call grab_add if pointer_grab succeeds.
      	(gtk_list_unmap): remove pointer/widget grabs if needed.
      	(gtk_list_signal_focus_lost): removed.
      	(gtk_list_focus) (gtk_list_set_focus_child): set last_focus_child.
      	(gtk_list_remove_items_internal) (gtk_list_clear_items): unset
       	undo_focus_child if necessary. In case of SELECTION_BROWSE/EXTENDED
       	select a new item if selection is empty.
      0543c806
  9. 18 Jan, 1999 2 commits