1. 13 Mar, 2004 12 commits
    • Owen Taylor's avatar
      When not wrapping, do the offset of the line for justification ourselves. · 83eb184c
      Owen Taylor authored
      Sat Mar 13 18:13:13 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktextlayout.c (gtk_text_layout_get_line_display): When not
              wrapping, do the offset of the line for justification ourselves.
              (#120256, Felipe Heidrich)
      83eb184c
    • Matthias Clasen's avatar
      Support the model-less use of GtkCellView shown in testcombo.c. · a6361456
      Matthias Clasen authored
      Sun Mar 14 00:03:18 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcellview.c (gtk_cell_view_expose): Support the
      	model-less use of GtkCellView shown in testcombo.c.
      a6361456
    • Tor Lillqvist's avatar
      Don't undefine HAVE_MONITOR_INFO when compiling with gcc. Mingw's headers · f6d1307a
      Tor Lillqvist authored
      2004-03-13  Tor Lillqvist  <tml@iki.fi>
      
      	* gdk/win32/gdkdisplay-win32.c: Don't undefine HAVE_MONITOR_INFO
      	when compiling with gcc. Mingw's headers do have the required
      	definitions.
      
      	* gdk/win32/gdkdrawable-win32.c (draw_polygon): When drawing
      	filled polygons, don't draw the outline, similarily as
      	draw_rectangle(). Apparently GTK and GIMP don't use
      	gdk_draw_polygon() much (or always draw the outline, too), as this
      	has gone undetected for so long. Thanks to Bruce Hochstetler.
      f6d1307a
    • Owen Taylor's avatar
      Remove the window from the toplevel_list here rather in destroy. While · 38bb62c4
      Owen Taylor authored
      Sat Mar 13 15:19:17 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkwindow.c (gtk_window_destroy): Remove
              the window from the toplevel_list here rather in destroy.
              While this is theoretically speaking wrong, it fits
              in better with the current reality that destroyed
              widgets are not reusable. (#126808, Michael Natterer)
      38bb62c4
    • Matthias Clasen's avatar
      Don't do anything beyond clearing to the background if there is no active · b1b58fe3
      Matthias Clasen authored
      Sat Mar 13 21:47:47 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcellview.c (gtk_cell_view_expose): Don't do anything
      	beyond clearing to the background if there is no active row.
      	(#137066, reported by Owen Taylor)
      b1b58fe3
    • Matthias Clasen's avatar
      Pop down the list when an item is selected via the keyboard. · 74fd8a02
      Matthias Clasen authored
      Sat Mar 13 21:37:44 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_key_press): Pop down the
      	list when an item is selected via the keyboard.
      74fd8a02
    • Anders Carlsson's avatar
      Remove trailing slashes in path names. · 72804ba4
      Anders Carlsson authored
      2004-03-13  Anders Carlsson  <andersca@gnome.org>
      
      	* gtk/gtkfilesystemunix.c: (remove_trailing_slash),
      	(gtk_file_system_unix_get_folder),
      	(gtk_file_system_unix_create_folder), (get_parent_dir),
      	(gtk_file_system_unix_get_parent), (gtk_file_folder_unix_get_info):
      	Remove trailing slashes in path names.
      72804ba4
    • Owen Taylor's avatar
      Make this a total no-op when the new or old parent is destroyed. (#134230, · ef5915da
      Owen Taylor authored
      Sat Mar 13 12:17:16 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Make
              this a total no-op when the new or old parent is
              destroyed. (#134230, patch from Soeren Sandmann)
      
              * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy):
              For foreign windows in our heirarchy, call
              _gdk_windowing_window_destroy_foreign (window) and skip
              all the normal destruction logic.
      
              * gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c:
              Move code to request destruction of a foreign window
              code into a separate _gdk_windowing_window_destroy_foreign().
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_impl_x11_finalize):
              Call GDK_WINDOW_DISPLAY() on the wrapper not on the
              impl. (Also from Soeren's patch)
      ef5915da
    • Owen Taylor's avatar
      For GTK_IS_PLUG toplevels, call gdk_window_get_origin() not · fadaa651
      Owen Taylor authored
      Sat Mar 13 10:49:46 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkdnd.c (_gtk_drag_dest_handle_event): For
              GTK_IS_PLUG toplevels, call gdk_window_get_origin()
              not gtk_window_get_position, as a hackround for not
              having accurate notification of window position for
              embedded windows. (#136112, Dan Winship)
      fadaa651
    • Owen Taylor's avatar
      Revert last change; it causes problems for pastes from other applications; · fe3558c7
      Owen Taylor authored
      Sat Mar 13 10:34:03 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktextview.c gtk/gtktextbuffer.c: Revert last change;
              it causes problems for pastes from other applications; see
              comments in bugzilla for #81880.
      fe3558c7
    • Matthias Clasen's avatar
      Fix middle button pasting in the TextView (#81880, reported by Evert · fff38851
      Matthias Clasen authored
      Sat Mar 13 02:55:51 2004  Matthias Clasen  <maclas@gmx.de>
      
      	Fix middle button pasting in the TextView  (#81880, reported
      	by Evert Verhellen, patch by Paolo Borelli):
      
      	* gtk/gtktextview.c (gtk_text_view_button_press_event): Retrieve
      	the insert mark and move the cursor to it making sure of also
      	scroll the window if needed.
      
      	* gtk/gtktextbuffer.c (pre_paste_prep): Move the insert mark
      	to the insertion point.
      fff38851
    • Matthias Clasen's avatar
      Add a remove implemenatation which restores the cell_view when the custom · 3186b9e7
      Matthias Clasen authored
      Sat Mar 13 01:38:55 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_remove): Add a remove
      	implemenatation which restores the cell_view when the custom
      	child is removed.  (#136555, Owen Taylor)
      3186b9e7
  2. 12 Mar, 2004 8 commits
    • Matthias Clasen's avatar
      Keep the cell_list in a consistent state while iterating over it, since · 60780dc6
      Matthias Clasen authored
      Sat Mar 13 00:07:51 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear):
      	Keep the cell_list in a consistent state while iterating over it,
      	since clear_attributes() also iterates over it.  (another instance
      	of #136585, Morten Welinder)
      60780dc6
    • Owen Taylor's avatar
      Swap GTK_ARROW_LEFT and GTK_ARROW_RIGHT for GTK_TEXT_DIR_LTR. (#129159, · dcb6900c
      Owen Taylor authored
      Fri Mar 12 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkarrow.c (gtk_arrow_expose): Swap GTK_ARROW_LEFT
              and GTK_ARROW_RIGHT for GTK_TEXT_DIR_LTR. (#129159,
              Semion Chichelnitsky)
      
              * gtk/gtkpathbar.c gtk/gtktoolbar.c: Remove no-longer-needed
              gtk_toolbar_direction-changed handlers and explicit
              flipping of GtkArrow widgets.
      dcb6900c
    • Soeren Sandmann's avatar
      Clamp the new size to the screen. Part of bug 129020. · 543b1c2f
      Soeren Sandmann authored
      Fri Mar 12 23:37:15 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	* gtk/gtkfilechooserdialog.c
      	(file_chooser_widget_default_realized_size_changed): Clamp the
      	new size to the screen. Part of bug 129020.
      543b1c2f
    • Owen Taylor's avatar
      Create the event_window at the right size using the same logic as in · 1c188e7c
      Owen Taylor authored
      Fri Mar 12 15:06:44 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkexpander.c (gtk_expander_realize): Create the
              event_window at the right size using the same logic as
              in size_allocate. (#136994, Niklas Knuttson)
      1c188e7c
    • Federico Mena Quintero's avatar
      Don't ignore the return value of gtk_widget_activate(). · edf8e6f5
      Federico Mena Quintero authored
      2004-03-12  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkwindow.c (gtk_window_activate_focus): Don't ignore the
      	return value of gtk_widget_activate().
      	(gtk_window_activate_default): Likewise.  Fixes #137008.
      
      	* gtk/gtkfilechooserdialog.c (response_cb): Act on positive
      	response IDs we recognize, rather than bailing out on cancellation
      	ones.  Fixes #136237; patch by Olivier Andrieu
      	<oliv__a@users.sourceforge.net>.
      	(file_chooser_widget_file_activated): If the dialog doesn't have a
      	default widget, try to find a suitable response widget on our own.
      	People should *really* be using gtk_dialog_set_default_response(),
      	but this is to help lazy programmers.
      
      	* gtk/gtkdialog.c (_gtk_dialog_get_response_for_widget): New
      	internal function.
      	(get_response_data): Add a "create" argument so that we don't
      	unconditionally create the response data.
      edf8e6f5
    • Morten Welinder's avatar
      Add new testspinbutton.c · ed649f3b
      Morten Welinder authored
      2004-03-12  Morten Welinder  <terra@gnome.org>
      
      	* tests/Makefile.am: Add new testspinbutton.c
      ed649f3b
    • Federico Mena Quintero's avatar
      Put the trash icon on the right for LTR locales, or on the left for RTL. · 2de43410
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drag_set_delete_cursor):
      	Put the trash icon on the right for LTR locales, or on the left
      	for RTL.
      	(shortcuts_drag_motion_cb): Cancel the idle handler here as well.
      	(shortcuts_drag_leave_cb): Test whether the idle is present.
      	(shortcuts_drag_data_received_cb): Ahem, don't assert here.
      2de43410
    • Federico Mena Quintero's avatar
      Put the trash icon on the right for LTR locales, or on the left for RTL. · b4a6705a
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drag_set_delete_cursor):
      	Put the trash icon on the right for LTR locales, or on the left
      	for RTL.
      	(shortcuts_drag_motion_cb): Cancel the idle handler here as well.
      	(shortcuts_drag_leave_cb): Test whether the idle is present.
      b4a6705a
  3. 11 Mar, 2004 18 commits
    • Owen Taylor's avatar
      Clear preedit string and emit preedit_changed as needed on AIX. (#130617, · 99c074e7
      Owen Taylor authored
      Thu Mar 11 17:51:10 2004  Owen Taylor  <otaylor@redhat.com>
      
              * modules/input/gtkimcontextxim.c (preedit_done_callback):
              Clear preedit string and emit preedit_changed as needed
              on AIX. (#130617, Philip K Warren)
      99c074e7
    • Morten Welinder's avatar
      Plug leak. · 83384bd0
      Morten Welinder authored
      2004-03-11  Morten Welinder  <terra@gnome.org>
      
      	* gtk/gtkpathbar.c (_gtk_path_bar_set_file_system): Plug leak.
      83384bd0
    • Owen Taylor's avatar
      Fix attach/attach->parent type. (#136919, Tim Mooney) · 5c2b9546
      Owen Taylor authored
      Thu Mar 11 16:28:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmenu.c (gtk_menu_get_toplevel): Fix attach/attach->parent
              type. (#136919, Tim Mooney)
      5c2b9546
    • Jonathan Blandford's avatar
      revert earlier change to insert_path so that we test that the directory · 865d3dd2
      Jonathan Blandford authored
      Thu Mar 11 16:18:51 2004  Jonathan Blandford  <jrb@redhat.com>
      
              * gtk/gtkfilechooserdefault.c (shortcuts_insert_path): revert
              earlier change to insert_path so that we test that the directory
              exists.
      
              * gtk/gtkfilechooserdialog.c
              (gtk_file_chooser_dialog_constructor): move focus.
      865d3dd2
    • Matthias Clasen's avatar
      Use the same logic as GtkEntry when calculating border width. (#116368, · c2028081
      Matthias Clasen authored
      Thu Mar 11 22:12:14 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkspinbutton.c (gtk_spin_button_size_request): Use the same
      	logic as GtkEntry when calculating border width.  (#116368, reported
      	by Morten Welinder)
      c2028081
    • Owen Taylor's avatar
      Use gtk_entry_set_width_chars() rather than gtk_widget_set_size_request(). · 3e696271
      Owen Taylor authored
      Thu Mar 11 15:59:05 2004  Owen Taylor  <otaylor@redhat.com>
      
              * tests/testgtk.c (create_spins): Use gtk_entry_set_width_chars()
              rather than gtk_widget_set_size_request().
      3e696271
    • Federico Mena Quintero's avatar
      New function, copied from gtkpathbar.c. · df0510a8
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (remove_settings_signal): New
      	function, copied from gtkpathbar.c.
      	(gtk_file_chooser_default_dispose): Use remove_settings_signal()
      	rather than our own code.
      	(gtk_file_chooser_default_screen_changed): Use
      	remove_settings_signal(); this should handle per-screen settings
      	correctly.
      df0510a8
    • Owen Taylor's avatar
      Fix a missing return value. · 796d15ef
      Owen Taylor authored
      Thu Mar 11 14:07:18 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtklabel.c (gtk_label_focus): Fix a missing return
              value.
      796d15ef
    • Owen Taylor's avatar
      Back out the put-labels-into-the-standard-focus-chain patches from bug · b5ddc23b
      Owen Taylor authored
      Thu Mar 11 13:58:24 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkmessagedialog.c gtk/gtklabel.c: Back out the
              put-labels-into-the-standard-focus-chain patches
              from bug #59707.
      
              * gtk/gtklabel.c (gtk_label_focus): Only put the
              label in the tab chain when the control key is pressed.
      b5ddc23b
    • Federico Mena Quintero's avatar
      Use a single OK button, not a Close button, as per the HIG. · b35220fd
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (error_message_with_parent): Use a
      	single OK button, not a Close button, as per the HIG.
      
      	* gtk/gtkfilesel.c (gtk_file_selection_fileop_error): Likewise.
      b35220fd
    • Federico Mena Quintero's avatar
      Oops, initialize "action" before jumping. Fixes #136900. · 4cfd0030
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drag_motion_cb): Oops,
      	initialize "action" before jumping.  Fixes #136900.
      4cfd0030
    • Mark McLoughlin's avatar
      don't overwrite application properties. Fixes bug #136802. · a4ab0dd4
      Mark McLoughlin authored
      2004-03-11  Mark McLoughlin  <mark@skynet.ie>
      
              * gtk/gtksettings.c: (apply_queued_setting): don't overwrite
              application properties. Fixes bug #136802.
      a4ab0dd4
    • Dov Grobgeld's avatar
      Added call to gtk_text_layout_update_cursor_line() to solve in problem of · a1707142
      Dov Grobgeld authored
      2004-03-11  Dov Grobgeld  <dov@imagic.weizmann.ac.il>
      
              * gtk/gtktextlayer.c: (gtk_text_layout_set_buffer): Added
              call to gtk_text_layout_update_cursor_line() to solve in
              problem of switching keyboard direction at widget creation:
              bug #136680
      a1707142
    • Owen Taylor's avatar
      Remove stray 'return' statement. (#136855, David L. Cooper II) · cce69876
      Owen Taylor authored
      Thu Mar 11 10:28:30 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkfilechooserembed.c (delegate_initial_focus): Remove
              stray 'return' statement. (#136855, David L. Cooper II)
      cce69876
    • Mark McLoughlin's avatar
      Use the PRELIGHT fg color for drawing the expander when prelit. Fixes · a794a492
      Mark McLoughlin authored
      2004-03-11  Mark McLoughlin  <mark@skynet.ie>
      
              * gtk/gtkstyle.c: (gtk_default_draw_expander): Use the PRELIGHT
              fg color for drawing the expander when prelit. Fixes problem
              with the HighContrast theme: bug #136789.
      a794a492
    • Federico Mena Quintero's avatar
      Fix #135912 and #135913. · 1135bef0
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	Fix #135912 and #135913.
      
      	* gtk/gtkfilechooserdefault.c
      	(shortcuts_filter_model_row_draggable): Implement.
      	(shortcuts_model_filter_new): New function, create a
      	ShortcutsModelFilterClass derived from GtkTreeModelFilter, so that
      	we can implement our own DnD interface methods.
      	(shortcuts_model_create): Use shortcuts_model_filter_new().
      	(shortcuts_list_create): Enable the shortcuts list as a drag
      	source.
      	(file_list_source_targets): Renamed from shortcuts_targets.
      	(shortcuts_list_create): Change the options for
      	gtk_drag_dest_set().  Connect to more drag signals so that we can
      	implement drops by hand.
      	(shortcuts_drag_data_delete_cb): New handler; just stop the emission.
      	(shortcuts_drag_motion_cb): New handler; validate the drop.
      	(shortcuts_drag_leave_cb): New handler; unset the drag_dest_row.
      	(shortcuts_drag_drop_cb): New handler; just stop the emission and
      	remove the idle handler for the drag cursor.
      	(shortcuts_add_bookmark_from_path): Add a position argument,
      	return a boolean success code.
      	(shortcuts_drag_data_received_cb): Handle two cases:  1) Insert
      	the bookmarks at the proper position, rather than always appending
      	them to the list; 2) alternatively, reorder the bookmarks.
      	(struct _GtkFileChooserDefault): New field shortcuts_drag_outside.
      	(shortcuts_drag_motion_cb): Turn off impl->shortcuts_drag_outside.
      	(shortcuts_drag_leave_cb): Turn on impl->shortcuts_drag_outside in
      	an idle handler.
      	(shortcuts_drag_end_cb): New handler; remove the selected bookmark.
      1135bef0
    • Jonathan Blandford's avatar
      up the width of the entry a tad. · 976647fd
      Jonathan Blandford authored
      Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>
      
              * gtk/gtkfilechooserdefault.c (location_entry_create): up the
              width of the entry a tad.
      
              * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
              gtk_entry_completion_selection_changed.  Also, unref the
              completion as we were leaking a reference to it.
      976647fd
    • Federico Mena Quintero's avatar
      Remove spurious semicolon. Thanks to Kjartan Maraas for pointing it out. · 74f34716
      Federico Mena Quintero authored
      2004-03-10  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to
      	Kjartan Maraas for pointing it out.
      74f34716
  4. 10 Mar, 2004 2 commits
    • Matthias Clasen's avatar
      Set the background on the action view cell renderer here, not in init, so · d9697445
      Matthias Clasen authored
      Wed Mar 10 23:40:15 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkentrycompletion.c (_gtk_entry_completion_popup): Set the background
      	on the action view cell renderer here, not in init, so that a) we catch
      	style changes, and b) we get the real style, not the default one.
      	Partial fix for #127648, reported by Dave Bordoley.
      d9697445
    • Tor Lillqvist's avatar
      Set also the pointer button bits. (#136636, Dave Neary) · 6e5d9597
      Tor Lillqvist authored
      2004-03-10  Tor Lillqvist  <tml@iki.fi>
      
      	* gdk/win32/gdkevents-win32.c (build_key_event_state): Set also
      	the pointer button bits. (#136636, Dave Neary)
      
      	* gdk/win32/gdkwindow-win32.c (show_window_internal): Show
      	transparent (input only) windows using SetWindowPos(). (#132331,
      	John Ehresman)
      
      	(gdk_window_set_type_hint): For splash screens, remove the resize
      	handles, menu, and minimize/maximize/close buttons. (#132896)
      6e5d9597