1. 15 Mar, 2004 8 commits
    • Owen Taylor's avatar
      Implement local_only by filtering the shortcuts and bookmarks list by · 2c9d190c
      Owen Taylor authored
      Sun Mar 14 23:36:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkfilechooserdefault.c: Implement local_only by
              filtering the shortcuts and bookmarks list by
              gtk_file_system_path_to_filename (file_system, path) != NULL.
              (#132894)
      
              * gtk/gtkfilesystem.c (gtk_file_system_path_is_local): Add
              a convenience function, may by interesting to push to the
              file system vtable later for performance.
      2c9d190c
    • Federico Mena Quintero's avatar
      Allow the path to be NULL, so that people can ask for information about a · 084bb2fe
      Federico Mena Quintero authored
      2004-03-14  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilesystem.c (gtk_file_folder_get_info): Allow the path
      	to be NULL, so that people can ask for information about a
      	parent-less file system root (e.g. get_info (get_folder ("/"), NULL)).
      
      	* gtk/gtkfilesystemunix.c (gtk_file_folder_unix_get_info): Allow
      	the condition describe above.
      
      	* gtk/gtkfilechooserdefault.c (get_file_info): Allow getting
      	information of root paths.
      
      	* gtk/gtkpathbar.c (_gtk_path_bar_set_path): Handle root paths correctly.
      084bb2fe
    • Owen Taylor's avatar
      Mention GtkTreeViewSearchEqualFunc return value oddity here as well. · 6bc9b7f5
      Owen Taylor authored
      Sun Mar 14 22:32:36 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktreeview.c (gtk_tree_view_set_search_equal_func): Mention
              GtkTreeViewSearchEqualFunc return value oddity here as well.
      
              * gtk/gtktreeview.c (gtk_tree_view_search_equal_func): On failure
              to get a string to compare to, return TRUE (no match), not
              FALSE (match). Handle %NULL string values gracefully.
              Remove unused variable. (#135962, Mark McLoughlin)
      6bc9b7f5
    • Morten Welinder's avatar
      Kill g_prints. · 538ca81c
      Morten Welinder authored
      538ca81c
    • Owen Taylor's avatar
      Add _gtk_path_bar_up()/ _gtk_path_bar_down(). · f8b3e6fe
      Owen Taylor authored
      Sun Mar 14 21:03:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkpathbar.[ch]: Add _gtk_path_bar_up()/
              _gtk_path_bar_down().
      
              * gtk/gtkfilechooserdefault.c: Use _gtk_path_bar_up()/
              _gtk_path_bar_down() as bindings for Alt-Up
              and new Alt-Down. (Partly based on a patch by
              Mark McLoughlin, #136987)
      f8b3e6fe
    • Federico Mena Quintero's avatar
      Fixes #136185, patch by Morten Welinder, with some changes. · dfa36bb4
      Federico Mena Quintero authored
      2004-03-14  Federico Mena Quintero  <federico@ximian.com>
      
      	Fixes #136185, patch by Morten Welinder, with some changes.
      
      	* gtk/gtkfilechooserdefault.c (check_is_folder): New helper function.
      	(shortcuts_insert_path): Check the path first with check_is_folder().
      	(gtk_file_chooser_default_set_current_folder): Likewise.
      	(gtk_file_chooser_default_add_shortcut_folder): Likewise.
      	(browse_widgets_create): Unref the size group.
      
      	* gtk/gtkfilesystemunix.c (gtk_file_system_unix_get_folder):
      	Handle the case where the file exists but it is not a directory.
      	(IconType): Add value for ICON_UNDECIDED.
      	(struct stat_info_entry): New structure to hold a file's struct
      	stat, its MIME type and its icon type.
      	(struct _GtkFileFolderUnix): Added a hash of struct
      	stat_info_entry, and flags to remember which info types we've read
      	so far.
      	(get_icon_type): Use a helper function for the icons-from-stat
      	types.
      	(gtk_file_system_unix_render_icon): Use the cached file info.
      	(gtk_file_folder_unix_get_info): Put the info in the cache.
      	(gtk_file_system_unix_get_folder): Create the cache of file info
      	structures.
      
      	* gtk/gtkfilesystem.c (gtk_file_info_set_display_name): Handle the
      	case where display_name is the same as the existing
      	info->display_name.
      dfa36bb4
    • Owen Taylor's avatar
      #136672, reported by Christian Persch; fixes based on a patch by Soeren · 3895bea4
      Owen Taylor authored
      Sun Mar 14 19:26:48 2004  Owen Taylor  <otaylor@redhat.com>
      
              #136672, reported by Christian Persch; fixes based
              on a patch by Soeren Sandmann.
      
              * gtk/gtkmenu.c: Change the handling of mixed gridded
              and non-gridded menu items; the old method was causing
              major performance problems even with the "avoid relayout
              on destruction" hack put in recently.
      
              Now we first lay out the gridded items and then put the
              non-gridded items into empty rows / after the gridded items.
              Layout is done in a central menu_shell_ensure_layout(). Also
              avoid emitting property notifications when we initially
              insert or attach items.
      
              * gtk/gtkmenushell.[ch] gtk/gtkmenu.c: Stop setting the
              unused menu_shell->menu_flag, and document it as unused
              in the header.
      
              * tests/testactions.c: Add a test of creating/removing
              lots of items.
      
              * test/testgtk.c: Add some more cruft to the menu test.
      3895bea4
    • Matthias Clasen's avatar
      Add some docs. · f2e252a2
      Matthias Clasen authored
      f2e252a2
  2. 14 Mar, 2004 5 commits
  3. 13 Mar, 2004 12 commits
    • Owen Taylor's avatar
      When not wrapping, do the offset of the line for justification ourselves. · 83eb184c
      Owen Taylor authored
      Sat Mar 13 18:13:13 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktextlayout.c (gtk_text_layout_get_line_display): When not
              wrapping, do the offset of the line for justification ourselves.
              (#120256, Felipe Heidrich)
      83eb184c
    • Matthias Clasen's avatar
      Support the model-less use of GtkCellView shown in testcombo.c. · a6361456
      Matthias Clasen authored
      Sun Mar 14 00:03:18 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcellview.c (gtk_cell_view_expose): Support the
      	model-less use of GtkCellView shown in testcombo.c.
      a6361456
    • Tor Lillqvist's avatar
      Don't undefine HAVE_MONITOR_INFO when compiling with gcc. Mingw's headers · f6d1307a
      Tor Lillqvist authored
      2004-03-13  Tor Lillqvist  <tml@iki.fi>
      
      	* gdk/win32/gdkdisplay-win32.c: Don't undefine HAVE_MONITOR_INFO
      	when compiling with gcc. Mingw's headers do have the required
      	definitions.
      
      	* gdk/win32/gdkdrawable-win32.c (draw_polygon): When drawing
      	filled polygons, don't draw the outline, similarily as
      	draw_rectangle(). Apparently GTK and GIMP don't use
      	gdk_draw_polygon() much (or always draw the outline, too), as this
      	has gone undetected for so long. Thanks to Bruce Hochstetler.
      f6d1307a
    • Owen Taylor's avatar
      Remove the window from the toplevel_list here rather in destroy. While · 38bb62c4
      Owen Taylor authored
      Sat Mar 13 15:19:17 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkwindow.c (gtk_window_destroy): Remove
              the window from the toplevel_list here rather in destroy.
              While this is theoretically speaking wrong, it fits
              in better with the current reality that destroyed
              widgets are not reusable. (#126808, Michael Natterer)
      38bb62c4
    • Matthias Clasen's avatar
      Don't do anything beyond clearing to the background if there is no active · b1b58fe3
      Matthias Clasen authored
      Sat Mar 13 21:47:47 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcellview.c (gtk_cell_view_expose): Don't do anything
      	beyond clearing to the background if there is no active row.
      	(#137066, reported by Owen Taylor)
      b1b58fe3
    • Matthias Clasen's avatar
      Pop down the list when an item is selected via the keyboard. · 74fd8a02
      Matthias Clasen authored
      Sat Mar 13 21:37:44 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_list_key_press): Pop down the
      	list when an item is selected via the keyboard.
      74fd8a02
    • Anders Carlsson's avatar
      Remove trailing slashes in path names. · 72804ba4
      Anders Carlsson authored
      2004-03-13  Anders Carlsson  <andersca@gnome.org>
      
      	* gtk/gtkfilesystemunix.c: (remove_trailing_slash),
      	(gtk_file_system_unix_get_folder),
      	(gtk_file_system_unix_create_folder), (get_parent_dir),
      	(gtk_file_system_unix_get_parent), (gtk_file_folder_unix_get_info):
      	Remove trailing slashes in path names.
      72804ba4
    • Owen Taylor's avatar
      Make this a total no-op when the new or old parent is destroyed. (#134230, · ef5915da
      Owen Taylor authored
      Sat Mar 13 12:17:16 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_reparent): Make
              this a total no-op when the new or old parent is
              destroyed. (#134230, patch from Soeren Sandmann)
      
              * gdk/gdkwindow.c (_gdk_window_destroy_hierarchy):
              For foreign windows in our heirarchy, call
              _gdk_windowing_window_destroy_foreign (window) and skip
              all the normal destruction logic.
      
              * gdk/x11/gdkwindow-x11.c gdk/win32/gdkwindow-win32.c:
              Move code to request destruction of a foreign window
              code into a separate _gdk_windowing_window_destroy_foreign().
      
              * gdk/x11/gdkwindow-x11.c (gdk_window_impl_x11_finalize):
              Call GDK_WINDOW_DISPLAY() on the wrapper not on the
              impl. (Also from Soeren's patch)
      ef5915da
    • Owen Taylor's avatar
      For GTK_IS_PLUG toplevels, call gdk_window_get_origin() not · fadaa651
      Owen Taylor authored
      Sat Mar 13 10:49:46 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkdnd.c (_gtk_drag_dest_handle_event): For
              GTK_IS_PLUG toplevels, call gdk_window_get_origin()
              not gtk_window_get_position, as a hackround for not
              having accurate notification of window position for
              embedded windows. (#136112, Dan Winship)
      fadaa651
    • Owen Taylor's avatar
      Revert last change; it causes problems for pastes from other applications; · fe3558c7
      Owen Taylor authored
      Sat Mar 13 10:34:03 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtktextview.c gtk/gtktextbuffer.c: Revert last change;
              it causes problems for pastes from other applications; see
              comments in bugzilla for #81880.
      fe3558c7
    • Matthias Clasen's avatar
      Fix middle button pasting in the TextView (#81880, reported by Evert · fff38851
      Matthias Clasen authored
      Sat Mar 13 02:55:51 2004  Matthias Clasen  <maclas@gmx.de>
      
      	Fix middle button pasting in the TextView  (#81880, reported
      	by Evert Verhellen, patch by Paolo Borelli):
      
      	* gtk/gtktextview.c (gtk_text_view_button_press_event): Retrieve
      	the insert mark and move the cursor to it making sure of also
      	scroll the window if needed.
      
      	* gtk/gtktextbuffer.c (pre_paste_prep): Move the insert mark
      	to the insertion point.
      fff38851
    • Matthias Clasen's avatar
      Add a remove implemenatation which restores the cell_view when the custom · 3186b9e7
      Matthias Clasen authored
      Sat Mar 13 01:38:55 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtkcombobox.c (gtk_combo_box_remove): Add a remove
      	implemenatation which restores the cell_view when the custom
      	child is removed.  (#136555, Owen Taylor)
      3186b9e7
  4. 12 Mar, 2004 8 commits
    • Matthias Clasen's avatar
      Keep the cell_list in a consistent state while iterating over it, since · 60780dc6
      Matthias Clasen authored
      Sat Mar 13 00:07:51 2004  Matthias Clasen  <maclas@gmx.de>
      
      	* gtk/gtktreeviewcolumn.c (gtk_tree_view_column_cell_layout_clear):
      	Keep the cell_list in a consistent state while iterating over it,
      	since clear_attributes() also iterates over it.  (another instance
      	of #136585, Morten Welinder)
      60780dc6
    • Owen Taylor's avatar
      Swap GTK_ARROW_LEFT and GTK_ARROW_RIGHT for GTK_TEXT_DIR_LTR. (#129159, · dcb6900c
      Owen Taylor authored
      Fri Mar 12 17:20:15 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkarrow.c (gtk_arrow_expose): Swap GTK_ARROW_LEFT
              and GTK_ARROW_RIGHT for GTK_TEXT_DIR_LTR. (#129159,
              Semion Chichelnitsky)
      
              * gtk/gtkpathbar.c gtk/gtktoolbar.c: Remove no-longer-needed
              gtk_toolbar_direction-changed handlers and explicit
              flipping of GtkArrow widgets.
      dcb6900c
    • Soeren Sandmann's avatar
      Clamp the new size to the screen. Part of bug 129020. · 543b1c2f
      Soeren Sandmann authored
      Fri Mar 12 23:37:15 2004  Soeren Sandmann  <sandmann@daimi.au.dk>
      
      	* gtk/gtkfilechooserdialog.c
      	(file_chooser_widget_default_realized_size_changed): Clamp the
      	new size to the screen. Part of bug 129020.
      543b1c2f
    • Owen Taylor's avatar
      Create the event_window at the right size using the same logic as in · 1c188e7c
      Owen Taylor authored
      Fri Mar 12 15:06:44 2004  Owen Taylor  <otaylor@redhat.com>
      
              * gtk/gtkexpander.c (gtk_expander_realize): Create the
              event_window at the right size using the same logic as
              in size_allocate. (#136994, Niklas Knuttson)
      1c188e7c
    • Federico Mena Quintero's avatar
      Don't ignore the return value of gtk_widget_activate(). · edf8e6f5
      Federico Mena Quintero authored
      2004-03-12  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkwindow.c (gtk_window_activate_focus): Don't ignore the
      	return value of gtk_widget_activate().
      	(gtk_window_activate_default): Likewise.  Fixes #137008.
      
      	* gtk/gtkfilechooserdialog.c (response_cb): Act on positive
      	response IDs we recognize, rather than bailing out on cancellation
      	ones.  Fixes #136237; patch by Olivier Andrieu
      	<oliv__a@users.sourceforge.net>.
      	(file_chooser_widget_file_activated): If the dialog doesn't have a
      	default widget, try to find a suitable response widget on our own.
      	People should *really* be using gtk_dialog_set_default_response(),
      	but this is to help lazy programmers.
      
      	* gtk/gtkdialog.c (_gtk_dialog_get_response_for_widget): New
      	internal function.
      	(get_response_data): Add a "create" argument so that we don't
      	unconditionally create the response data.
      edf8e6f5
    • Morten Welinder's avatar
      Add new testspinbutton.c · ed649f3b
      Morten Welinder authored
      2004-03-12  Morten Welinder  <terra@gnome.org>
      
      	* tests/Makefile.am: Add new testspinbutton.c
      ed649f3b
    • Federico Mena Quintero's avatar
      Put the trash icon on the right for LTR locales, or on the left for RTL. · 2de43410
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drag_set_delete_cursor):
      	Put the trash icon on the right for LTR locales, or on the left
      	for RTL.
      	(shortcuts_drag_motion_cb): Cancel the idle handler here as well.
      	(shortcuts_drag_leave_cb): Test whether the idle is present.
      	(shortcuts_drag_data_received_cb): Ahem, don't assert here.
      2de43410
    • Federico Mena Quintero's avatar
      Put the trash icon on the right for LTR locales, or on the left for RTL. · b4a6705a
      Federico Mena Quintero authored
      2004-03-11  Federico Mena Quintero  <federico@ximian.com>
      
      	* gtk/gtkfilechooserdefault.c (shortcuts_drag_set_delete_cursor):
      	Put the trash icon on the right for LTR locales, or on the left
      	for RTL.
      	(shortcuts_drag_motion_cb): Cancel the idle handler here as well.
      	(shortcuts_drag_leave_cb): Test whether the idle is present.
      b4a6705a
  5. 11 Mar, 2004 7 commits