1. 11 Mar, 2019 1 commit
  2. 04 Mar, 2019 1 commit
  3. 03 Mar, 2019 1 commit
  4. 02 Mar, 2019 1 commit
  5. 01 Mar, 2019 1 commit
  6. 28 Feb, 2019 1 commit
  7. 27 Feb, 2019 1 commit
  8. 26 Feb, 2019 1 commit
  9. 25 Feb, 2019 1 commit
  10. 24 Feb, 2019 2 commits
  11. 20 Feb, 2019 2 commits
  12. 17 Feb, 2019 2 commits
  13. 13 Feb, 2019 1 commit
  14. 09 Feb, 2019 1 commit
  15. 08 Feb, 2019 1 commit
  16. 05 Feb, 2019 1 commit
  17. 04 Feb, 2019 3 commits
  18. 03 Feb, 2019 1 commit
  19. 01 Feb, 2019 1 commit
  20. 31 Jan, 2019 1 commit
  21. 28 Jan, 2019 2 commits
  22. 27 Jan, 2019 1 commit
  23. 25 Jan, 2019 2 commits
  24. 24 Jan, 2019 2 commits
    • Krzesimir Nowak's avatar
      Move from intltool to gettext · bb457766
      Krzesimir Nowak authored
      This is to make a migration from autotools to meson easier. Also,
      intltool got obsoleted by gettext.
      
      There are minor differences in some of the translated files, but
      functionally it should not make any difference. But why gettext insist
      on reversing the alphabetic order in the appdata file (so zh_TW comes
      first and cs comes last) is beyond me.
      
      !11
      bb457766
    • Krzesimir Nowak's avatar
      Simplify desktop file generation · e34c7022
      Krzesimir Nowak authored
      Desktop file was processed twice - by the configure script and by
      intltool. Configure was putting a yelp version to some
      bugzilla-related value. Bugzilla is an obsolete bug tracker in GNOME
      (the project has moved to GNOME gitlab), so the field is also
      obsolete. With dropping the fields, configure has no business in the
      desktop file any more.
      e34c7022
  25. 23 Jan, 2019 3 commits
  26. 21 Jan, 2019 5 commits
    • Tomas Popela's avatar
      Remove the unused encoding and language code from YelpManDocument · 2f3aea44
      Tomas Popela authored
      Error: UNUSED_VALUE (CWE-563): [#def25]
      yelp-3.28.1/libyelp/yelp-man-document.c:422: value_overwrite: Overwriting previous write to "encoding" with value from "langmap[i].encoding".
      yelp-3.28.1/libyelp/yelp-man-document.c:416: assigned_pointer: Assigning value from ""ISO-8859-1"" to "encoding" here, but that stored value is overwritten before it can be used.
        414|       encoding = g_getenv("MAN_ENCODING");
        415|       if (encoding == NULL)
        416|->  encoding = "ISO-8859-1";
        417|
        418|       if (language != NULL) {
      
      Error: CLANG_WARNING: [#def26]
      yelp-3.28.1/libyelp/yelp-man-document.c:416:2: warning: Value stored to 'encoding' is never read
              encoding = "ISO-8859-1";
              ^          ~~~~~~~~~~~~
      yelp-3.28.1/libyelp/yelp-man-document.c:416:2: note: Value stored to 'encoding' is never read
              encoding = "ISO-8859-1";
              ^          ~~~~~~~~~~~~
        414|       encoding = g_getenv("MAN_ENCODING");
        415|       if (encoding == NULL)
        416|->  encoding = "ISO-8859-1";
        417|
        418|       if (language != NULL) {
      
      Error: CLANG_WARNING: [#def27]
      yelp-3.28.1/libyelp/yelp-man-document.c:422:3: warning: Value stored to 'encoding' is never read
                      encoding = langmap[i].encoding;
                      ^          ~~~~~~~~~~~~~~~~~~~
      yelp-3.28.1/libyelp/yelp-man-document.c:422:3: note: Value stored to 'encoding' is never read
                      encoding = langmap[i].encoding;
                      ^          ~~~~~~~~~~~~~~~~~~~
        420|    for (i = 0; langmap[i].language != NULL; i++) {
        421|        if (g_str_equal (language, langmap[i].language)) {
        422|->   encoding = langmap[i].encoding;
        423|     break;
        424|        }
      2f3aea44
    • Tomas Popela's avatar
      Remove unused variable · e34c6abd
      Tomas Popela authored
      4. yelp-3.28.1/libyelp/yelp-info-parser.c:959:2: note: Value stored to 'pages' is never read
               pages = 0;
               ^       ~
         957|             (GDestroyNotify) gtk_tree_iter_free);
         958|
         959|->  pages = 0;
         960|    for (ptr = page_list; *ptr != NULL; ptr++)
         961|    {
      e34c6abd
    • Tomas Popela's avatar
      Check variable before dereferencing it · 538e86cc
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-mallard-document.c:341: var_compare_op: Comparing "path" to null implies that "path" might be null.
      yelp-3.28.1/libyelp/yelp-mallard-document.c:346: var_deref_op: Dereferencing null pointer "path".
      538e86cc
    • Tomas Popela's avatar
      Check the strstr() return value before using it · 9847b432
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-uri-builder.c:81: returned_null: "strstr" returns null (checked 10 out of 12 times).
      yelp-3.28.1/libyelp/yelp-uri-builder.c:81: var_assigned: Assigning: "resource" = null return value from "strstr".
      yelp-3.28.1/libyelp/yelp-uri-builder.c:82: dereference: Incrementing a pointer which might be null: "resource".
      9847b432
    • Tomas Popela's avatar
      Swap the if() checks to avoid possible null pointer dereference · cbf737ea
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-transform.c:501: deref_ptr: Directly dereferencing pointer "ctxt".
      yelp-3.28.1/libyelp/yelp-transform.c:504: check_after_deref: Null-checking "ctxt" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
      cbf737ea