1. 13 Feb, 2019 1 commit
  2. 09 Feb, 2019 1 commit
  3. 08 Feb, 2019 1 commit
  4. 05 Feb, 2019 1 commit
  5. 04 Feb, 2019 3 commits
  6. 03 Feb, 2019 1 commit
  7. 01 Feb, 2019 1 commit
  8. 31 Jan, 2019 1 commit
  9. 28 Jan, 2019 2 commits
  10. 27 Jan, 2019 1 commit
  11. 25 Jan, 2019 2 commits
  12. 24 Jan, 2019 2 commits
    • Krzesimir Nowak's avatar
      Move from intltool to gettext · bb457766
      Krzesimir Nowak authored
      This is to make a migration from autotools to meson easier. Also,
      intltool got obsoleted by gettext.
      
      There are minor differences in some of the translated files, but
      functionally it should not make any difference. But why gettext insist
      on reversing the alphabetic order in the appdata file (so zh_TW comes
      first and cs comes last) is beyond me.
      
      !11
      bb457766
    • Krzesimir Nowak's avatar
      Simplify desktop file generation · e34c7022
      Krzesimir Nowak authored
      Desktop file was processed twice - by the configure script and by
      intltool. Configure was putting a yelp version to some
      bugzilla-related value. Bugzilla is an obsolete bug tracker in GNOME
      (the project has moved to GNOME gitlab), so the field is also
      obsolete. With dropping the fields, configure has no business in the
      desktop file any more.
      e34c7022
  13. 23 Jan, 2019 3 commits
  14. 21 Jan, 2019 15 commits
    • Tomas Popela's avatar
      Remove the unused encoding and language code from YelpManDocument · 2f3aea44
      Tomas Popela authored
      Error: UNUSED_VALUE (CWE-563): [#def25]
      yelp-3.28.1/libyelp/yelp-man-document.c:422: value_overwrite: Overwriting previous write to "encoding" with value from "langmap[i].encoding".
      yelp-3.28.1/libyelp/yelp-man-document.c:416: assigned_pointer: Assigning value from ""ISO-8859-1"" to "encoding" here, but that stored value is overwritten before it can be used.
        414|       encoding = g_getenv("MAN_ENCODING");
        415|       if (encoding == NULL)
        416|->  encoding = "ISO-8859-1";
        417|
        418|       if (language != NULL) {
      
      Error: CLANG_WARNING: [#def26]
      yelp-3.28.1/libyelp/yelp-man-document.c:416:2: warning: Value stored to 'encoding' is never read
              encoding = "ISO-8859-1";
              ^          ~~~~~~~~~~~~
      yelp-3.28.1/libyelp/yelp-man-document.c:416:2: note: Value stored to 'encoding' is never read
              encoding = "ISO-8859-1";
              ^          ~~~~~~~~~~~~
        414|       encoding = g_getenv("MAN_ENCODING");
        415|       if (encoding == NULL)
        416|->  encoding = "ISO-8859-1";
        417|
        418|       if (language != NULL) {
      
      Error: CLANG_WARNING: [#def27]
      yelp-3.28.1/libyelp/yelp-man-document.c:422:3: warning: Value stored to 'encoding' is never read
                      encoding = langmap[i].encoding;
                      ^          ~~~~~~~~~~~~~~~~~~~
      yelp-3.28.1/libyelp/yelp-man-document.c:422:3: note: Value stored to 'encoding' is never read
                      encoding = langmap[i].encoding;
                      ^          ~~~~~~~~~~~~~~~~~~~
        420|    for (i = 0; langmap[i].language != NULL; i++) {
        421|        if (g_str_equal (language, langmap[i].language)) {
        422|->   encoding = langmap[i].encoding;
        423|     break;
        424|        }
      2f3aea44
    • Tomas Popela's avatar
      Remove unused variable · e34c6abd
      Tomas Popela authored
      4. yelp-3.28.1/libyelp/yelp-info-parser.c:959:2: note: Value stored to 'pages' is never read
               pages = 0;
               ^       ~
         957|             (GDestroyNotify) gtk_tree_iter_free);
         958|
         959|->  pages = 0;
         960|    for (ptr = page_list; *ptr != NULL; ptr++)
         961|    {
      e34c6abd
    • Tomas Popela's avatar
      Check variable before dereferencing it · 538e86cc
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-mallard-document.c:341: var_compare_op: Comparing "path" to null implies that "path" might be null.
      yelp-3.28.1/libyelp/yelp-mallard-document.c:346: var_deref_op: Dereferencing null pointer "path".
      538e86cc
    • Tomas Popela's avatar
      Check the strstr() return value before using it · 9847b432
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-uri-builder.c:81: returned_null: "strstr" returns null (checked 10 out of 12 times).
      yelp-3.28.1/libyelp/yelp-uri-builder.c:81: var_assigned: Assigning: "resource" = null return value from "strstr".
      yelp-3.28.1/libyelp/yelp-uri-builder.c:82: dereference: Incrementing a pointer which might be null: "resource".
      9847b432
    • Tomas Popela's avatar
      Swap the if() checks to avoid possible null pointer dereference · cbf737ea
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-transform.c:501: deref_ptr: Directly dereferencing pointer "ctxt".
      yelp-3.28.1/libyelp/yelp-transform.c:504: check_after_deref: Null-checking "ctxt" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
      cbf737ea
    • Tomas Popela's avatar
      Initialize ws_start variable before returning it · 0b3b23c5
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-man-parser.c:1194: var_decl: Declaring variable "ws_start" without initializer.
      yelp-3.28.1/libyelp/yelp-man-parser.c:1202: uninit_use: Using uninitialized value "ws_start".
      0b3b23c5
    • Tomas Popela's avatar
      Increase the size of string variables passed to sscanf · 6ad30cec
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-man-parser.c:549: error[invalidScanfFormatWidth]: Width 10 given in format string (no. 2) is larger than destination buffer 'name[10]', use %9s to prevent overflowing it.
      
      yelp-3.28.1/libyelp/yelp-man-parser.c:926: error[invalidScanfFormatWidth]: Width 16 given in format string (no. 1) is larger than destination buffer 'name[16]', use %15s to prevent overflowing it.
      6ad30cec
    • Tomas Popela's avatar
      Avoid possible overrun while comparing to MAN_FONTS · 8b2fab29
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-man-parser.c:464: cond_at_most: Checking "k > 8U" implies that "k" may be up to 8 on the false branch.
      yelp-3.28.1/libyelp/yelp-man-parser.c:469: overrun-local: Overrunning array "parser->font_registers" of 8 8-byte elements at element index 8 (byte offset 64) using index "k" (which evaluates to 8).
      
      yelp-3.28.1/libyelp/yelp-man-parser.c:476: assignment: Assigning: "k" = "parser->current_font".
      yelp-3.28.1/libyelp/yelp-man-parser.c:477: cond_at_most: Checking "k > 8U" implies that "k" and "parser->current_font" may be up to 8 on the false branch.
      yelp-3.28.1/libyelp/yelp-man-parser.c:477: overrun-local: Overrunning array "parser->font_registers" of 8 8-byte elements at element index 8 (byte offset 64) using index "k" (which evaluates to 8).
      8b2fab29
    • Tomas Popela's avatar
      Check whether parser is null before dereferencing it · 6b05dd2a
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-man-parser.c:445: var_compare_op: Comparing "parser" to null implies that "parser" might be null.
      yelp-3.28.1/libyelp/yelp-man-parser.c:449: var_deref_op: Dereferencing null pointer "parser".
      6b05dd2a
    • Tomas Popela's avatar
      Check whether the index variable is valid before dereferencing it · 9252d10b
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-mallard-document.c:1002: deref_ptr: Directly dereferencing pointer "index".
      yelp-3.28.1/libyelp/yelp-mallard-document.c:1073: check_after_deref: Null-checking "index" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
      9252d10b
    • Tomas Popela's avatar
      Fix a use of an uninitialized variable · f97cc50b
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-info-parser.c:1174: var_decl: Declaring variable "menu_node" without initializer.
      yelp-3.28.1/libyelp/yelp-info-parser.c:1310: uninit_use: Using uninitialized value "menu_node".
       1308|       else if (*(menuitems[i]) != '\0') {
       1309|         tmp = g_strconcat ("\n", first_non_space (menuitems[i]), NULL);
       1310|->       xmlNewTextChild (mholder ? mholder : menu_node,
       1311|                          NULL, BAD_CAST "para1",
       1312|   		       BAD_CAST tmp);
      f97cc50b
    • Tomas Popela's avatar
      Check whether variable node is set before dereferencing it · 14d995ee
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-info-parser.c:766: dereference: Dereferencing a pointer that might be null "node" when calling "strncmp".
      14d995ee
    • Tomas Popela's avatar
      Check whether the index variable is valid before dereferencing it · 45292455
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-docbook-document.c:1058: check_after_deref: Null-checking "index" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
      yelp-3.28.1/libyelp/yelp-docbook-document.c:1026: deref_ptr: Directly dereferencing pointer "index".
      yelp-3.28.1/libyelp/yelp-docbook-document.c:1054: deref_ptr: Directly dereferencing pointer "index".
       1052|       if (filename != NULL)
       1053|           g_free (filename);
       1054|->     if (index->doc != NULL)
       1055|           xmlFreeDoc (index->doc);
       1056|       if (index->doc_uri != NULL)
      45292455
    • Tomas Popela's avatar
      Check whether document has a root element before accessing it · e7f03bfb
      Tomas Popela authored
      yelp-3.28.1/libyelp/yelp-docbook-document.c:562:13: note: Access to field 'ns' results in a dereference of a null pointer (loaded from field 'xmlcur')
              if (priv->xmlcur->ns) {
                  ^     ~~~~~~
        560|            * unique value, and insert it into the in-memory tree */
        561|           g_snprintf (autoidstr, 20, "//autoid-%d", ++autoid);
        562|->         if (priv->xmlcur->ns) {
        563|               xmlNewNsProp (priv->xmlcur,
        564|                             xmlNewNs (priv->xmlcur, XML_XML_NAMESPACE, BAD_CAST "xml"),
      
      yelp-3.28.1/libyelp/yelp-docbook-document.c:608:16: note: Access to field 'children' results in a dereference of a null pointer (loaded from field 'xmlcur')
          for (cur = priv->xmlcur->children; cur; cur = cur->next) {
                     ^     ~~~~~~
        606|                                 NULL);
        607|
        608|->     for (cur = priv->xmlcur->children; cur; cur = cur->next) {
        609|           if (cur->type == XML_ELEMENT_NODE) {
        610|               priv->xmlcur = cur;
      e7f03bfb
    • David King's avatar
      Add G_GNUC_PRINTF attribute to yelp_debug() · 48bb6d9c
      David King authored
      Silence a compiler warning.
      48bb6d9c
  15. 16 Jan, 2019 1 commit
  16. 13 Dec, 2018 1 commit
  17. 03 Dec, 2018 1 commit
  18. 30 Oct, 2018 1 commit
  19. 29 Oct, 2018 1 commit