Remove get_text()'s include_trailing_spaces
It's unclear what the include_trailing_spaces
parameter to get_text()
and friends does or is supposed to do.
The name suggests to me that if the flag is unset, explicit whitespaces (that were explicitly printed by an app) at the end of the line would be chopped off.
According to the documentation and implementation this is not the case. This flag is about including "unused" cells (beyond the area that was explicitly printed by an app) as spaces.
That being said, it doesn't work. Toggling the flag for get_selected_text()
results in no change in its behavior. Explicitly printed spaces are preserved, but unused cells aren't added (the reasonable behavior).
As discussed with Christian, we don't see a use case for any other behavior than this.
Perhaps this feature worked a long time ago, then broke at some point and nobody noticed. If it turns out to be important then we can bring it back any time with a proper implementation.
Until then, let's remove it.