32bit builds are broken due to integer comparisons
In the last 2-3 days seems that 32bit builds broke. Though it seems that it might be a different error for each arch.
i686 log:
https://gitlab.gnome.org/GNOME/gnome-build-meta/-/jobs/274458
FAILED: src/25a6634@@vte-2.91@sha/ring.cc.o
c++ -Isrc/25a6634@@vte-2.91@sha -Isrc -I../src -I. -I../ -Isrc/vte -I../src/vte -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/lib/i386-linux-gnu/libffi-3.2.1/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/p11-kit-1 -I/usr/include/gtk-3.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=gnu++17 -O2 -g -Wall -Wextra -Wcast-align -Wcast-function-type -Wclobbered -Wempty-body -Wendif-labels -Werror=implicit-function-declaration -Werror=init-self -Werror=missing-include-dirs -Werror=missing-prototypes -Werror=pointer-arith -Wfloat-equal -Wignored-qualifiers -Wlogical-op -Wmisleading-indentation -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-packed -Wno-switch-enum -Wno-unused-parameter -Wshadow -Wshift-negative-value -Wsign-compare -Wstrict-aliasing=2 -Wtype-limits -Wundef -Wuninitialized -Wuninitialized -Wunsafe-loop-optimizations -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-value -Wunused-variable -Wvla -Wwrite-strings -fdiagnostics-show-option -fno-common -fno-semantic-interposition -fstack-protector -fstack-protector-strong -fno-strict-aliasing -Wimplicit-fallthrough=5 -Wstrict-null-sentinel -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -fvisibility=hidden -Werror=format=2 -Werror=format-nonliteral -Werror=format-security -march=i686 -mtune=generic -O2 -g -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fPIC -pthread '-DG_LOG_DOMAIN="VTE"' '-DLOCALEDIR="/usr/share/locale"' -DGLIB_DISABLE_DEPRECATION_WARNINGS -DVTE_COMPILATION -UPARSER_INCLUDE_NOP -MD -MQ 'src/25a6634@@vte-2.91@sha/ring.cc.o' -MF 'src/25a6634@@vte-2.91@sha/ring.cc.o.d' -o 'src/25a6634@@vte-2.91@sha/ring.cc.o' -c ../src/ring.cc
../src/ring.cc: In member function ‘bool vte::base::Ring::frozen_row_column_to_text_offset(vte::base::Ring::row_t, vte::base::Ring::column_t, vte::base::Ring::CellTextOffset*)’:
../src/ring.cc:1010:51: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘vte::base::Ring::column_t’ {aka ‘long int’} [-Wsign-compare]
for (i = 0, cell = row->cells; i < row->len && i < column; i++, cell++) {
~~^~~~~~~~
In file included from /usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h:9,
from /usr/include/glib-2.0/glib/gtypes.h:32,
from /usr/include/glib-2.0/glib/galloca.h:32,
from /usr/include/glib-2.0/glib.h:30,
from ../src/debug.h:26,
from ../src/ring.cc:23:
../src/ring.cc:1012:45: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘vte::base::Ring::column_t’ {aka ‘long int’} [-Wsign-compare]
if (G_UNLIKELY (i + cell->attr.columns() > column)) {
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:891:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
if (expr) \
^~~~
../src/ring.cc:1012:8: note: in expansion of macro ‘G_UNLIKELY’
if (G_UNLIKELY (i + cell->attr.columns() > column)) {
^~~~~~~~~~
In file included from ../src/ring.cc:23:
../src/ring.cc: In member function ‘void vte::base::Ring::rewrap(vte::base::Ring::column_t, VteVisualPosition**)’:
../src/ring.cc:1190:5: error: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
" Old paragraph: row %" G_GSIZE_FORMAT " (text_offset %" G_GSIZE_FORMAT ") up to (exclusive) ", /* no '\n' */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
old_row_index - 1,
~~~~~~~~~~~~~~~~~
../src/debug.h:95:49: note: in definition of macro ‘_vte_debug_print’
G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
^~~
../src/ring.cc:1212:5: error: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
"row %" G_GSIZE_FORMAT " (text_offset %" G_GSIZE_FORMAT ")%s len %" G_GSIZE_FORMAT " is_ascii %d\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
old_row_index - 1,
~~~~~~~~~~~~~~~~~
../src/debug.h:95:49: note: in definition of macro ‘_vte_debug_print’
G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
^~~
../src/ring.cc:1253:14: warning: comparison of integer expressions of different signedness: ‘vte::base::Ring::column_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
if (col >= columns - attr_change.attr.columns() + 1) {
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
[63/84] Compiling C++ object 'src/app/f2cd6bd@@vte-2.91@exe/app.cc.o'.
[64/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vtedraw.cc.o'.
[65/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vteaccess.cc.o'.
[66/84] Compiling C++ object 'src/25a6634@@parser-cat@exe/parser-cat.cc.o'.
[67/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vtegtk.cc.o'.
[68/84] Compiling C++ object 'src/25a6634@@test-parser@exe/parser-test.cc.o'.
[69/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vteseq.cc.o'.
[70/84] Compiling C++ object 'src/25a6634@@test-stream@exe/vtestream.cc.o'.
[71/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vte.cc.o'.
In file included from /usr/lib/i386-linux-gnu/glib-2.0/include/glibconfig.h:9,
from /usr/include/glib-2.0/glib/gtypes.h:32,
from /usr/include/glib-2.0/glib/galloca.h:32,
from /usr/include/glib-2.0/glib.h:30,
from ../src/vte.cc:34:
../src/vte.cc: In member function ‘void vte::terminal::Terminal::cleanup_fragments(long int, long int)’:
../src/vte.cc:2608:59: warning: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘long int’ [-Wsign-compare]
g_assert(cell_col->attr.columns() > end - col);
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:891:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
if (expr) \
^~~~
/usr/include/glib-2.0/glib/gtestutils.h:164:49: note: in expansion of macro ‘G_LIKELY’
if G_LIKELY (expr) ; else \
^~~~~~~~
../src/vte.cc:2608:25: note: in expansion of macro ‘g_assert’
g_assert(cell_col->attr.columns() > end - col);
^~~~~~~~
ninja: build stopped: subcommand failed.
[00:00:30] FAILURE sdk/vte.bst: Running build-commands
armv7hf log:
https://gitlab.gnome.org/GNOME/gnome-build-meta/-/jobs/274460
[62/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/ring.cc.o'.
FAILED: src/25a6634@@vte-2.91@sha/ring.cc.o
c++ -Isrc/25a6634@@vte-2.91@sha -Isrc -I../src -I. -I../ -Isrc/vte -I../src/vte -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/lib/arm-linux-gnueabihf/libffi-3.2.1/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/uuid -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/p11-kit-1 -I/usr/include/gtk-3.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libdrm -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/arm-linux-gnueabihf/dbus-1.0/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -std=gnu++17 -O2 -g -Wall -Wextra -Wcast-align -Wcast-function-type -Wclobbered -Wempty-body -Wendif-labels -Werror=implicit-function-declaration -Werror=init-self -Werror=missing-include-dirs -Werror=missing-prototypes -Werror=pointer-arith -Wfloat-equal -Wignored-qualifiers -Wlogical-op -Wmisleading-indentation -Wmissing-declarations -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-packed -Wno-switch-enum -Wno-unused-parameter -Wshadow -Wshift-negative-value -Wsign-compare -Wstrict-aliasing=2 -Wtype-limits -Wundef -Wuninitialized -Wuninitialized -Wunsafe-loop-optimizations -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-value -Wunused-variable -Wvla -Wwrite-strings -fdiagnostics-show-option -fno-common -fno-semantic-interposition -fstack-protector -fstack-protector-strong -fno-strict-aliasing -Wimplicit-fallthrough=5 -Wstrict-null-sentinel -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -fvisibility=hidden -Werror=format=2 -Werror=format-nonliteral -Werror=format-security -O2 -g -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fPIC -pthread '-DG_LOG_DOMAIN="VTE"' '-DLOCALEDIR="/usr/share/locale"' -DGLIB_DISABLE_DEPRECATION_WARNINGS -DVTE_COMPILATION -UPARSER_INCLUDE_NOP -MD -MQ 'src/25a6634@@vte-2.91@sha/ring.cc.o' -MF 'src/25a6634@@vte-2.91@sha/ring.cc.o.d' -o 'src/25a6634@@vte-2.91@sha/ring.cc.o' -c ../src/ring.cc
../src/ring.cc: In member function ‘bool vte::base::Ring::frozen_row_column_to_text_offset(vte::base::Ring::row_t, vte::base::Ring::column_t, vte::base::Ring::CellTextOffset*)’:
../src/ring.cc:1010:51: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘vte::base::Ring::column_t’ {aka ‘long int’} [-Wsign-compare]
for (i = 0, cell = row->cells; i < row->len && i < column; i++, cell++) {
~~^~~~~~~~
In file included from /usr/lib/arm-linux-gnueabihf/glib-2.0/include/glibconfig.h:9,
from /usr/include/glib-2.0/glib/gtypes.h:32,
from /usr/include/glib-2.0/glib/galloca.h:32,
from /usr/include/glib-2.0/glib.h:30,
from ../src/debug.h:26,
from ../src/ring.cc:23:
../src/ring.cc:1012:45: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘vte::base::Ring::column_t’ {aka ‘long int’} [-Wsign-compare]
if (G_UNLIKELY (i + cell->attr.columns() > column)) {
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:891:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
if (expr) \
^~~~
../src/ring.cc:1012:8: note: in expansion of macro ‘G_UNLIKELY’
if (G_UNLIKELY (i + cell->attr.columns() > column)) {
^~~~~~~~~~
In file included from ../src/ring.cc:23:
../src/ring.cc: In member function ‘void vte::base::Ring::rewrap(vte::base::Ring::column_t, VteVisualPosition**)’:
../src/ring.cc:1190:5: error: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
" Old paragraph: row %" G_GSIZE_FORMAT " (text_offset %" G_GSIZE_FORMAT ") up to (exclusive) ", /* no '\n' */
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
old_row_index - 1,
~~~~~~~~~~~~~~~~~
../src/debug.h:95:49: note: in definition of macro ‘_vte_debug_print’
G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
^~~
../src/ring.cc:1212:5: error: format ‘%u’ expects argument of type ‘unsigned int’, but argument 2 has type ‘long unsigned int’ [-Werror=format=]
"row %" G_GSIZE_FORMAT " (text_offset %" G_GSIZE_FORMAT ")%s len %" G_GSIZE_FORMAT " is_ascii %d\n",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
old_row_index - 1,
~~~~~~~~~~~~~~~~~
../src/debug.h:95:49: note: in definition of macro ‘_vte_debug_print’
G_STMT_START { _VTE_DEBUG_IF(flags) g_printerr(fmt, ##__VA_ARGS__); } G_STMT_END
^~~
../src/ring.cc:1253:14: warning: comparison of integer expressions of different signedness: ‘vte::base::Ring::column_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
if (col >= columns - attr_change.attr.columns() + 1) {
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: some warnings being treated as errors
[63/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vtedraw.cc.o'.
[64/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vteaccess.cc.o'.
[65/84] Compiling C++ object 'src/25a6634@@parser-cat@exe/parser-cat.cc.o'.
[66/84] Compiling C++ object 'src/app/f2cd6bd@@vte-2.91@exe/app.cc.o'.
[67/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vtegtk.cc.o'.
[68/84] Compiling C++ object 'src/25a6634@@test-stream@exe/vtestream.cc.o'.
[69/84] Compiling C++ object 'src/25a6634@@test-parser@exe/parser-test.cc.o'.
[70/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vteseq.cc.o'.
[71/84] Compiling C++ object 'src/25a6634@@vte-2.91@sha/vte.cc.o'.
In file included from /usr/lib/arm-linux-gnueabihf/glib-2.0/include/glibconfig.h:9,
from /usr/include/glib-2.0/glib/gtypes.h:32,
from /usr/include/glib-2.0/glib/galloca.h:32,
from /usr/include/glib-2.0/glib.h:30,
from ../src/vte.cc:34:
../src/vte.cc: In member function ‘void vte::terminal::Terminal::cleanup_fragments(long int, long int)’:
../src/vte.cc:2608:59: warning: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘long int’ [-Wsign-compare]
g_assert(cell_col->attr.columns() > end - col);
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
/usr/include/glib-2.0/glib/gmacros.h:891:8: note: in definition of macro ‘_G_BOOLEAN_EXPR’
if (expr) \
^~~~
/usr/include/glib-2.0/glib/gtestutils.h:164:49: note: in expansion of macro ‘G_LIKELY’
if G_LIKELY (expr) ; else \
^~~~~~~~
../src/vte.cc:2608:25: note: in expansion of macro ‘g_assert’
g_assert(cell_col->attr.columns() > end - col);
^~~~~~~~
../src/vte.cc: In member function ‘bool vte::terminal::Terminal::widget_key_press(GdkEventKey*)’:
../src/vte.cc:4552:29: warning: cast from ‘GdkEventKey*’ {aka ‘_GdkEventKey*’} to ‘GdkEvent*’ {aka ‘_GdkEvent*’} increases required alignment of target type [-Wcast-align]
read_modifiers((GdkEvent*)event);
^~~~~
../src/vte.cc: In member function ‘bool vte::terminal::Terminal::widget_key_release(GdkEventKey*)’:
../src/vte.cc:4954:28: warning: cast from ‘GdkEventKey*’ {aka ‘_GdkEventKey*’} to ‘GdkEvent*’ {aka ‘_GdkEvent*’} increases required alignment of target type [-Wcast-align]
read_modifiers((GdkEvent*)event);
^~~~~
../src/vte.cc: In member function ‘void vte::terminal::Terminal::widget_focus_in(GdkEventFocus*)’:
../src/vte.cc:7056:28: warning: cast from ‘GdkEventFocus*’ {aka ‘_GdkEventFocus*’} to ‘GdkEvent*’ {aka ‘_GdkEvent*’} increases required alignment of target type [-Wcast-align]
read_modifiers((GdkEvent*)event);
^~~~~
../src/vte.cc: In member function ‘void vte::terminal::Terminal::widget_focus_out(GdkEventFocus*)’:
../src/vte.cc:7086:28: warning: cast from ‘GdkEventFocus*’ {aka ‘_GdkEventFocus*’} to ‘GdkEvent*’ {aka ‘_GdkEvent*’} increases required alignment of target type [-Wcast-align]
read_modifiers((GdkEvent*)event);
^~~~~
ninja: build stopped: subcommand failed.
[00:00:37] FAILURE sdk/vte.bst: Running build-commands
Edited by Jordan Petridis