1. 05 Feb, 2007 11 commits
    • Chris Wilson's avatar
      Simple to script to scroll UTF-8 text. · 7fb0dfdb
      Chris Wilson authored
      svn path=/trunk/; revision=1630
      7fb0dfdb
    • Chris Wilson's avatar
      Bug 404757 – URL matching doesn't work with PCRE · e8a2e727
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 404757 – URL matching doesn't work with PCRE
      
      	* configure.in:
      		mention the inconsistency in the help string and default to no.
      
      
      svn path=/trunk/; revision=1629
      e8a2e727
    • Chris Wilson's avatar
      Don't draw cell attributes across spaces. · 102053e8
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* src/vte.c: (vte_terminal_draw_rows):
      		Don't draw cell attributes across spaces.
      
      
      svn path=/trunk/; revision=1628
      102053e8
    • Chris Wilson's avatar
      A couple more G_LIKELYs. · 5ef6ed83
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* src/vte.c: (_vte_terminal_insert_char):
      		A couple more G_LIKELYs.
      
      
      svn path=/trunk/; revision=1627
      5ef6ed83
    • Chris Wilson's avatar
      Bug 403028 – decset mode 12 = blinking cursor · be368397
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 403028 – decset mode 12 = blinking cursor
      
      	* src/vteseq.c: (vte_sequence_handler_decset_internal):
      		Following convention, disallow the application's control
      		over the blinking cursor in favour of the user's setting.
      
      
      svn path=/trunk/; revision=1626
      be368397
    • Chris Wilson's avatar
      Some more small callgrind tweaks - well into the law of diminishing · 25007669
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Some more small callgrind tweaks - well into the law of diminishing
      	returns.
      
      	* src/iso2022.c: (_vte_iso2022_is_ambiguous_ht),
      	(_vte_iso2022_is_ambiguous), (process_8_bit_sequence),
      	(process_cdata), (_vte_iso2022_unichar_width):
      	* src/matcher.c: (_vte_matcher_free_params_array):
      	* src/vte.c: (vte_terminal_process_incoming):
      
      
      svn path=/trunk/; revision=1625
      25007669
    • Chris Wilson's avatar
      Beware the trivial change. Handle reuse of GValueArray correctly. · 589e6df7
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Beware the trivial change. Handle reuse of GValueArray correctly.
      
      	* src/matcher.c: (_vte_matcher_match):
      	* src/table.c: (_vte_table_match):
      	* src/trie.c: (_vte_trie_match):
      	* src/vte.c: (vte_terminal_process_incoming):
      
      
      svn path=/trunk/; revision=1624
      589e6df7
    • Chris Wilson's avatar
      And kill the leak as vte_table_match erroneously cleared its output · 94ce0b00
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* src/table.c: (_vte_table_match):
      		And kill the leak as vte_table_match erroneously cleared
      		its output arguments.
      
      
      svn path=/trunk/; revision=1623
      94ce0b00
    • Chris Wilson's avatar
      The continual reallocation of GValueArray is the last trivially avoidable · 8109c646
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	The continual reallocation of GValueArray is the last trivially
      	avoidable g_realloc.
      
      	* src/interpret.c: (main):
      	* src/matcher.c: (_vte_matcher_create), (_vte_matcher_destroy),
      	(_vte_matcher_match), (_vte_matcher_free_params_array):
      	* src/matcher.h:
      	* src/table.c: (_vte_table_extract_string):
      	* src/trie.c: (_vte_trie_matchx), (_vte_trie_match), (main):
      	* src/vte.c: (vte_terminal_process_incoming):
      
      
      svn path=/trunk/; revision=1622
      8109c646
    • Chris Wilson's avatar
      Missed an important compiler warning. · 95d056d8
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* src/ring.c: (_vte_ring_insert):
      		Missed an important compiler warning.
      
      
      svn path=/trunk/; revision=1621
      95d056d8
    • Chris Wilson's avatar
      cf Bug 342338 – suffers from memory fragmentation · b307bc5c
      Chris Wilson authored
      2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	cf Bug 342338 – suffers from memory fragmentation
      
      	Reuse the last VteRowData instead of immediately freeing it. Avoids
      	recreating and *regrowing* a new GArray on the heap.
      
      	In the simple scrolling benchmarks this can boost performance by as
      	much as 10%!
      
      	* src/ring.c: (_vte_ring_insert), (_vte_ring_insert_preserve),
      	(_vte_ring_remove), (_vte_ring_append):
      	* src/ring.h:
      	* src/vte-private.h:
      	* src/vte.c: (_vte_reset_row_data), (_vte_terminal_ensure_cursor),
      	(_vte_terminal_insert_char), (vte_terminal_reset_rowdata):
      	* src/vteseq.c: (vte_insert_line_internal),
      	(vte_sequence_handler_scroll_up_or_down),
      	(vte_sequence_handler_cd), (vte_sequence_handler_sf),
      	(vte_sequence_handler_clear_screen),
      	(vte_sequence_handler_screen_alignment_test):
      
      
      svn path=/trunk/; revision=1620
      b307bc5c
  2. 04 Feb, 2007 12 commits
    • Chris Wilson's avatar
      A few more compiler warnings. · 285ebd25
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	A few more compiler warnings.
      
      	* src/buffer.c: (_vte_buffer_peek_gstring):
      	* src/iso2022.c: (process_control):
      	* src/vteft2.c: (_vte_ft2_set_text_font):
      	* src/vteseq.c: (vte_sequence_handler_set_title_internal):
      	* src/vtetc.c: (_vte_termcap_parse_file):
      
      
      svn path=/trunk/; revision=1619
      285ebd25
    • Chris Wilson's avatar
      Bug 106618 – CJK 'fixed width' font and 's p a c e d o u t' issue · ee4147ed
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 106618 – CJK 'fixed width' font and 's p a c e d o u t' issue
      
      	* src/vtedraw.h:
      	* src/vteglyph.c: (_vte_glyph_cache_set_font_description):
      	* src/vtepango.c: (_vte_pango_set_text_font):
      	* src/vtepangox.c: (_vte_pango_x_set_text_font):
      	* src/vtexft.c: (_vte_xft_set_text_font):
      		Detect a change in font between wide-chars and recheck for a
      		fixed-width estimate.
      
      
      svn path=/trunk/; revision=1618
      ee4147ed
    • Chris Wilson's avatar
      Revert the accidentally applied patch for bug 324246. patch said is was · 71b19227
      Chris Wilson authored
      trying to reverse a revered patch - it lied.
      
      svn path=/trunk/; revision=1617
      71b19227
    • Chris Wilson's avatar
      Micro-opts. · 65eeaaa0
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Micro-opts.
      
      	* src/table.c: (_vte_table_match):
      		No need set to NULL.
      	* src/vte.c: (_vte_terminal_ensure_cursor):
      		If we have added some rows, the last is the current.
      
      
      svn path=/trunk/; revision=1616
      65eeaaa0
    • Chris Wilson's avatar
      Move window/icon title changed to the post-processing emission - helps · 936abce0
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Move window/icon title changed to the post-processing emission - helps
      	with the artificial benchmark of replaying a recorded jhbuild script.
      
      	* src/vte-private.h:
      	* src/vte.c: (vte_terminal_finalize),
      	(vte_terminal_emit_icon_title_changed),
      	(vte_terminal_emit_window_title_changed),
      	(vte_terminal_emit_pending_signals):
      	* src/vteseq.c: (vte_sequence_handler_set_title_internal):
      
      
      svn path=/trunk/; revision=1615
      936abce0
    • Chris Wilson's avatar
      Broke clear-to-end-of-line by lowering the number of cells appended, · 69c2c22f
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Broke clear-to-end-of-line by lowering the number of cells appended,
      	instead of the number of cells invalidated.
      
      	* src/vte.c: (vte_terminal_draw_rows):
      	* src/vteseq.c: (vte_sequence_handler_ce):
      
      
      svn path=/trunk/; revision=1614
      69c2c22f
    • Chris Wilson's avatar
      Spelling corrections. · 0d4331ff
      Chris Wilson authored
      
      svn path=/trunk/; revision=1613
      0d4331ff
    • Chris Wilson's avatar
      cf Bug 83285 – Treacle-slow scrolling in gnome-terminal on unaccelerated · 2ddb7728
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	cf Bug 83285 – Treacle-slow scrolling in gnome-terminal on unaccelerated X server
      
      	Another chunk of performance improvements - the majority focussing on
      	reducing the amount of work down per interrupt (input data from
      	child).
      
      	To handle reads without addition copies VTE_INPUT_CHUNK_SIZE chunks
      	are allocated on demand and filled from read with no further copy -
      	previously the read was into a local buffer and then immediately
      	copied into a _vte_buffer.
      	_vte_iso2022_process() is then adjusted to use a ptr+length, rather
      	than a _vte_buffer and is called for every input chunk (taking special
      	care over the boundary cases).
      
      	* src/interpret.c: (main):
      	* src/iso2022.c: (_vte_iso2022_fragment_input),
      	(process_8_bit_sequence), (process_cdata), (_vte_iso2022_process):
      	* src/iso2022.h:
      	* src/vte-private.h:
      	* src/vte.c: (get_chunk), (release_chunk), (prune_chunks),
      	(_vte_incoming_chunks_release), (_vte_incoming_chunks_length),
      	(_vte_incoming_chunks_count), (_vte_incoming_chunks_reverse),
      	(vte_terminal_match_check_internal), (_vte_terminal_ensure_cursor),
      	(vte_terminal_set_colors), (_vte_terminal_insert_char),
      	(vte_terminal_catch_child_exited), (vte_terminal_eof),
      	(vte_terminal_process_incoming), (_vte_terminal_feed_chunks),
      	(vte_terminal_io_read), (vte_terminal_feed), (vte_terminal_send),
      	(vte_terminal_init), (vte_terminal_finalize), (vte_terminal_reset),
      	(remove_from_active_list), (need_processing), (update_regions),
      	(update_repeat_timeout):
      	* src/vte.h:
      	* src/vteseq.c: (vte_sequence_handler_cb),
      	(vte_sequence_handler_ce), (vte_sequence_handler_ec):
      
      
      
      svn path=/trunk/; revision=1612
      2ddb7728
    • Chris Wilson's avatar
      Store whether the codeset is ambiguous in a state variable, rather than · d5defbed
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Store whether the codeset is ambiguous in a state variable,
      	rather than every processing loop.
      
      	* src/iso2022.c: (_vte_iso2022_is_ambiguous),
      	(_vte_iso2022_state_new), (_vte_iso2022_find_nextctl):
      
      
      svn path=/trunk/; revision=1611
      d5defbed
    • Chris Wilson's avatar
      Remove zero-initialisers after g_slice_new0(). Print out the width range. · 5e903c99
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* src/vtexft.c: (_vte_xft_create), (_vte_xft_destroy):
      		Remove zero-initialisers after g_slice_new0().
      	* src/vtexft.c :(_vte_xft_set_text_font):
      		Print out the width range.
      
      
      svn path=/trunk/; revision=1610
      5e903c99
    • Chris Wilson's avatar
      Missing space between -Wflags. · 8099a629
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* configure.in:
      		Missing space between -Wflags.
      
      
      svn path=/trunk/; revision=1609
      8099a629
    • Chris Wilson's avatar
      Eliminate the temporary g_sliced parameter list, in favour of on-stack · 2bb339aa
      Chris Wilson authored
      2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Eliminate the temporary g_sliced parameter list,
      	in favour of on-stack list.
      
      	* src/table.c: (_vte_table_arginfo_head_init),
      	(_vte_table_arginfo_alloc), (_vte_table_arginfo_head_revert),
      	(_vte_table_arginfo_head_reverse),
      	(_vte_table_arginfo_head_finalize), (_vte_table_addi),
      	(_vte_table_matchi), (_vte_table_extract_string),
      	(_vte_table_match):
      
      
      svn path=/trunk/; revision=1608
      2bb339aa
  3. 02 Feb, 2007 3 commits
  4. 01 Feb, 2007 5 commits
    • Chris Wilson's avatar
      cf Bug 403275 – crash in Terminal: I was typing reset on th... · 1d2b8bf1
      Chris Wilson authored
      2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	cf Bug 403275 – crash in Terminal: I was typing reset on th...
      
      	Not the crash, just a freeze found whilst trying to reproduce the
      	bug on trunk.
      
      	* src/vte.c: (remove_from_active_list):
      		Don't remove the terminal from the active list if it still
      		has pending redraws.
      	
      	* src/vte.c: (process_timeout), (update_timeout):
      		Reorder the loop to remove the terminal from the active list
      		if it no longer needs processing.
      
      
      svn path=/trunk/; revision=1604
      1d2b8bf1
    • Chris Wilson's avatar
      Extract the bits the test needs out of debian.vim. · 40584615
      Chris Wilson authored
      2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	* perf/scroll.vim:
      		Extract the bits the test needs out of debian.vim.
      
      
      svn path=/trunk/; revision=1603
      40584615
    • Chris Wilson's avatar
      As spotted on bug 399617c8, we convert an array of unichars to a string · c83dd80e
      Chris Wilson authored
      2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	As spotted on bug 399617c8, we convert an array of unichars to a
      	string and then iterate over the string interpreting bytes as
      	unichars.
      
      	* src/table.c: (_vte_table_extract_numbers):
      		Dispense with the temporary string and process the unichar
      		array directly.
      
      
      svn path=/trunk/; revision=1602
      c83dd80e
    • Chris Wilson's avatar
      Bug 403159 – XftDrawSetClipRectangles() silently fails on ppc->i386 · 5e11ab51
      Chris Wilson authored
      2007-02-01  Chris Wilson <chris@chris-wilson.co.uk>
      
      	Bug 403159 – XftDrawSetClipRectangles() silently fails on ppc->i386
      
      	* src/vtexft.c: (_vte_xft_clip):
      		Precompute clip offsets.
      
      
      svn path=/trunk/; revision=1601
      5e11ab51
    • Chris Wilson's avatar
      Bug 382245 – __PyGtk_API multiply defined in python module · 31b9530f
      Chris Wilson authored
      2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 382245 – __PyGtk_API multiply defined in python module
      
      	* configure.in:
      		Add -fno-common to MAYBE_WARN in order to catch future
      		errors of this type.
      	* python/vte.override:
      		Define PYGTK_NO_IMPORT.
      
      
      svn path=/trunk/; revision=1600
      31b9530f
  5. 31 Jan, 2007 9 commits
    • Chris Wilson's avatar
      Bug 155687 – Scroll region \E[NN;MMr should set cursor to home · 086175a7
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 155687 – Scroll region \E[NN;MMr should set cursor to home
      
      	Patch originally by Michele Baldessari.
      
      	* src/vteseq.c: (vte_sequence_handler_cs):
      		Move the cursor to (0,0) rather than clamping the cursor to 
      		be inside the scroll region.
      
      
      svn path=/trunk/; revision=1599
      086175a7
    • Chris Wilson's avatar
      In a few places the contents of a GValue were being used without checking · f66bd6eb
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	In a few places the contents of a GValue were being used without
      	checking that they were of the expected type.
      
      	cf Bug 117945 which mentions stack corruption inside
      	vte_sequence_handler_delete_lines() - one of the corrected instances.
      
      	* src/vteseq.c: (vte_sequence_handler_al),
      	(vte_sequence_handler_cs), (vte_sequence_handler_cS),
      	(vte_sequence_handler_dl),
      	(vte_sequence_handler_character_attributes),
      	(vte_sequence_handler_insert_lines),
      	(vte_sequence_handler_delete_lines),
      	(vte_sequence_handler_device_status_report),
      	(vte_sequence_handler_dec_device_status_report):
      		Check that the GValue holds a long before dereference.
      
      
      svn path=/trunk/; revision=1598
      f66bd6eb
    • Chris Wilson's avatar
      Back to the old-style io loop as _vte_buffer_append() is too slow - on a · 469132e1
      Chris Wilson authored
      2007-01-31  Chris Wilson <chris@chris-wilson.co.uk>
      
      	Back to the old-style io loop as _vte_buffer_append() is too slow - on
      	a slow system the read can fill before the data is copied (even more
      	apparent under valgrind).
      
      	* src/vte-private.h:
      	* src/vte.c: (vte_terminal_io_read):
      
      
      svn path=/trunk/; revision=1597
      469132e1
    • Chris Wilson's avatar
      Use the display stashed inside the font and not the default display! · edcf1929
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Use the display stashed inside the font and not the default display!
      
      	* src/vtexft.c: (_vte_xft_char_exists), (_vte_xft_text_extents),
      	(_vte_xft_font_open), (_vte_xft_font_close),
      	(_vte_xft_font_for_char), (_vte_xft_draw_text):
      
      
      svn path=/trunk/; revision=1596
      edcf1929
    • Chris Wilson's avatar
      A mixed bag of cleanups. · e382c37e
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	A mixed bag of cleanups.
      
      	* configure.in:
      	* src/pty.c: (_vte_pty_set_utf8):
      		Test for existence of tc[sg]etattr.
      	* src/vte-private.h:
      	* src/vte.c: (vte_terminal_emit_adjustment_changed),
      	(vte_terminal_queue_adjustment_changed),
      	(vte_terminal_set_color_internal), (vte_terminal_handle_sequence),
      	(_vte_terminal_enable_input_source), (vte_terminal_io_read),
      	(vte_terminal_init), (vte_terminal_unrealize),
      	(vte_terminal_finalize), (vte_terminal_background_update),
      	(vte_terminal_queue_background_update),
      	(vte_terminal_emit_pending_signals), (process_timeout),
      	(update_repeat_timeout), (update_timeout):
      		Move idle signal emission to display handlers.
      	* src/vtedraw.h:
      		Add '&' to the single width characters.
      	* src/vteseq.c: (_vte_sequence_get_handler):
      	* src/vteseq.h:
      		Drop the extraneous GQuark parameter.
      	* src/vtexft.c: (_vte_xft_set_text_font):
      		Avoid use of strlen for a compile-time fixed length string.
      
      
      svn path=/trunk/; revision=1595
      e382c37e
    • Chris Wilson's avatar
      Dropped a most important '!' during last merge. · 7134bd1f
      Chris Wilson authored
      
      svn path=/trunk/; revision=1594
      7134bd1f
    • Chris Wilson's avatar
      Bug 147784 – cursor unvisible under mouse highlight · c9280a87
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 147784 – cursor unvisible under mouse highlight
      
      	Original patch by Chris Health
      
      	* src/vte.c: (vte_terminal_paint):
      		Reverse cursor color if it is in the selected region and draw
      		it as an outline.
      
      
      svn path=/trunk/; revision=1593
      c9280a87
    • Chris Wilson's avatar
      Bug 368894 – crash in Terminal: I started gnome-terminal... · dfd5c7d7
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Bug 368894 – crash in Terminal: I started gnome-terminal...
      
      	* src/vtebg.c: (vte_bg_cache_search), (vte_bg_get_pixmap),
      	(vte_bg_get_pixbuf):
      		When retrieving a cached pixmap check that the visual
      		matches the current request.
      
      
      svn path=/trunk/; revision=1592
      dfd5c7d7
    • Chris Wilson's avatar
      Use gdk_error_trap_{push,pop} around raw Xft calls - about a path outside · ccf4b847
      Chris Wilson authored
      2007-01-31  Chris Wilson  <chris@chris-wilson.co.uk>
      
      	Use gdk_error_trap_{push,pop} around raw Xft calls - about a
      	path outside of vte_draw_{begin,end}.
      
      	* src/vtexft.c: (_vte_xft_set_text_font):
      
      
      svn path=/trunk/; revision=1591
      ccf4b847