vte_terminal_spawn_async doesn't accept NULL callback since 0.62
The callback
parameter to vte_terminal_spawn_async()
is implicitly documented to be nullable ("or %NULL
"), and mssh
apparently relies on this: it passes a NULL
callback
parameter, so it isn't notified when the pty setup succeeds or fails.
However, when this function was converted into a wrapper around +vte_terminal_spawn_with_fds_async()
in af649664, it gained g_return_if_fail(callback)
. We've had reports in Debian that mssh
is an example of a program that no longer works as a result.
I've recommended that mssh
should work around this by adding a non-NULL
callback, so that it can at least spam stderr if the pty setup fails, even if it doesn't have any better way to handle errors.
It looks as though spawn_async_cb()
copes gracefully with data->callback
being NULL
, so I think removing g_return_if_fail(callback)
would resolve this, making the implementation consistent with the documentation.