vte_pty_spawn_finish no longer decorated as _VTE_PUBLIC, causing an ABI break
While updating vte in Debian from 0.60.x to 0.61.91, our symbols-tracking tools told me that vte_pty_spawn_finish
had disappeared from the ABI (an ABI break). It looks as though this was done accidentally in af649664.
If this was indeed unintentional, I think the solution is to put the _VTE_PUBLIC
back on, in both vte-0-62
and master
:
From eec1144f7872c5c71940dbd5f3091b73b9f0be0c Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Thu, 3 Sep 2020 10:13:05 +0100
Subject: [PATCH] Export vte_pty_spawn_finish again
This was accidentally unexported in af649664, breaking the ABI.
Signed-off-by: Simon McVittie <smcv@debian.org>
---
src/vte/vtepty.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vte/vtepty.h b/src/vte/vtepty.h
index 875119b7..5d1fb38f 100644
--- a/src/vte/vtepty.h
+++ b/src/vte/vtepty.h
@@ -127,6 +127,7 @@ void vte_pty_spawn_with_fds_async(VtePty *pty,
GAsyncReadyCallback callback,
gpointer user_data) _VTE_CXX_NOEXCEPT _VTE_GNUC_NONNULL(1) _VTE_GNUC_NONNULL(3);
+_VTE_PUBLIC
gboolean vte_pty_spawn_finish(VtePty *pty,
GAsyncResult *result,
GPid *child_pid /* out */,
--
2.28.0
Edited by Simon McVittie