Commit caf8a6a7 authored by Christian Persch's avatar Christian Persch
Browse files

widget: Limit select-all to the writable region not including the scrollback

Including the scrollback in select-all makes it too easy to select so much
data that putting it on the clipboard either hangs the process for a long time
or causes a crash (gnome-terminal#288).

Fixes: gnome-terminal#288
parent d4e0d89c
......@@ -6672,7 +6672,10 @@ Terminal::maybe_end_selection()
/*
* Terminal::select_all:
*
* Selects all text within the terminal (including the scrollback buffer).
* Selects all text within the terminal. Note that we only select the writable
* region, *not* the scrollback buffer, due to this potentially selecting so
* much data that putting it on the clipboard either hangs the process for a long
* time or even crash it directly. (FIXME!)
*/
void
Terminal::select_all()
......@@ -6681,8 +6684,8 @@ Terminal::select_all()
m_selecting_had_delta = TRUE;
m_selection_resolved.set ({ _vte_ring_delta (m_screen->row_data), 0 },
{ _vte_ring_next (m_screen->row_data), 0 });
m_selection_resolved.set({m_screen->insert_delta, 0},
{_vte_ring_next(m_screen->row_data), 0});
_vte_debug_print(VTE_DEBUG_SELECTION, "Selecting *all* text.\n");
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment