Commit 431ecb67 authored by Chris Wilson's avatar Chris Wilson Committed by Chris Wilson
Browse files

Bug 480735 – Underlining whitespace not reliable

2007-09-26  Chris Wilson  <chris@chris-wilson.co.uk>

    Bug 480735 – Underlining whitespace not reliable

    Original one-liner by Steven Skovran.

    * src/vte.c (vte_terminal_draw_rows):
        Do not try to over zealously skip whitespace. The goal is
        to maintain the current run whilst avoiding adding spaces to
        the glyph sequence - so check the cell fully for attribute
        breaks and simply do not add it to the glyphs if it contains a
        space.


svn path=/trunk/; revision=1953
parent eafd1b6d
2007-09-26 Chris Wilson <chris@chris-wilson.co.uk>
Bug 480735 Underlining whitespace not reliable
Original one-liner by Steven Skovran.
* src/vte.c (vte_terminal_draw_rows):
Do not try to over zealously skip whitespace. The goal is
to maintain the current run whilst avoiding adding spaces to
the glyph sequence - so check the cell fully for attribute
breaks and simply do not add it to the glyphs if it contains a
space.
2007-09-17 Behdad Esfahbod <behdad@gnome.org>
Released vte-0.16.9.
......
......@@ -9578,7 +9578,7 @@ vte_terminal_draw_rows(VteTerminal *terminal,
j++;
continue;
}
if (cell->c == 0 || cell->c == ' '){
if (cell->c == 0){
/* only break the run if we
* are drawing attributes
*/
......@@ -9645,13 +9645,16 @@ vte_terminal_draw_rows(VteTerminal *terminal,
if (nhilite != hilite) {
break;
}
/* Add this cell to the draw list. */
items[item_count].c = cell->c;
items[item_count].columns = cell->attr.columns;
items[item_count].x = start_x + j * column_width;
items[item_count].y = y;
j += items[item_count].columns;
item_count++;
if (cell->c != ' ') {
/* Add this cell to the draw list. */
items[item_count].c = cell->c;
items[item_count].columns = cell->attr.columns;
items[item_count].x = start_x + j * column_width;
items[item_count].y = y;
j += items[item_count].columns;
item_count++;
} else
j++;
}
/* have we encountered a state change? */
if (j < end_column) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment