ChangeLog 340 KB
Newer Older
1
2
3
4
5
6
7
2007-06-25  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 448259  Mapping for Ctrl-_
	Patch by Andrey Melnikov.

	* src/keymap.c: Add mapping for Ctrl-Minus.

8
9
10
11
12
13
14
2007-06-25  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 449809  use python-config to get python includes
	Patch by Sebastien Bacher.

	* acinclude.m4: prefer python-config where available.

15
16
17
18
19
20
21
22
2007-06-25  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 450745  VTE's response to CSI 2 1 t incorrectly formatted
	Patch by Dale Sedivec.

	* src/vteseq.c (vte_sequence_handler_window_manipulation): Restore
	the missing 'L'.

23
24
25
26
27
28
2007-06-21  Christian Persch  <chpe@gnome.org>

	* configure.in:
	* src/Makefile.am: Move libtool versioning to configure so you just
	have to update one file for releasing. See bug #396265 comment 17.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
29
30
31
32
33
34
35
36
37
38
2007-06-18  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.6.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.6.

	* src/Makefile.am: Bumped libtool version to 11:10:2.

39
40
41
42
43
2007-06-12  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_set_size): Call gtk_widget_queue_resize()
	after updating row/column count.

44
45
46
47
48
49
2007-06-11  Behdad Esfahbod  <behdad@gnome.org>

	Bug 372743 – vte_terminal_set_colors doesn't work as advertised

	* src/vte.c (vte_terminal_set_colors): Allow 24-color palettes.

50
51
52
53
54
55
56
57
2007-06-09  Behdad Esfahbod  <behdad@gnome.org>

	Bug 445620  Some characters shows different in different locales.
	Patch from Zealot

	* src/iso2022.c (_vte_iso2022_state_set_codeset): Update ambiguous
	width.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
58
59
60
61
62
63
64
65
66
67
2007-06-04  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.5.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.5.

	* src/Makefile.am: Bumped libtool version to 11:9:2.

68
69
70
71
72
2007-05-30  Chris Wilson  <chris@chris-wilson.co.uk>

	fcrozat pointed out 'some strange "underline" line where cursor is
	located and blinking'.

73
74
	Also reported in bug 442688.

75
76
77
78
79
80
	* src/vte.c (vte_terminal_draw_rows):
	    Continuation of the previous commit: catch a couple more locations
	    where we need to skip past the end of the line. The problem in
	    this case was we tried to use some uninitialised variables whilst
	    trying to draw the cell attributes.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
81
82
83
84
85
86
87
88
89
90
2007-05-28  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.4.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.4.

	* src/Makefile.am: Bumped libtool version to 11:8:2.

91
92
93
94
95
96
97
98
2007-05-28  Chris Wilson  <chris@chris-wilson.co.uk>

	uws noted on IRC that 'vte trunk does strange thingies with colors'

	* src/vte.c (vte_terminal_draw_rows):
	    When reaching the end-of-row be careful not to reset the
	    current text attributes (color, underlining, etc).

99
100
101
102
103
104
2007-05-25  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_expand_region),
	(vte_terminal_paint_area):
	    Only add the borders to the clear area.

105
106
107
108
109
110
2007-05-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 429278  Cursor drawn strangely in joe

	* src/vte.c (vte_terminal_expand_region),
	(vte_terminal_paint_area):
111
	    Ensure the expanded regions are cell aligned.
112

113
114
115
116
2007-05-23  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 439247  scrolling vim in full screen is painfully slow and takes up 100% of the cpu

Chris Wilson's avatar
Chris Wilson committed
117
	* src/vte.c (vte_terminal_draw_rows):
118
119
	    Fix up the unwanted break of Glyph runs at the end-of-lines.

120
121
122
123
124
125
126
127
128
2007-05-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 440475  Display glitch with transparent backgroud

	* src/vte.c (vte_terminal_paint_area):
	    Apply the band-aid fix to clear the area that's about to be
	    repainted. The full solution will to be ensure that the regions
	    after expansion are cell-aligned.

129
130
131
132
133
134
2007-05-22  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 375112 – ctrl-key combinations yielding just key
	Original patch by <samo@altern.org> and refactored by Loïc Minier.

	* src/vte.c (vte_translate_national_ctrlkeys),
Chris Wilson's avatar
Chris Wilson committed
135
136
	(vte_terminal_key_press):
	    When cooking a string to pass through to the client obtain the
137
138
	    "raw" keyval.

139
140
141
142
143
144
145
146
147
148
2007-05-22  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 440377 – gnome-terminal cannot refresh terminal when accessibility enabled
	Original patch by Li Yuan.

	* src/vteaccess.c (vte_terminal_accessible_focus_in),
	(vte_terminal_accessible_focus_out),
	(vte_terminal_accessible_visibility_notify):
	    Return FALSE rather than void...

149
150
151
152
153
154
2007-05-17  Chris Wilson  <chris@chris-wilson.co.uk>

	* perf/scroll.vim:
	* perf/vim.sh:
	    Measure full screen scrolling performance.

155
156
157
158
159
160
161
162
163
2007-05-15  Chris Wilson  <chris@chris-wilson.co.uk>

	kmaraas reported an issue on IRC where the scrollback was not being
	updated correctly in the first tab when the terminal was resized via
	a second tab.

	* src/vte.c (vte_terminal_size_allocate): Check whether we need to
	recompute the visible lines due to a change in layout geometry.

164
165
166
167
168
169
170
171
172
2007-04-27  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 433776 – gnome-terminal crashes when open preedit area
	Take 2.

	* src/vte.c (vte_terminal_paint): The preedit_cursor is returned by
	the input modules in characters not in bytes as assumed by the
	validation.

173
174
175
176
177
178
2007-04-27  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 433776 – gnome-terminal crashes when open preedit area

	* src/vte.c (vte_terminal_paint): Use the validated cursor index.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
179
180
181
182
183
184
185
186
187
188
2007-04-27  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.3.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.3.

	* src/Makefile.am: Bumped libtool version to 11:7:2.

Chris Wilson's avatar
Chris Wilson committed
189
190
191
192
193
194
195
2007-04-24  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 429189 – Vte-WARNING's

	* src/vtexft.c (_vte_xft_open_font_for_char):
		Convert the warning into a DEBUG.

196
197
2007-04-24  Chris Wilson  <chris@chris-wilson.co.uk>

198
199
	Bug 415044  Use --enable-debug rather than --enable-debugging

200
201
202
203
204
205
	As noted on Bug 414716, the convention is to use --enable-debug
	to enable extra debugging code.

	* configure.in:
		s/debugging/debug/

206
207
208
209
210
211
212
2007-04-24  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 414716  Refresh issue after changing workspaces

	* src/vte.c (vte_terminal_hierarchy_changed):
		Do not respond to toplevel mapping events.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
213
214
215
216
217
218
219
220
221
222
2007-04-23  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.2.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.2.

	* src/Makefile.am: Bumped libtool version to 11:6:2.

223
224
225
226
227
228
229
230
231
232
233
2007-04-23  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 431799  Regex highlighting is broken

	* src/vte.c (vte_terminal_emit_contents_changed),
	(vte_terminal_match_hilite_update), (process_timeout),
	(update_repeat_timeout), (update_timeout):
		Always emit any pending updates before redrawing. This
		ensures for example that the match contents are updated
		after a simple scroll event.

234
235
236
237
238
239
2007-04-20  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vtexft.c (_vte_xft_start), (_vte_xft_clip):
		Optimise away the use of a clip mask for the common case
		of redrawing the whole terminal.

240
241
242
243
244
245
2007-04-17  Behdad Esfahbod  <behdad@gnome.org>

	* src/iso2022.c (_vte_iso2022_ambiguous_width): Consider
	ambiguous-width chars if VTE_CJK_WIDTH env var is set and we are
	under a CJK locale.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
246
247
248
249
250
251
252
253
254
255
2007-03-12  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.1.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.1.

	* src/Makefile.am: Bumped libtool version to 11:5:2.

256
257
258
259
260
261
2007-04-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 426870  vte often passes NUL to functions requiring valid unichar

	* src/vte.c (_vte_invalidate_cell), (_vte_invalidate_cursor_once),
	(vte_terminal_paint):
Chris Wilson's avatar
Chris Wilson committed
262
		Consistently guard against cell->c == '\0' before calling
263
264
		_vte_draw_get_char_width.

265
266
267
268
269
270
271
272
273
2007-04-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 419644  Links do not get highlighted anymore
	Also see Bug 404757  URL matching doesn't work with PCRE

	* configure.in:
		Kill --with-pcre as it changes the semantics of the API
		and only causes confusion.

274
275
276
277
278
279
280
281
282
283
284
285
286
2007-04-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 426541 – crash on IRM escape code

	* src/vte.c (vte_terminal_ensure_cursor),
	(_vte_terminal_insert_char):
		Mishandled insertion - we always extended the row for
		inserts even though the row would automagically extend
		for the inserted cells. This lead to referencing
		uninitialised cells at the end of the row during painting.
	* src/vte.c (vte_terminal_draw_rows):
		Retrieve the cell before inspecting it.

287
288
289
290
291
292
293
2007-04-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 424184 – Make scroll wheel send Page Up/Down when it makes sense

	Original patch by Shaun McCance and refined by Baris Cicek.

	* src/vte.c (vte_terminal_scroll):
294
295
		Send cursor keypress instead of trying to scroll the
		alternate screen in vain.
296

297
298
299
300
301
302
303
304
305
2007-04-03  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 425767 – vte_terminal_set_color_highlight should test for
	NULL before _vte_debug_print

	* src/vte.c (vte_terminal_set_color_cursor),
	(vte_terminal_set_color_highlight):
		Differentiate between set/unset paths.

306
307
308
309
310
311
312
313
314
315
2007-03-25  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 422385 – vte appears at the top of the root window even when
	packed at the bottom of it

	Patch by Dodji Seketeli.

	* src/vte.c (vte_terminal_size_allocate), (vte_terminal_realize):
		Honour the allocated position when realizing the widget.

316
317
318
319
320
321
2007-03-22  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vtexft.c (_vte_xft_draw_text):
		Insert spaces into the Xft glyph stream to avoid the
		overhead of restarting a glyph sequence for every word.

322
323
324
325
326
327
328
329
2007-03-21  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 420935 – glyph can be cropped with not fitting in a cell

	* src/vte.c (vte_terminal_paint):
		Don't redraw the invisible cursor 
		- avoids nasty artifacts like clipping extra wide glyphs.

330
331
332
333
334
2007-03-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_scroll_pages):
		Leave 'contents-change' to the scroll handler.

335
336
337
338
339
340
341
2007-03-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_extend_selection),
	(vte_terminal_draw_rows):
		Accidentally inverted an is-empty? check during the 
		elimination of the empty bitfield.

342
343
344
345
346
347
348
349
350
2007-03-19  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 420067  Does not handle expose events whilst processing
	unseen incoming data

	* src/vte.c (vte_terminal_expose):
		Handle the expose immediately if we are only processing
		incoming data (ie no redraws pending).

351
352
353
354
355
356
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vteseq.c (vte_sequence_handler_cursor_character_absolute):
		Remove a chunk of code that was tried as a mutt band-aid
		long ago and was completely wrong.

357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 415381  Improve performance of vte_terminal_insert_char()

	The bulk of the work to remove redundant reads and conditionals
	from the code. In particular, gcc was emitting bit-by-bit copies
	for transferring the bitfield since we modified a member immediately
	afterwards - overcome this by using an explicit memcpy of the
	bitfields.

	* src/vte-private.h:
	* src/vte.c (vte_g_array_fill), (vte_terminal_ensure_cursor),
	(_vte_terminal_insert_char), (vte_terminal_process_incoming),
	(vte_terminal_send):
	* src/vteseq.c (vte_sequence_handler_ic):

373
374
375
376
377
378
379
380
381
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 415381  Improve performance of vte_terminal_insert_char()

	* src/vte-private.h: Use a simple boolean rather than counter for
	text changed style flags.
	* src/vte.c: And update users.
	* src/vteseq.c:

382
383
384
385
386
387
388
389
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 415381  Improve performance of vte_terminal_insert_char()

	* src/vte-private.h: Embed bitfield into struct
	* src/vte.c:  And update users.
	* src/vteseq.c:

390
391
392
393
394
395
396
397
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Need to trigger update timeout rather than process timeout
	otherwise the background is not updated.

	* src/vte.c (vte_terminal_queue_adjustment_changed),
	(vte_terminal_queue_adjustment_value_changed):

Chris Wilson's avatar
Chris Wilson committed
398
399
400
401
402
403
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vtexft.c (_vte_xft_create), (_vte_xft_destroy),
	(_vte_xft_start), (_vte_xft_end), (_vte_xft_clip),
	(_vte_xft_clear): Avoid some allocations.

404
405
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
	Bug 418073  Opacity ignored for vtexft

	* src/vte.c:
	* src/vtedraw.c (_vte_draw_requires_clear):
	* src/vtedraw.h:
	* src/vteft2.c (_vte_ft2_set_background_image):
	* src/vtegl.c (_vte_gl_create), (_vte_gl_set_background_image):
	* src/vtepango.c (_vte_pango_set_background_image):
	* src/vtepangox.c (_vte_pango_x_set_background_image):
	* src/vtexft.c (_vte_xft_set_background_color),
	(_vte_xft_set_background_image):
		Flood fill the backing pixmap if we need to change it's
		opacity as well.

2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 418910 – Asymmetric scrolling with mouse wheel

424
425
426
427
	* configure.in:
	* src/vte.c: Round-up the delta before applying to ensure consistency
	between up and down.

Chris Wilson's avatar
Chris Wilson committed
428
429
430
431
432
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_catch_child_exited), (vte_terminal_eof),
	(vte_terminal_process_incoming): Refactor some common code.

433
434
435
436
437
438
439
440
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 416634 – Rendering glitch as autowrapped chars are outside invalidated bbox

	* src/vte.c (_vte_terminal_insert_char),
	(vte_terminal_process_incoming): Correctly update bbox after
	autowrapping.

441
442
443
444
445
446
447
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 416635 – Rendering glitch: double draw of line below exposed region

	* src/vte.c (vte_terminal_expand_region),
	(vte_terminal_paint_area): Kill a couple of off-by-ones.

448
449
450
451
452
453
454
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 418588 – Invalid read when drawing preedit cursor

	* src/vte.c (vte_terminal_paint):
		No need to read what is drawn and furthermore isn't allocated.

455
456
457
458
459
460
461
462
463
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 417652  Scrolling bug exposed by nvi

	* src/vte.c (vte_terminal_insert_rows), (_vte_terminal_ensure_row),
	(vte_terminal_ensure_cursor), (_vte_terminal_update_insert_delta):
		Ensure the rows before updating the insert delta and refactor
		the common code.

464
465
466
467
468
469
470
2007-03-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 417301  Terminal widgets don't respond to DPI changes

	* src/vte.c (vte_terminal_fc_settings_changed): Force a font reload
	after XFT settings have changed.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
471
472
473
474
475
476
477
478
479
480
2007-03-12  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.16.0.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.16.0.

	* src/Makefile.am: Bumped libtool version to 11:4:2.

481
482
483
484
485
2007-03-06  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vteseq.c (vte_sequence_handler_cm), (vte_sequence_handler_sf):
		More work to match mutt's behaviour under xterm.

486
487
488
489
490
491
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_io_read):
		Use the process estimate to load balance between multiple
		active terminals.

492
493
494
495
496
497
498
499
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vteseq.c (vte_sequence_handler_cm),
	(vte_sequence_handler_dc), (vte_sequence_handler_sf),
	(vte_sequence_handler_cursor_character_absolute):
		Tweak the fill of painted cells to match mutt's behaviour
		under xterm.

500
501
502
503
504
505
506
507
508
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 414716 – gnome-terminal-2.17.92: terminal window dies...

	* src/vte.c (vte_terminal_map_toplevel),
	(vte_terminal_hierarchy_changed):
		Force the visibility state to unobscured after the toplevel is
		remapped.

509
510
511
512
513
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_size_allocate):
		Note to self: Never try to optimize away the redraw.

514
515
516
517
518
519
520
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (_vte_terminal_insert_char):
	* src/vtedraw.c (_vte_draw_text), (_vte_draw_char),
	(_vte_draw_fill_rectangle), (_vte_draw_draw_rectangle):
		Touch up whitespace in debug output.

521
522
523
524
525
526
527
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (_vte_invalidate_cells), (vte_terminal_set_visibility),
	(vte_terminal_paint_area), (vte_terminal_expose):
		Make sure the invalidated_all flag is cleared in the expose
		event if we handle it immediately.

528
529
530
531
532
533
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vteseq.c (vte_sequence_handler_ce),
	(vte_sequence_handler_clear_current_line):
		Fixup invalidation to end-of-line.

534
535
536
537
538
539
540
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 414586 – Terminal screen blinks when menu is opened for the first time

	* src/vte.c (vte_terminal_draw_rows), (vte_terminal_expand_region):
		Include the window padding when painting the cell backgrounds.

541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 414586 – Terminal screen blinks when menu is opened for the first time

	Avoid resetting the window background colour when the style is reset.
	Avoid clearing the window if we are using a simple color and double
	bufferring (i.e when we know we are using a pre-cleared pixmap).

	* src/vte-private.h:
	* src/vte.c (vte_terminal_init), (vte_terminal_size_allocate),
	(vte_terminal_unrealize), (vte_terminal_realize),
	(vte_terminal_paint_area), (vte_terminal_expose),
	(vte_terminal_class_init), (vte_terminal_background_update):
	* src/vtedraw.c (_vte_draw_has_background_image):
	* src/vtedraw.h:
	* src/vteft2.c (_vte_ft2_set_background_image):
	* src/vtegl.c (_vte_gl_set_background_image):
	* src/vtepango.c (_vte_pango_set_background_image):
	* src/vtepangox.c (_vte_pango_x_set_background_image):
	* src/vtexft.c (_vte_xft_set_background_image):

562
563
564
565
566
567
568
569
570
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 414586 – Terminal screen blinks when menu is opened for the first time

	* src/vte.c (_vte_invalidate_cells), (_vte_invalidate_all),
	(vte_terminal_expose), (add_update_timeout):
		Juggle the handling of external exposes/invalidates to avoid
		delays in refreshing the display when we are idle.

571
572
573
574
575
576
577
578
579
2007-03-05  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 414586 – Terminal screen blinks when menu is opened for the first time

	* src/vte.c (_vte_invalidate_cells), (vte_terminal_init),
	(vte_terminal_expand_region), (vte_terminal_paint_area):
		After enlarging the expand region make sure the dirty area
		includes the border for edge cells.

580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
2007-03-04  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 414586 – Terminal screen blinks when menu is opened for the first time

	Distinguish between internal update requests and external. If we
	need to update due to a user action (such as adjusting the background
	or color palette) do not impose a futher delay.

	Tidy the color palette modification code to not trigger invalidates if
	we do not actually modify the palette.

	* src/vte-private.h:
	* src/vte.c (vte_terminal_set_color_internal),
	(vte_terminal_set_color_bold), (vte_terminal_set_color_dim),
	(vte_terminal_set_color_foreground),
	(vte_terminal_set_color_background),
	(vte_terminal_set_color_cursor),
	(vte_terminal_set_color_highlight), (vte_terminal_set_colors),
	(root_pixmap_changed_cb), (vte_terminal_set_background_saturation),
	(vte_terminal_set_background_tint_color), (add_update_timeout):
	* src/vteseq.c (vte_sequence_handler_ce),
	(vte_sequence_handler_clear_current_line),
	(vte_sequence_handler_clear_above_current):

604
605
606
607
608
609
610
611
612
613
2007-03-02  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413068 – new line added to tab when opened

	* src/vte.c (vte_terminal_size_allocate):
		Replace the ill-conceived attempt (delta could not be
		negative, so insert_delta or scroll_delta would not become
		negative either) by only considering changes wrt to the number
		of visible lines.

614
615
616
617
618
619
620
621
622
623
2007-03-02  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413068 – new line added to tab when opened

	* src/vte.c (_vte_terminal_insert_char):
		Improve debug output.
	* src/vte.c (vte_terminal_size_allocate):
		Be careful that we don't force insert_delta or scroll_delta
		to become negative.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
624
625
626
627
628
629
630
631
632
633
2007-03-01  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.15.6.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.15.6.

	* src/Makefile.am: Bumped libtool version to 11:3:2.

634
635
636
637
638
639
640
2007-03-01  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c (vte_terminal_draw_cells), (vte_terminal_draw_rows),
	(vte_terminal_paint):
		Tweak the clear widths to include the pixel widening due to
		psuedo-bold.

641
642
643
644
645
646
647
648
2007-03-01  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte-private.h:
	* src/vte.c (_vte_terminal_ensure_row),
	(vte_terminal_ensure_cursor), (_vte_terminal_insert_char):
	* src/vteseq.c (vte_sequence_handler_ta):
		Be more careful when filling in gaps.

649
650
651
652
653
654
655
656
657
2007-03-01  Chris Wilson  <chris@chris-wilson.co.uk>

	Fix X11 headers / libraries detection on bi-arch systems.
	Patch by Frederic Crozat.

	* configure.in:
		Check for x_includes before ac_x_includes, and similary for
		ac_x_libraries.

658
659
660
661
662
663
664
665
2007-03-01  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410534  Slow content scrolling, takes 100% of CPU.

	* src/vtexft.c:
		Further reduce the cap to 80 after more testing on the
		broken fglrx driver.

666
667
668
669
670
671
672
673
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413068  new line added to tab when opened

	* src/vte.c (vte_terminal_ensure_font), (vte_terminal_realize):
		Beware when no font is set before the first request...
		Make sure that at least the default font is set.

674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413262  Incorrectly coloured tabs

	* src/vte-private.h:
	* src/vte.c (vte_terminal_ensure_cursor),
	(_vte_terminal_ensure_cursor), (_vte_terminal_insert_char),
	(_vte_terminal_feed_chunks), (vte_terminal_set_scrollback_lines):
	* src/vteseq.c (vte_sequence_handler_ta),
	(vte_sequence_handler_request_terminal_parameters),
	(vte_sequence_handler_return_terminal_status),
	(vte_sequence_handler_send_primary_device_attributes):
		Fill the tab in the current color, else it will be filled at
		the time of writing the next character.

689
690
691
692
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413102  Incorrect highlighting in vim

Chris Wilson's avatar
Chris Wilson committed
693
694
	* src/vte-private.h:
	* src/vte.c (_vte_terminal_ensure_row),
695
	(_vte_terminal_insert_char):
Chris Wilson's avatar
Chris Wilson committed
696
	* src/vteseq.c(vte_sequence_handler_cb),
697
698
699
700
701
	(vte_sequence_handler_ce), (vte_sequence_handler_cr),
	(vte_sequence_handler_ec), (vte_sequence_handler_sf):
		Paint the row background when scrolling, this more closely
		matches xterm's behaviour.

Chris Wilson's avatar
Chris Wilson committed
702
703
704
705
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413158 – Cursor trails

Chris Wilson's avatar
Chris Wilson committed
706
	* src/vte.c (_vte_invalidate_cell):
Chris Wilson's avatar
Chris Wilson committed
707
708
709
		_vte_invalidate_cell() can be called to invalidate any visible
		cell so issue the invalidate even for blank cells.

710
711
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

Chris Wilson's avatar
Chris Wilson committed
712
	* src/vte.c (_vte_terminal_insert_char):
713
714
		Correct the OBO in the number of columns ensured.

715
716
717
718
719
720
721
722
723
724
725
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 413078 – Crash during opening a new tab whilst scrolling
	
	During input processing it was possible to both remove the timeout and
	then add a new one. The currently running timeout would believe that
	it was to continue since the terminal was still active, and so *two*
	timeouts would be scheduled. Occasionally the second timeout would be
	called after the first had finished all the work, resulting in the
	second timeout trying to access a NULL active_terminal list.

Chris Wilson's avatar
Chris Wilson committed
726
	* src/vte.c (add_update_timeout), (remove_from_active_list),
727
728
729
730
	(vte_terminal_add_process_timeout), (need_processing),
	(process_timeout), (update_repeat_timeout), (update_timeout):
		Watch for recursive g_source_remove() from within timeouts.

731
732
733
734
735
736
737
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410534 – Slow content scrolling, takes 100% of CPU.

	Submitting long glyph runs was causing a dramatic (10x) slow down
	in the fglrx xserver.

Chris Wilson's avatar
Chris Wilson committed
738
739
	* src/vtedraw.h:
	* src/vtexft.c(_vte_xft_draw_text):
740
741
		Cap the max glyph run length to 300.

742
743
744
745
2007-02-28  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 412717 – Crash when opening a new tab with window maximized

Chris Wilson's avatar
Chris Wilson committed
746
	* src/vte.c (vte_terminal_size_allocate):
747
748
749
		We didn't carefully check the values we were clamping the
		cursor to and ended up setting it to -1...  Don't do that!

750
751
2007-02-27  Chris Wilson  <chris@chris-wilson.co.uk>

Chris Wilson's avatar
Chris Wilson committed
752
	* src/vteaccess.c (vte_terminal_accessible_text_scrolled):
753
754
		Consistently guard against the snapshot being NULL.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
755
756
757
758
759
760
761
762
763
764
2007-02-27  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.15.5.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.15.5.

	* src/Makefile.am: Bumped libtool version to 11:2:2.

765
766
767
768
2007-02-27  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 412562 – Crash in vte_terminal_match_hilite_update

Chris Wilson's avatar
Chris Wilson committed
769
	* src/vte.c (vte_terminal_match_check_internal),
770
771
772
773
774
775
	(vte_terminal_process_incoming), (_vte_terminal_feed_chunks),
	(vte_terminal_paste_cb), (vte_terminal_match_hilite_update),
	(vte_terminal_copy_cb):
		Fixup a few 64bit-isms, notably format strings and an
		undesired unsigned integer promotion causing this crash.

776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
2007-02-27  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410986 – Fails to build with -z defs

	If you link the vtemodule.so to libpython, then programs importing
	vte will have the symbols twice in memory: one set from python and
	the other from libpython.

	* configure.in:
	* python/Makefile.am:
		Remove PYTHON_LIBS from linking vtemodule.so.
		Convert unresolved symbol errors into warnings so that
		building with -Wl,-z,defs continues to work. This is a 
		*hack* as it hides real errors if you are updating
		vte.{def,override}.
		
792
793
794
795
796
797
798
799
2007-02-27  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vtexft.c	(_vte_xft_open_font_for_char),
	(_vte_xft_font_for_char), (_vte_xft_compute_char_width),
	(_vte_xft_char_width), (_vte_xft_start), (_vte_xft_get_char_width),
	(_vte_xft_draw_text):
		Avoid some computations whilst drawing text.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
800
801
802
803
804
805
806
807
808
809
2007-02-26  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.15.4.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.15.4.

	* src/Makefile.am: Bumped libtool version to 11:1:2.

810
811
812
813
814
815
816
817
818
819
820
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410986 – Fails to build with -z defs

	The forgotten half - the python module also fails to link.

	* acinclude.m4:
	* python/Makefile.am:
		Add PYTHON_LIBS pointing to the customary location and
		remember to include them when compiling vtemodule.so.

821
822
823
824
825
826
827
828
829
830
831
832
833
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 412361 – Yet another mouse selection regression...
	Part 2.

	* src/vte.c: (vte_terminal_queue_adjustment_value_changed),
	(_vte_terminal_adjust_adjustments_full),
	(vte_terminal_scroll_pages), (vte_terminal_autoscroll),
	(vte_terminal_size_allocate), (vte_terminal_scroll):
		We implicitly used a bit of sanity checking when setting the
		adjustment value. Ensure the value really is within the
		adjustment range before updating scroll_delta.

834
835
836
837
838
839
840
841
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 412361 – Yet another mouse selection regression...
	Part 1.

	* src/vte.c: (vte_terminal_draw_rows):
		Restore drawing of the selection below the text.

842
843
844
845
846
847
848
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_class_init), (time_process_incoming),
	(process_timeout), (update_repeat_timeout), (update_timeout):
		Update max number of processable bytes each time we call
		vte_terminal_process_incoming().

Chris Wilson's avatar
Chris Wilson committed
849
850
851
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_emit_adjustment_changed),
852
	(_vte_terminal_adjust_adjustments_full):
Chris Wilson's avatar
Chris Wilson committed
853
854
		Refactor the common code.

855
856
857
858
859
860
861
862
863
864
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Push a couple of NULL checks to the callers so to be able to move them
	outside of the inner-most loops.

	* src/vte.c: (_vte_row_data_find_charcell), (_vte_invalidate_cell),
	(_vte_terminal_adjust_adjustments),
	(vte_terminal_get_text_range_maybe_wrapped), (find_start_column),
	(find_end_column), (vte_terminal_draw_rows):

865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Some applications, such as cat, dump as much data to the terminal as
	possible. In these scenarios it is likely that we will read data from
	the child much faster than we can process it and the refresh will
	stutter.

	The ideal solution would be to speed up the data processing so that
	this overrun was impossible. However, the approach taken here is to
	estimate how much data we can actually process in our time slice and
	to stop reading once we have sufficient data.

	* src/vte-private.h:
	* src/vte.c: (_vte_invalidate_all),
	(vte_terminal_emit_contents_changed),
	(vte_terminal_match_contents_clear),
	(vte_terminal_match_contents_refresh),
	(vte_terminal_emit_adjustment_changed),
	(_vte_terminal_adjust_adjustments), (vte_terminal_scroll_pages),
	(vte_terminal_catch_child_exited), (vte_terminal_eof),
	(vte_terminal_process_incoming), (vte_terminal_io_read),
	(vte_terminal_handle_scroll), (vte_terminal_init),
	(vte_terminal_size_allocate), (need_processing), (process_timeout),
	(update_repeat_timeout), (update_timeout):
	* src/vteseq.c: (vte_sequence_handler_decset_internal):

891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 411000 – Orca repeats old text in gnome-terminal

	The deferred handling of the window scrolling had the unfortunate
	side-effect of postponing the accessibility 'text-scrolled' signal
	until after the 'text-inserted' signal. This caused vteaccess to
	determine that the whole window had been modified and cause orca to
	reread the entire screen.

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_emit_contents_changed),
	(_vte_terminal_queue_contents_changed),
	(vte_terminal_emit_cursor_moved),
	(vte_terminal_queue_cursor_moved), (vte_terminal_scroll_pages),
	(vte_terminal_eof), (vte_terminal_emit_pending_text_signals),
	(vte_terminal_process_incoming), (vte_terminal_handle_scroll),
	(vte_terminal_size_allocate), (vte_terminal_unrealize),
	(vte_terminal_emit_pending_signals):
	* src/vteaccess.c: (emit_text_caret_moved),
	(emit_text_changed_insert), (emit_text_changed_delete):
	* src/vteseq.c: (vte_sequence_handler_decset_internal):
		Restore the order of the ally signals. However, Bug 372777
		remains unresolved.

916
917
918
919
920
921
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_io_read):
		Eeek, correctly compute the buffer length when we no longer
		aim to fill it.

922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	Use a separate debug flag for the ally interface.

	* src/debug.c: (_vte_debug_parse_string):
	* src/debug.h:
	* src/vteaccess.c:
	(vte_terminal_accessible_update_private_data_if_needed),
	(vte_terminal_accessible_invalidate_cursor),
	(vte_terminal_accessible_finalize),
	(vte_terminal_accessible_get_text),
	(vte_terminal_accessible_get_text_somewhere),
	(vte_terminal_accessible_text_init),
	(vte_terminal_accessible_component_init),
	(vte_terminal_accessible_action_init),
	(vte_terminal_accessible_factory_new):

939
940
941
942
943
944
945
2007-02-26  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_io_read):
		And finally clamp the maximum number of bytes transferred in
		a single chunk.

946
947
948
949
950
951
2007-02-24  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c:
		Hint that the compiler should inline
		vte_terminal_determine_colors().

952
953
954
955
956
957
958
959
960
961
2007-02-24  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 410534 – Slow content scrolling, takes 100% of CPU.
	cf Bug 410463 – Poor interactive performance with multiple terminals

	* src/vte.c: (vte_terminal_io_read):
		Do not loop whilst reading in a backlog of child data - should
		help prevent monopolisation of vte by a single child and make
		vte more responsive to user input on slower computers.

Chris Wilson's avatar
Chris Wilson committed
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
2007-02-24  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 159078 – slow highlight

	Do not update the match hilite during a selection-drag.
	Record unsuccesful regex matches, so we can quickly determine whether
	the cursor is still inside the blank region.

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_match_check_internal),
	(rowcol_inside_match), (vte_terminal_match_check),
	(_vte_terminal_set_pointer_visible),
	(vte_terminal_match_hilite_clear),
	(vte_terminal_match_hilite_show), (vte_terminal_match_hilite_hide),
	(vte_terminal_match_hilite_update), (vte_terminal_match_hilite),
	(vte_terminal_motion_notify), (vte_terminal_button_press),
	(vte_terminal_focus_in), (vte_terminal_focus_out),
	(vte_terminal_enter), (vte_terminal_leave), (vte_terminal_init),
	(vte_terminal_unrealize), (vte_terminal_draw_rows),
	(vte_terminal_paint):

983
984
985
986
987
988
989
990
991
992
993
994
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	A couple of compiler warnings and avoid unnecessary arithmetic.

	* src/vte.c: (_vte_terminal_set_default_attributes),
	(find_start_column), (find_end_column),
	(vte_terminal_start_selection), (vte_terminal_extend_selection),
	(vte_terminal_draw_rows), (vte_terminal_paint):
	* src/vtexft.c: (_vte_xft_font_open), (_vte_xft_font_for_char),
	(_vte_xft_char_width), (_vte_xft_unlock_fonts), (_vte_xft_start),
	(_vte_xft_clip), (_vte_xft_set_text_font), (_vte_xft_draw_text):

995
996
997
998
999
1000
1001
1002
1003
1004
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 411276 – SVN trunk compilation error
	Part 2.

	* configure.in:
		Check that the header file defines FcStrFree before checking
		for the availability of the function. Complete hack, but
		appears to work.

1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 411276 – SVN trunk compilation error

	* configure.in:
		Ubuntu Edgy appears to have a broken fontconfig-dev package
		where the function is exported from the library but is missing
		the corresponding prototypes.
		So we reorder the determination of the compilation flags
		before checking for available functions in the hope that the
		tests will then match the results at compile time.

1017
1018
1019
1020
1021
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_io_read):
		Prevent a deadlock on recursively grabbing the gdk_mutex.

1022
1023
1024
1025
1026
1027
1028
1029
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Heuristic to avoid a read when it's likely to just return EAGAIN.

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_io_read), (process_timeout),
	(update_repeat_timeout), (update_timeout):

1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Add a new debug flag to monitor draw operations.
	Don't issue individual glyphs for is_local_graphic() in the middle of
	a run.

	* src/debug.c: (_vte_debug_parse_string):
	* src/debug.h:
	* src/vte.c: (vte_terminal_unichar_is_local_graphic),
	(vte_terminal_draw_rows), (vte_terminal_paint):
	* src/vtedraw.c: (_vte_draw_init_user), (_vte_draw_init_default),
	(_vte_draw_new), (_vte_draw_free), (_vte_draw_get_visual),
	(_vte_draw_get_colormap), (_vte_draw_start), (_vte_draw_end),
	(_vte_draw_set_background_color), (_vte_draw_set_background_image),
	(_vte_draw_requires_repaint), (_vte_draw_clip), (_vte_draw_clear),
	(_vte_draw_set_text_font), (_vte_draw_get_text_width),
	(_vte_draw_get_text_height), (_vte_draw_get_text_ascent),
	(_vte_draw_get_char_width), (_vte_draw_get_using_fontconfig),
	(_vte_draw_text), (_vte_draw_char), (_vte_draw_has_char),
	(_vte_draw_fill_rectangle), (_vte_draw_draw_rectangle),
	(_vte_draw_set_scroll):
	* src/vtedraw.h:
	* src/vteft2.c: (_vte_ft2_draw_has_char):
	* src/vtegl.c: (_vte_gl_draw_has_char):
	* src/vtepango.c: (_vte_pango_draw_has_char):
	* src/vtepangox.c: (_vte_pango_x_draw_has_char):
	* src/vteskel.c: (_vte_skel_draw_has_char):
	* src/vtexft.c: (_vte_xft_draw_has_char):

1059
1060
1061
1062
1063
1064
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_draw_rows):
		Don't break a glyph run for a graphic, issue the draw
		and continue.

1065
1066
1067
1068
1069
1070
1071
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Cache the font metrics on the vte_xft_font, avoids having to remeasure
	when opening a new terminal.

	* src/vtexft.c: (_vte_xft_font_open), (_vte_xft_set_text_font):

1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
2007-02-23  Chris Wilson  <chris@chris-wilson.co.uk>

	Share XftFonts between terminal backends and preserve faces from the
	previous draw - helps prevents font cache thrashing inside libXft.

	* src/vtexft.c: (_vte_xft_font_hash), (_vte_xft_font_equal),
	(_vte_xft_font_open), (_vte_xft_font_close),
	(_vte_xft_font_for_char), (_vte_xft_unlock_fonts),
	(_vte_xft_destroy), (_vte_xft_start), (_vte_xft_end),
	(ptr_array_zeroed_new), (_vte_xft_set_text_font),
	(_vte_xft_get_char_width), (_vte_xft_draw_text),
	(_vte_xft_draw_char):

1085
1086
1087
1088
1089
1090
1091
1092
2007-02-22  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410986  Fails to build with -z defs
	Patch by Loïc Minier.

	* src/Makefile.am:
		Add FreeType to the libs.

1093
1094
1095
1096
1097
1098
2007-02-22  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_send):
		Return in the face of error as we appear to hit this in the
		wild.

1099
1100
1101
1102
1103
1104
1105
1106
1107
2007-02-22  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410819  slider not correctly positioned after calling less

	* src/vte.c: (_vte_terminal_adjust_adjustments),
	(_vte_terminal_adjust_adjustments_full),
	(vte_terminal_maybe_scroll_to_top), (vte_terminal_size_allocate),
	(vte_terminal_set_scrollback_lines):
	* src/vteseq.c: (vte_sequence_handler_decset_internal):
Chris Wilson's avatar
Chris Wilson committed
1108
		Fixup a lot of issues with changing the number of scrollback
1109
1110
1111
		lines, such as missing value_changed signals for the
		scrollbar and a couple of missing CLAMPs.

1112
1113
1114
1115
1116
1117
2007-02-22  Chris Wilson  <chris@chris-wilson.co.uk>

	After adjusting the current profile, the last line gets chomped.

	* src/vte.c: (vte_terminal_set_scrollback_lines):

1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
2007-02-21  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 410534  Slow content scrolling, takes 100% of CPU.

	* src/vte.c: (vte_terminal_scroll),
	(vte_terminal_set_scrollback_lines):
		Operate on scroll delta directly as adjustment->value updates
		are not instantaneous and we may have several scroll events
		before the next update.

1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
2007-02-21  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 410463  Poor interactive performance with multiple terminals

	* src/vte.c: (vte_terminal_io_read), (process_timeout),
	(update_repeat_timeout):
		When multiple terminals are active, poll the IO sources
		from within the process/display timeout (akin to 
		interrupt mitigation).
		Return to normal interrupts when we only have a single active
		terminal - so we don't sacrifice high performance.

1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
2007-02-21  Chris Wilson  <chris@chris-wilson.co.uk>

	A small bit of callgrinding, avoid the modulus inside
	vte_terminal_ensure_cursor() by caching the last row_data.

	* src/iso2022.c: (process_cdata):
	* src/ring.c: (_vte_ring_new), (_vte_ring_insert),
	(_vte_ring_insert_preserve), (_vte_ring_remove):
	* src/ring.h:
	* src/table.c: (_vte_table_match):
	* src/vte.c: (_vte_terminal_ensure_cursor),
	(_vte_terminal_insert_char), (vte_terminal_process_incoming):

1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
2007-02-21  Chris Wilson  <chris@chris-wilson.co.uk>

	Callgrind strikes again...
	Inserting a char is a rare operation (especially in the scrolling
	benchmark!) so only read the old cell during an insert. This wins
	about 5% during a hexdump.

	* src/iso2022.c: (_vte_iso2022_find_nextctl),
	(_vte_iso2022_fragment_input), (process_cdata):
	* src/vte.c: (_vte_terminal_insert_char):
	* src/vteseq.c: (vte_sequence_handler_sf):

1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
2007-02-21  Chris Wilson  <chris@chris-wilson.co.uk>

	RedHat Bug 113195: First line displayed incorrectly if prompt changes background color

	e.g. PS1='\e[46m[\u@\h:\w]\e[m \e[45m'
	The issue is when we insert a char on a new row and the background is
	not the default, we fill the entire row with the *current* colour.
	This behaviour is incorrect, and the fix is to fill to the end of the
	line on a carriage return.

	* src/vte-private.h:
	* src/vte.c: (_vte_terminal_ensure_cursor),
	(_vte_terminal_insert_char), (vte_terminal_process_incoming),
	(vte_terminal_send):
	* src/vteseq.c: (vte_sequence_handler_ce),
	(vte_sequence_handler_cr), (vte_sequence_handler_cs),
	(vte_sequence_handler_cS),
	(vte_sequence_handler_cursor_lower_left),
	(vte_sequence_handler_dc), (vte_sequence_handler_ic),
	(vte_sequence_handler_sf):

1186
1187
1188
1189
1190
1191
1192
1193
1194
2007-02-20  Chris Wilson  <chris@chris-wilson.co.uk>

	 RedHat Bug 123845: gnome-terminal not parsing cursor position escape sequence properly

	* src/caps.c:
	* src/vteseq.c: (vte_sequence_handler_cm):
		Add 'ESC [ Pn H' to cursor-position and provide default
		values.

1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 409055 – Terminal stays blank

	Due to GTK+ coallescing of XExposeEvents it was possible for our
	GdkExposeEvent to arrive before the GdkVisibilityEvent associated with
	the mapping of our toplevel and so we discarded the event as we
	believed we were still unviewable.

	* src/vte.c: (_vte_invalidate_cells), (vte_terminal_expose),
	(reset_update_regions):
		Assume that all GdkExposeEvents have been checked for
		suitability before delivery. We know this true for locally
		generated expose events which are extensively checked during
		invalidation, and we presume that X will not generate expose
		events on unmapped or otherwise unviewable windows.

Chris Wilson's avatar
Chris Wilson committed
1212
1213
1214
1215
1216
1217
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (_vte_terminal_adjust_adjustments),
	(_vte_terminal_adjust_adjustments_full):
		Dead code elimination.

1218
1219
1220
1221
1222
1223
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* perf/random.sh:
		A simple script to dump a fixed amount of random data to the
		terminal.

1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	A few more trivial incremental improvements.

	* src/Makefile.am:
	* src/iso2022.c: (_vte_iso2022_map_get):
		Switch to a VteTree.
	* src/vte.c: (_vte_terminal_update_insert_delta),
	(_vte_terminal_insert_char):
		No need to ensure the cursor when scrolling, only before
		insertions.
	* src/vtexft.c: (_vte_xft_font_open), (_vte_xft_font_close),
	(_vte_xft_font_for_char), (_vte_xft_end):
		Lock the face over the entire expose.

1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	Improve handling of parallel 'cat /dev/urandom' - notably a crasher
	in the table matcher, repeated g_getenv processing and wasted time
	in g_tree_lookup.

	* src/iso2022.c: (_vte_iso2022_ambiguous_width_guess),
	(_vte_iso2022_map_init), (_vte_iso2022_map_get),
	(process_8_bit_sequence), (process_cdata),
	(_vte_iso2022_process_single), (_vte_iso2022_process):
	* src/table.c: (_vte_table_match):
	* src/vte-private.h:

1252
1253
1254
1255
1256
1257
1258
1259
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (update_timeout):
		In conjunction with the previous fix, since the terminal
		can be removed from the active list by
		vte_terminal_process_incoming() we need to be careful whilst
		iterating along the active list.

1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	<fcrozat> ickle: hi.. our kernel hacker just found a nice reproducible
		crash in vte :)
	<ickle> oh, joy
	<fcrozat> very easy to reproduce
		cat /dev/urandom
	 	wait 2 or 3S
	 	then press Ctrl-Shift-T to open a new tab
	 	=> crash

	* src/vte.c: (process_timeout), (update_repeat_timeout):
		vte_terminal_process_incoming() can trigger a terminal reset
		which will remove the terminal from the active list, and then
		we attempt to remove it again after handling the incoming
		data. The fix is simple - don't delete the link if the the
		terminal is no longer active.

1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	As noticed on bug 409055, we do not receive a visibility-notify
	event when we switch workspaces (or even when the window is iconified).
	The workaround for this is to watch for our toplevel being unmapped
	and set the fully-obscured flag.

	* src/vte.c: (vte_terminal_configure_toplevel),
	(vte_terminal_unmap_toplevel), (vte_terminal_hierarchy_changed),
	(vte_terminal_set_visibility), (vte_terminal_visibility_notify):

1289
1290
1291
1292
1293
1294
1295
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (visibility_state_str),
	(vte_terminal_visibility_notify), (vte_terminal_init),
	(vte_terminal_realize):
		Add the visibility state to the debug output.

1296
1297
1298
1299
1300
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* configure.in:
		Add the configuration details to config.log as well.

1301
1302
1303
1304
1305
1306
1307
1308
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 409241  gnome-terminal crashed with SIGSEGV in vte_terminal_draw_graphic()

	* src/vte.c: (vte_terminal_paint):
		Lookup fore/back colours before attempting to draw the graphic
		character behind the unfocused cursor.

Chris Wilson's avatar
Chris Wilson committed
1309
1310
1311
1312
1313
2007-02-19  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_visibility_notify):
		Add VTE_DEBUG_EVENT info.

1314
1315
2007-02-16  Chris Wilson  <chris@chris-wilson.co.uk>

1316
	Bug 407945  "GNOME" Terminal" regression after "vte" update when using "csh"
1317

1318
1319
1320
1321
1322
	When passing multiple versions of the same environment
	variable to execve (i.e g_spawn) the result is undefined.
	So we solve the ambiguity by using the application passed env to
	override values from the current environment.
	
1323
1324
1325
	* src/pty.c: (collect_variables), (merge_environ),
	(_vte_pty_run_on_pty):

1326
1327
1328
1329
1330
1331
1332
1333
1334
2007-02-16  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 408536 – trouble compiling vte 0.15.3

	* configure.in:
	* src/vtefc.c: (_vte_fc_patterns_from_pango_font_desc):
		Check for availability of FcStrFree() - only used for
		debugging purposes so we can live without it.

1335
1336
1337
1338
1339
1340
1341
1342
2007-02-15  Chris Wilson  <chris@chris-wilson.co.uk>

	Guard against a missing default number of rows or columns
	inside the termcap.

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_set_emulation), (vte_terminal_init):

1343
1344
1345
1346
1347
1348
1349
1350
2007-02-15  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 408040 – vte automagic hyperlinks
	Patch by Gilles Dartiguelongue.

	* src/vteapp.c:
		Correct the typo in the nntp protocol matcher.

1351
1352
1353
2007-02-14  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 407839 – Use of environ breaks build on Solaris
1354
	Original patch by Damien Carbery.
1355
1356
1357
1358
1359

	* src/pty.c:
		extern char **environ - glibc was 'conveniently' declaring
		it for us...

1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
2007-02-13  Chris Wilson  <chris@chris-wilson.co.uk>

	uws reported that scrolling inside screen with a status line was
	broken. Indeed any scrolling inside an alternative screen was broken,
	e.g. plain vim would not always update the topmost line. The issue was
	the interaction with the deferred value-changed signal emission and
	failing to correctly maintain the current scroll_delta. The fix is
	that we always now apply changes to the scroll_delta and swap
	scroll_delta with adjustment->value before the deferred signal
	emission to correctly trigger the handle_scroll().

	* src/vte-private.h:
	* src/vte.c: (_vte_invalidate_cells),
	(vte_terminal_emit_adjustment_changed),
	(vte_terminal_queue_adjustment_value_changed),
	(_vte_terminal_adjust_adjustments),
	(_vte_terminal_adjust_adjustments_full),
	(vte_terminal_maybe_scroll_to_bottom),
	(vte_terminal_process_incoming), (vte_terminal_extend_selection),
	(vte_terminal_handle_scroll), (vte_terminal_set_scrollback_lines):
	* src/vteseq.c: (vte_sequence_handler_sf):

1382
1383
1384
1385
1386
1387
1388
1389
2007-02-13  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 407358 – regression in mouse selection

	* src/vte.c: (vte_terminal_motion_notify):
		When outside the terminal we used an uninitialised variable to
		determine the mouse tracking mode.

Behdad Esfahbod's avatar
Behdad Esfahbod committed
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
2007-02-12  Behdad Esfahbod  <behdad@gnome.org>

	Released vte-0.15.3.

	* NEWS: Updated.

	* configure.in: Bumped version to 0.15.3.

	* src/Makefile.am: Bumped libtool version to 11:0:2.

Chris Wilson's avatar
Chris Wilson committed
1400
1401
1402
1403
1404
1405
2007-02-12  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_extend_selection),
	(vte_terminal_motion_notify):
		Restore autoscroll behaviour.

1406
1407
1408
1409
1410
1411
2007-02-12  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_start_selection):
		Invalidate the selected region when starting in
		select-word or select-line mode.

1412
1413
1414
1415
1416
1417
1418
1419
1420
2007-02-12  Chris Wilson  <chris@chris-wilson.co.uk>

	Restore double-click to select word behaviour, broken by r1671 as
	the second click occurs in the same place as the first (obviously!).

	* src/vte.c: (vte_terminal_extend_selection),
	(vte_terminal_autoscroll), (vte_terminal_motion_notify),
	(vte_terminal_button_press):

1421
1422
1423
1424
1425
1426
1427
1428
2007-02-12  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 407091 – vte_terminal_fork_command() env argument changed semantic in 0.15.2
	Original patch by Michael Vogt.

	* src/pty.c: (_vte_pty_run_on_pty):
		Copy the current environment into the child's.

1429
1430
1431
1432
1433
2007-02-11  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 323393 – Hyper-sensitive selection

	* src/vte.c: (vte_terminal_extend_selection):
1434
		Don't start (or update) the selection until you
1435
1436
		move off the current cell (character).

1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
2007-02-11  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 406763 – Selecting double-wide characters

	* src/vte.c: (start_column), (end_column),
	(vte_terminal_start_selection), (vte_terminal_extend_selection),
	(vte_terminal_draw_rows):
		Extend selection to include fragment cells i.e. double-wide
		characters.

1447
1448
1449
1450
1451
1452
1453
1454
1455
2007-02-10  Chris Wilson  <chris@chris-wilson.co.uk>

	Have a separate adjust_adjustments for when we know that the page
	size and step lengths may have changed.

	* src/vte.c: (_vte_terminal_adjust_adjustments),
	(_vte_terminal_adjust_adjustments_full),
	(vte_terminal_set_scrollback_lines), (vte_terminal_reset):

1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
2007-02-10  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (_vte_terminal_adjust_adjustments),
	(vte_terminal_size_allocate), (vte_terminal_set_scrollback_lines):
		Prevent the display of garbage after resizing and switching
		between alternate screens.
		However, instead of displaying garbage after the cursor, we
		lose some data above the current scroll delta, should we have
		a full history.  Bizarre.

1466
1467
1468
1469
1470
1471
1472
1473
2007-02-09  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (_vte_terminal_adjust_adjustments):
		Do not allow to scroll past the last line after reducing
		scrollback lines.
	* src/vtexft.c: (_vte_xft_set_text_font):
		Ensure a fallback height is set.

1474
1475
1476
1477
1478
2007-02-09  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_get_text_range_maybe_wrapped):
		Reuse VteRowData whilst in the row.

1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
2007-02-09  Chris Wilson  <chris@chris-wilson.co.uk>

	Rework to reduce number of times mutex is taken and shorten the hold.

	* src/vte.c: (vte_terminal_queue_adjustment_changed),
	(vte_terminal_queue_adjustment_value_changed),
	(vte_terminal_io_read), (vte_terminal_paint),
	(vte_terminal_add_process_timeout), (vte_terminal_is_processing),
	(vte_terminal_start_processing):

1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
2007-02-09  Chris Wilson  <chris@chris-wilson.co.uk>

	A number of small bug fixes...
	- do not override the user setting of scrollback lines with the
	terminal size.
	- only set the current screen rather than both and so reset the
	scrollback lines when we switch between normal and alternate.
	- do not invalidate inside set_scrollback lines as setting does not
	actually modify the on-screen contents.
	- push the scroll-adjustment to the post-processing emission.
	- queue timeouts on value change (should be a no-op)
	- reorder emission so that scrolling occurs before invalidating the
	window (ie so that the scroll happens this cycle, not next).

	Still unsolved: the clamping of the cursor when switching between
	alternate screens.

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_emit_adjustment_changed),
	(vte_terminal_queue_adjustment_changed),
	(vte_terminal_queue_adjustment_value_changed),
	(_vte_terminal_adjust_adjustments), (vte_terminal_scroll_pages),
	(vte_terminal_maybe_scroll_to_top),
	(vte_terminal_maybe_scroll_to_bottom),
	(_vte_terminal_ensure_cursor), (_vte_terminal_update_insert_delta),
	(vte_terminal_process_incoming), (vte_terminal_extend_selection),
	(vte_terminal_autoscroll), (vte_terminal_handle_scroll),
	(vte_terminal_size_allocate), (vte_terminal_scroll),
	(vte_terminal_background_update),
	(vte_terminal_queue_background_update),
	(vte_terminal_set_scrollback_lines), (vte_terminal_reset),
	(add_process_timeout), (vte_terminal_add_process_timeout),
	(vte_terminal_start_processing), (update_repeat_timeout),
	(update_timeout):
	* src/vteseq.c: (vte_sequence_handler_scroll_up_or_down),
	(vte_sequence_handler_decset_internal), (vte_sequence_handler_al),
	(vte_sequence_handler_dl), (vte_sequence_handler_sf),
	(vte_sequence_handler_sr), (vte_sequence_handler_clear_screen),
	(vte_sequence_handler_cursor_character_absolute),
	(vte_sequence_handler_insert_lines),
	(vte_sequence_handler_delete_lines),
	(vte_sequence_handler_screen_alignment_test):

Chris Wilson's avatar
Chris Wilson committed
1532
1533
1534
1535
2007-02-08  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vteapp.c: (main): whitespace

1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
2007-02-08  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 363597 – Scrollback in profile dialog doesn't work

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_init),
		Only use SCROLLBACK_MIN during initialisation, so rename it
		to SCROLLBACK_INIT.
	(vte_terminal_set_scrollback_lines):
		Remove MAX(lines, SCROLLBACK_MIN) and update code comments
		to reduce confusion.

1548
1549
1550
1551
2007-02-08  Mariano Suárez-Alvarez  <mariano@gnome.org>

	* src/vteapp.c(main): do something useful with --geometry.

1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
2007-02-08  Chris Wilson  <chris@chris-wilson.co.uk>

	Use gtk_widget_get_(screen|display) which will itself return a default
	if not currently attached.

	* src/vtedraw.c: (_vte_draw_get_colormap):
	* src/vtefc.c: (_vte_fc_defaults_from_gtk):
	* src/vtegl.c: (_vte_gl_check), (_vte_gl_create),
	(_vte_gl_destroy), (_vte_gl_start), (_vte_gl_end), (_vte_gl_clear),
	(_vte_gl_draw_text), (_vte_gl_rectangle):
	* src/vterdb.c: (_vte_rdb_get):
	* src/vteseq.c: (vte_sequence_handler_window_manipulation):

1565
1566
1567
1568
1569
1570
1571
1572
1573
2007-02-08  Chris Wilson  <chris@chris-wilson.co.uk>

	Some more callgrinding - kill a little bit of overhead.

	* src/iso2022.c: (_vte_iso2022_sequence_length),
	(_vte_iso2022_fragment_input), (process_control):
	* src/matcher.c: (_vte_matcher_free_params_array):
	* src/vteconv.c: (_vte_conv):

1574
1575
1576
1577
1578
1579
1580
1581
2007-02-07  Chris Wilson  <chris@chris-wilson.co.uk>

	Actually return whether or not we found the char in
	_vte_xft_font_for_char - saves having to double check afterwards!

	* src/vtexft.c: (_vte_xft_font_for_char), (_vte_xft_set_text_font),
	(_vte_xft_draw_text):

1582
1583
1584
1585
1586
1587
1588
1589
2007-02-07  Chris Wilson  <chris@chris-wilson.co.uk>

	As spotted perusing roxterm, we fail to redraw after changing the text
	colour.

	* src/vte.c: (vte_terminal_set_color_internal):
		Remember to invalidate all!

1590
1591
1592
1593
1594
1595
2007-02-07  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_match_check_internal):
		Scan for newlines before and after the current row
		to find the entire line in case of soft-wrapping.

1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
2007-02-07  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 345344 – Pattern matching is inefficient
	Bug 324246 – Performance degredation with large numbers of highlighted addresses/URLs

	* src/vte.c: (vte_terminal_match_check_internal):
		Trim the searched string down to the row containing the
		pointer. During a mutt session this drops the time consumed by
		regexec from ~30% to ~2%.
		Note: multi-line regexes are now unsupported!

Chris Wilson's avatar
Chris Wilson committed
1607
1608
1609
1610
1611
2007-02-07  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vteseq.c: (_vte_sequence_get_handler):
		Avoid the strlen when possible.

Chris Wilson's avatar
Chris Wilson committed
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
2007-02-07  Chris Wilson  <chris@chris-wilson.co.uk>

	Some cleanups and a bug...

	vte_terminal_match_hilite() compared the current cell to the last
	mouse position without a floor().

	* src/vte.c: (vte_terminal_process_incoming),
	(vte_terminal_match_hilite), (vte_terminal_select_all),
	(vte_terminal_select_none), (vte_terminal_motion_notify),
	(vte_terminal_button_press):

1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 86119 – "select all" feature
	Original patch by Simone Gotti.

	* src/vte.c: (vte_terminal_select_all), (vte_terminal_select_none):
	* src/vte.h:
		Add 2 new API entry points to select the entire contents
		and clear the current selection.

1634
1635
1636
1637
1638
1639
1640
1641
2007-02-06  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 342059 – ASCII escape sequences don't work as expected
	Correction by Mariano Suárez-Alvarez.

	* src/vteseq.c: (vte_sequence_handler_cursor_character_absolute):
		OBO on the parameter.

1642
1643
1644
1645
1646
1647
1648
1649
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 342059 – ASCII escape sequences don't work as expected
	Patch by Mariano Suárez-Alvarez.

	* src/vteseq.c: (vte_sequence_handler_cursor_character_absolute):
		Provide a default value.

1650
1651
1652
1653
1654
1655
1656
1657
1658
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	And finally as noted on bug 324246#c8 hide the hilite when the mouse
	leaves the terminal (show again when it enters and let motion-notify
	correct it later).

	* src/vte.c: (vte_terminal_enter), (vte_terminal_leave),
	(vte_terminal_realize), (vte_terminal_class_init):

1659
1660
1661
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	As noted on bug 324246#c8, hide the hilite when the focus disappears.
1662
1663
	On focus restore the match for the last mouse coordinates and let
	motion-notify take care of the rest.
1664

1665
1666
	* src/vte.c: (vte_terminal_match_hilite_update),
	(vte_terminal_match_hilite), (vte_terminal_focus_in):
1667

1668
1669
1670
1671
1672
1673
1674
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Convert the exposed rectangles to cells and remerge them.

	* src/vte.c: (vte_terminal_expand_region),
	(vte_terminal_paint_area), (vte_terminal_paint):

1675
1676
1677
1678
1679
1680
1681
1682
1683
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	As noted on Bug 401052#c13, vte fails to completely clear the cell's
	previous contents.

	* src/vte.c: (_vte_invalidate_cells):
		Grow the invalidate region by a single pixel to accomodate
		antialiased pseudo-bold characters.

1684
1685
1686
1687
1688
1689
1690
1691
1692
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Move status_line_changed to post-processing emission.

	* src/vte-private.h:
	* src/vte.c: (_vte_terminal_insert_char), (vte_terminal_reset),
	(vte_terminal_emit_pending_signals):
	* src/vteseq.c: (vte_sequence_handler_ts):

1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	Clamp down on needless invalidates during selection.

	As commented on in Bug 401052#c10

	* src/vte.c: (_vte_invalidate_region), (vte_terminal_deselect_all),
	(vte_terminal_match_hilite_clear), (vte_terminal_start_selection),
	(vte_terminal_extend_selection):

1703
1704
1705
1706
1707
1708
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_draw_rows):
		Don't needlessly break the text run on a space if we are
		not drawing cell attributes.

1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
2007-02-06  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/iso2022.c: (_vte_iso2022_is_ambiguous_ht):
		One more G_UNLIKELY
	* src/vte.c: (vte_terminal_match_hilite),
	(vte_terminal_motion_notify):
		Avoid expensive hiliting if the pointer is not in the window.
	* src/vteregex.c: (_vte_regex_exec):
		Prefer g_new(x,n) over g_malloc(sizeof(x)*n)

1719
1720
1721
1722
1723
1724
1725
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 404757 – URL matching doesn't work with PCRE

	* configure.in:
		mention the inconsistency in the help string and default to no.

1726
1727
1728
1729
1730
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (vte_terminal_draw_rows):
		Don't draw cell attributes across spaces.

Chris Wilson's avatar
Chris Wilson committed
1731
1732
1733
1734
1735
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vte.c: (_vte_terminal_insert_char):
		A couple more G_LIKELYs.

1736
1737
1738
1739
1740
1741
1742
1743
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 403028 – decset mode 12 = blinking cursor

	* src/vteseq.c: (vte_sequence_handler_decset_internal):
		Following convention, disallow the application's control
		over the blinking cursor in favour of the user's setting.

1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Some more small callgrind tweaks - well into the law of diminishing
	returns.

	* src/iso2022.c: (_vte_iso2022_is_ambiguous_ht),
	(_vte_iso2022_is_ambiguous), (process_8_bit_sequence),
	(process_cdata), (_vte_iso2022_unichar_width):
	* src/matcher.c: (_vte_matcher_free_params_array):
	* src/vte.c: (vte_terminal_process_incoming):

1755
1756
1757
1758
1759
1760
1761
1762
1763
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	Beware the trivial change. Handle reuse of GValueArray correctly.

	* src/matcher.c: (_vte_matcher_match):
	* src/table.c: (_vte_table_match):
	* src/trie.c: (_vte_trie_match):
	* src/vte.c: (vte_terminal_process_incoming):

1764
1765
1766
1767
1768
1769
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/table.c: (_vte_table_match):
		And kill the leak as vte_table_match erroneously cleared
		its output arguments.

1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	The continual reallocation of GValueArray is the last trivially
	avoidable g_realloc.

	* src/interpret.c: (main):
	* src/matcher.c: (_vte_matcher_create), (_vte_matcher_destroy),
	(_vte_matcher_match), (_vte_matcher_free_params_array):
	* src/matcher.h:
	* src/table.c: (_vte_table_extract_string):
	* src/trie.c: (_vte_trie_matchx), (_vte_trie_match), (main):
	* src/vte.c: (vte_terminal_process_incoming):

1783
1784
1785
1786
1787
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/ring.c: (_vte_ring_insert):
		Missed an important compiler warning.

1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
2007-02-05  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 342338 – suffers from memory fragmentation

	Reuse the last VteRowData instead of immediately freeing it. Avoids
	recreating and *regrowing* a new GArray on the heap.

	In the simple scrolling benchmarks this can boost performance by as
	much as 10%!

	* src/ring.c: (_vte_ring_insert), (_vte_ring_insert_preserve),
	(_vte_ring_remove), (_vte_ring_append):
	* src/ring.h:
	* src/vte-private.h:
	* src/vte.c: (_vte_reset_row_data), (_vte_terminal_ensure_cursor),
	(_vte_terminal_insert_char), (vte_terminal_reset_rowdata):
	* src/vteseq.c: (vte_insert_line_internal),
	(vte_sequence_handler_scroll_up_or_down),
	(vte_sequence_handler_cd), (vte_sequence_handler_sf),
	(vte_sequence_handler_clear_screen),
	(vte_sequence_handler_screen_alignment_test):

Chris Wilson's avatar
Chris Wilson committed
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	A few more compiler warnings.

	* src/buffer.c: (_vte_buffer_peek_gstring):
	* src/iso2022.c: (process_control):
	* src/vteft2.c: (_vte_ft2_set_text_font):
	* src/vteseq.c: (vte_sequence_handler_set_title_internal):
	* src/vtetc.c: (_vte_termcap_parse_file):

1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 106618 – CJK 'fixed width' font and 's p a c e d o u t' issue

	* src/vtedraw.h:
	* src/vteglyph.c: (_vte_glyph_cache_set_font_description):
	* src/vtepango.c: (_vte_pango_set_text_font):
	* src/vtepangox.c: (_vte_pango_x_set_text_font):
	* src/vtexft.c: (_vte_xft_set_text_font):
		Detect a change in font between wide-chars and recheck for a
		fixed-width estimate.

Chris Wilson's avatar
Chris Wilson committed
1832
1833
1834
1835
1836
1837
1838
1839
1840
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Micro-opts.

	* src/table.c: (_vte_table_match):
		No need set to NULL.
	* src/vte.c: (_vte_terminal_ensure_cursor):
		If we have added some rows, the last is the current.

1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Move window/icon title changed to the post-processing emission - helps
	with the artificial benchmark of replaying a recorded jhbuild script.

	* src/vte-private.h:
	* src/vte.c: (vte_terminal_finalize),
	(vte_terminal_emit_icon_title_changed),
	(vte_terminal_emit_window_title_changed),
	(vte_terminal_emit_pending_signals):
	* src/vteseq.c: (vte_sequence_handler_set_title_internal):

1853
1854
1855
1856
1857
1858
1859
1860
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Broke clear-to-end-of-line by lowering the number of cells appended,
	instead of the number of cells invalidated.

	* src/vte.c: (vte_terminal_draw_rows):
	* src/vteseq.c: (vte_sequence_handler_ce):

1861
1862
1863
1864
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 83285 – Treacle-slow scrolling in gnome-terminal on unaccelerated X server

Chris Wilson's avatar
Chris Wilson committed
1865
	Another chunk of performance improvements - the majority focusing on
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
	reducing the amount of work down per interrupt (input data from
	child).

	To handle reads without addition copies VTE_INPUT_CHUNK_SIZE chunks
	are allocated on demand and filled from read with no further copy -
	previously the read was into a local buffer and then immediately
	copied into a _vte_buffer.
	_vte_iso2022_process() is then adjusted to use a ptr+length, rather
	than a _vte_buffer and is called for every input chunk (taking special
	care over the boundary cases).

	* src/interpret.c: (main):
	* src/iso2022.c: (_vte_iso2022_fragment_input),
	(process_8_bit_sequence), (process_cdata), (_vte_iso2022_process):
	* src/iso2022.h:
	* src/vte-private.h:
	* src/vte.c: (get_chunk), (release_chunk), (prune_chunks),
	(_vte_incoming_chunks_release), (_vte_incoming_chunks_length),
	(_vte_incoming_chunks_count), (_vte_incoming_chunks_reverse),
	(vte_terminal_match_check_internal), (_vte_terminal_ensure_cursor),
	(vte_terminal_set_colors), (_vte_terminal_insert_char),
	(vte_terminal_catch_child_exited), (vte_terminal_eof),
	(vte_terminal_process_incoming), (_vte_terminal_feed_chunks),
	(vte_terminal_io_read), (vte_terminal_feed), (vte_terminal_send),
	(vte_terminal_init), (vte_terminal_finalize), (vte_terminal_reset),
	(remove_from_active_list), (need_processing), (update_regions),
	(update_repeat_timeout):
	* src/vte.h:
	* src/vteseq.c: (vte_sequence_handler_cb),
	(vte_sequence_handler_ce), (vte_sequence_handler_ec):

1897
1898
1899
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Store whether the codeset is ambiguous in a state variable,
Chris Wilson's avatar
Chris Wilson committed
1900
	rather than recomputing the ambiguous width every processing loop.
1901
1902
1903
1904

	* src/iso2022.c: (_vte_iso2022_is_ambiguous),
	(_vte_iso2022_state_new), (_vte_iso2022_find_nextctl):

1905
1906
1907
1908
1909
1910
1911
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vtexft.c: (_vte_xft_create), (_vte_xft_destroy):
		Remove zero-initialisers after g_slice_new0().
	* src/vtexft.c :(_vte_xft_set_text_font):
		Print out the width range.

Chris Wilson's avatar
Chris Wilson committed
1912
1913
1914
1915
1916
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	* configure.in:
		Missing space between -Wflags.

1917
1918
1919
2007-02-04  Chris Wilson  <chris@chris-wilson.co.uk>

	Eliminate the temporary g_sliced parameter list,
Chris Wilson's avatar
Chris Wilson committed
1920
	in favour of an on-stack list.
1921
1922
1923
1924
1925
1926
1927
1928

	* src/table.c: (_vte_table_arginfo_head_init),
	(_vte_table_arginfo_alloc), (_vte_table_arginfo_head_revert),
	(_vte_table_arginfo_head_reverse),
	(_vte_table_arginfo_head_finalize), (_vte_table_addi),
	(_vte_table_matchi), (_vte_table_extract_string),
	(_vte_table_match):

1929
1930
1931
1932
1933
1934
1935
2007-02-02  Chris Wilson  <chris@chris-wilson.co.uk>

	* src/vtefc.c: (_vte_fc_patterns_from_pango_font_desc):
		Dump the chosen fonts to VTE_DEBUG_MISC.
	* src/vteft2.c: (_vte_ft2_set_text_font):
		Print out the font metrics ala vtexft.c

1936
1937
1938
1939
1940
1941
1942
2007-02-02  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 322241 – Please switch to pkg-config to check for freetype

	* configure.in:
		Prefer to use the freetype2.pc if available.

1943
1944
1945
1946
1947
1948
1949
2007-02-02  Chris Wilson  <chris@chris-wilson.co.uk>

	Bug 322240 – Usage of pkg-config privates header

	* vte.pc.in:
		Move @FT2_LIBS@ to Libs.private.

1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>

	cf Bug 403275 – crash in Terminal: I was typing reset on th...

	Not the crash, just a freeze found whilst trying to reproduce the
	bug on trunk.

	* src/vte.c: (remove_from_active_list):
		Don't remove the terminal from the active list if it still
		has pending redraws.
	
	* src/vte.c: (process_timeout), (update_timeout):
		Reorder the loop to remove the terminal from the active list
		if it no longer needs processing.

1965
1966
1967
1968
1969
2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>

	* perf/scroll.vim:
		Extract the bits the test needs out of debian.vim.

1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
2007-02-01  Chris Wilson  <chris@chris-wilson.co.uk>

	As spotted on bug 399617c8, we convert an array of unichars to a
	string and then iterate over the string interpreting bytes as
	unichars.

	* src/table.c: (_vte_table_extract_numbers):
		Dispense with the temporary string and process the unichar
		array directly.

1980
1981
1982
1983
1984
1985
1986
2007-02-01  Chris Wilson <chris@chris-wilson.co.uk>

	Bug 403159 – XftDrawSetClipRectangles() silently fails on ppc->i386

	* src/vtexft.c: (_vte_xft_clip):
		Precompute clip offsets.

1987
1988
1989
1990
1991
1992
1993
<