Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • vala vala
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 739
    • Issues 739
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • valavala
  • Merge requests
  • !213

Draft: codegen: Optimize server-side GDBus reply handling

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ole André Vadla Ravnås requested to merge oleavr/vala:gdbus-server-noreply into master Nov 06, 2021
  • Overview 5
  • Commits 4
  • Changes 57
  • Don't send a reply if NO_REPLY_EXPECTED is set. This is already taken care of by g_dbus_method_invocation_return_gerror(), so we only need to do this for the non-error case, since we generate the reply message and manually send it.
  • Because we have to keep arguments alive for the duration of the call, and this requires us to pass a ready callback even in case of NO_REPLY_EXPECTED, there is a challenge: If the implementation is a GDBus proxy, the presence of a ready callback means we don't set NO_REPLY_EXPECTED, even if we don't want the reply. But since we know that a proxy will copy the arguments right away, we can omit the ready callback in that case.
Edited Nov 09, 2021 by Rico Tzschichholz
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: gdbus-server-noreply