From 1827506c33d693021a3985254c0f292ff553015a Mon Sep 17 00:00:00 2001 From: Yotam Nachum Date: Sat, 6 Nov 2021 14:33:07 +0200 Subject: [PATCH] gtkmodule: Improve error message for invalid signal element in ui-file --- codegen/valagtkmodule.vala | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/codegen/valagtkmodule.vala b/codegen/valagtkmodule.vala index 8b2e88da1..01e60535f 100644 --- a/codegen/valagtkmodule.vala +++ b/codegen/valagtkmodule.vala @@ -187,7 +187,13 @@ public class Vala.GtkModule : GSignalModule { if (current_class != null) { if (signal_name == null || handler_name == null) { - Report.error (node.source_reference, "Invalid signal in ui file `%s'", ui_file); + if (signal_name != null) { + Report.error (node.source_reference, "Invalid signal `%s' without handler in ui file `%s'", signal_name, ui_file); + } else if (handler_name != null) { + Report.error (node.source_reference, "Invalid signal without name in ui file `%s'", ui_file); + } else { + Report.error (node.source_reference, "Invalid signal without name and handler in ui file `%s'", ui_file); + } current_token = reader.read_token (null, null); continue; } -- GitLab