Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
vala
vala
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 702
    • Issues 702
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 39
    • Merge Requests 39
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • GNOME
  • valavala
  • Merge Requests
  • !159

Merged
Opened Nov 28, 2020 by Chris White@cxw42Contributor

vapi: gstreamer-1.0: fix uses of GLib.Value (#1014)

  • Overview 25
  • Commits 1
  • Changes 4

This is for gstreamer-1.0. I have not yet reviewed gstreamer-controller-1.0 or gstreamer-video-1.0. I look forward to your comments! See discussion in #1014 (closed).

  • Fix parameter directions on GLib.Value parameters:
    • Use out for functions that take an uninitialized GLib.Value.
    • Use ref for functions that take a GLib.Value initialized with a particular type.
  • Fix ChildProxy.get_property return value, which is an out parameter (#1111 (closed)) (thanks @ricotz)
  • Remove Gst.ControlBindingConvert, which used to use GLib.Value, per https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/5898042610b094369f5868c332700f705dc4bf06 and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/blob/7c0dcb91fcbe6f14afe6428547dff8a880861baa/gst/gstcontrolbinding.h#L52.
Edited Dec 10, 2020 by Chris White
Assignee
Assign to
Reviewer
Request review from
0.52
Milestone
0.52
Assign milestone
Time tracking
Reference: GNOME/vala!159
Source branch: issue1014mr

Revert this commit

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this commit

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.