• Carlos Garnacho's avatar
    libtracker-miner: Fix lookup of already interned files · 3b7ed345
    Carlos Garnacho authored
    This code had several wrongs here:
    - The tracker_file_system_is_file_interned got the check_fs
      parameter wrong, creating an additional copy of the file.
      This would be inocuous as the later lookup would succeed,
      except
    - The extra copy of the file was being leaked
    - And actually the later lookup is somewhat superfluous if
      we are checking the NodeLookupData. We can shortcircuit
      lookup of files already interned in this TrackerFileSystem
      even further.
    
    This all is fixed now, the tracker_file_system_is_file_interned()
    function got open coded in the caller function so we can perform
    the fast path, the check has been corrected, and even if we would
    fall through the paths that do need a copy, it wouldn't be leaked.
    3b7ed345
Name
Last commit
Last update
docs Loading commit data...
examples Loading commit data...
m4 Loading commit data...
po Loading commit data...
src Loading commit data...
tests Loading commit data...
utils Loading commit data...
.gitignore Loading commit data...
.gitlab-ci.yml Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
COPYING.GPL Loading commit data...
COPYING.LGPL Loading commit data...
ChangeLog.pre-0-6-93 Loading commit data...
MAINTAINERS Loading commit data...
Makefile.am Loading commit data...
Makefile.decl Loading commit data...
NEWS Loading commit data...
README Loading commit data...
autogen.sh Loading commit data...
config.h.meson.in Loading commit data...
configure.ac Loading commit data...
gitlog-to-changelog Loading commit data...
meson.build Loading commit data...
meson_options.txt Loading commit data...
tap-driver.sh Loading commit data...
tap-test Loading commit data...
tracker.doap Loading commit data...