1. 03 May, 2019 3 commits
  2. 02 May, 2019 1 commit
  3. 01 May, 2019 6 commits
    • Sam Thursfield's avatar
      Merge branch 'sam/text-extractor-errors' into 'master' · 2eda05bb
      Sam Thursfield authored
      tracker-extract-text: Correctly report errors back to the caller
      
      Closes #56
      
      See merge request !62
      2eda05bb
    • Sam Thursfield's avatar
      tracker-extract-text: Correctly report errors back to the caller · 08f4af62
      Sam Thursfield authored
      The tracker_extract_get_metadata() function should return FALSE if
      an error occurs reading the file. The tracker-extract-text module would
      return TRUE in all cases.
      
      This was causing intermittent failures in the functional-tests, as the
      following situation could occur:
      
        1. file2.txt is created
        2. tracker-miner-fs sees file2.txt and processes it
        3. file2.txt is deleted (or moved into an unmonitored directory)
        4. tracker-miner-fs sees the deletion and removes its resource from
           the store
        5. tracker-extract sees the created notification for file2.txt and
           tries to process it
        6. the tracker_extract_get_metadata() incorrectly returns TRUE
           (success), so tracker-extract recreates the deleted resource
      
      This problem was being detected in the functional tests and was
      causing intermittent failures.
      
      This hopefully fixes: #56
      08f4af62
    • Sam Thursfield's avatar
      Revert "build: Require Meson >= 0.50" · 13948fda
      Sam Thursfield authored
      This reverts commit 60145ddd.
      
      Some projects that include Tracker haven't yet updated to Meson 0.50. This
      change broke gnome-build-meta for example:
      https://gitlab.gnome.org/GNOME/gnome-build-meta/-/jobs/286671
      
      The install: arg isn't actually required as for configure_file() targets
      Meson will infer whether an install is needed by the presence of the
      install_dir: arg.
      13948fda
    • Sam Thursfield's avatar
      Revert "functional-tests: Don't depend on GSettings schemas from the host" · ecac3a1e
      Sam Thursfield authored
      This reverts commit ad664049.
      
      I accidentally pushed this to master without review, when I pushed the
      trivial Meson change.
      
      The merge request is here:
      !61/
      ecac3a1e
    • Sam Thursfield's avatar
      build: Require Meson >= 0.50 · 60145ddd
      Sam Thursfield authored
      Meson helpfully warns us that this is needed:
      
          WARNING: Project specifies a minimum meson_version '>=0.47' but uses features which were added in newer versions:
           * 0.50.0: {'install arg in configure_file'}
      60145ddd
    • Sam Thursfield's avatar
      functional-tests: Don't depend on GSettings schemas from the host · ad664049
      Sam Thursfield authored
      If tracker-miners is configured with the `-Dtracker_core=subproject` option,
      it should use GSettings schemas from the ./subprojects/tracker build
      tree. We weren't doing that, which meant that if you ran `dnf remove
      tracker` on your test image and then ran the test, you would see
      failures like this in the functional-tests:
      
          (process:8450): GLib-GIO-ERROR **: 09:43:34.625: Settings schema 'org.freedesktop.Tracker.Store' is not installed
      
      This fix is part of tracker#24
      ad664049
  4. 24 Apr, 2019 4 commits
  5. 01 Apr, 2019 2 commits
  6. 31 Mar, 2019 3 commits
    • Carlos Garnacho's avatar
      tracker-extract: Only set nfo:Audio on rules handling FLAC files · fb87cd28
      Carlos Garnacho authored
      This is the most generic class that still triggers GraphUpdated, we need
      to delegate on the extractor module to figure out whether the file is a
      music piece on its own or a container of music pieces.
      
      In the latter case the role belongs on the contained elements, not on the
      file resource itself, so avoid setting it here for all.
      fb87cd28
    • Carlos Garnacho's avatar
      tracker-extract: Only add nmm:* information if there is no TOC · 8feaa263
      Carlos Garnacho authored
      If there is a TOC, the nmm:* information belongs in the child nmm:MusicPiece
      elements, not on the container file.
      8feaa263
    • Carlos Garnacho's avatar
      tracker-extract: Relate contained audio tracks and container file both ways · d93cbdaa
      Carlos Garnacho authored
      The migration to TrackerResource broke the handling of flac/cue, as
      tracker_resource_print_*() do expect all related resources to be directly
      referenced from the root resource, but the gstreamer extractor just added
      backreferences from the nmm:MusicPieces to the parent nfo:FileDataObject.
      
      Add a relation both ways through nie:hasLogicalPart/nie:isLogicalPartOf
      so the graph is complete, and the tracks referenced from the root element.
      
      Closes: #60
      d93cbdaa
  7. 27 Mar, 2019 2 commits
  8. 25 Mar, 2019 1 commit
  9. 19 Mar, 2019 3 commits
  10. 18 Mar, 2019 6 commits
  11. 07 Mar, 2019 2 commits
    • Carlos Garnacho's avatar
      Release 2.2.1 · 67958708
      Carlos Garnacho authored
      67958708
    • Carlos Garnacho's avatar
      functional-tests: Forbid GStreamer to fork for the registry · 045cbfad
      Carlos Garnacho authored
      Running functional tests in an isolated environment result on gst
      trying to build the registry again, and fork for it. This results
      in a g_spawn call, and who knows why, in this debug line written to
      stdout:
      
      posix_spawn avoided (fd close requested)
      
      This is a g_debug() call from glib which should not end up on screen
      with our verbosity settings, so I'll asume someone else is playing
      smart and replacing the default log handler with something that
      introduces garbage on our stdout.
      
      This notably causes JSON output in video tests to be not quite JSON,
      causing test failures.
      045cbfad
  12. 06 Mar, 2019 2 commits
  13. 05 Mar, 2019 4 commits
  14. 04 Mar, 2019 1 commit