GitLab

miners: fix After= usage in systemd service files

See merge request !312

After= needs to go into the [Unit] section

Fixes 3a75f938

Fix uninitialised variable warnings

See merge request !310

../src/tracker/tracker-info.c: In function ‘output_eligible_status_for_file.isra’:
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: ‘tracker_miner_fs_path’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   28 |   g_free (*pp);
      |   ^~~~~~~~~~~~
../src/tracker/tracker-info.c:366:19: note: ‘tracker_miner_fs_path’ was declared here
  366 |  g_autofree char *tracker_miner_fs_path;
      |                   ^~~~~~~~~~~~~~~~~~~~~

../src/libtracker-miner/tracker-file-notifier.c: In function ‘monitor_item_deleted_cb’:
/usr/include/glib-2.0/glib/gmem.h:122:7: warning: ‘cursor’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  122 |       (destroy) (_ptr);                                  \
      |       ^
../src/libtracker-miner/tracker-file-notifier.c:1051:24: note: ‘cursor’ was declared here
 1051 |   TrackerSparqlCursor *cursor;
      |                        ^~~~~~

(cherry picked from commit 78a7bb71)

tracker-extract: Add new game mimetypes

See merge request !309

Add "guess" CUE file extractor

See merge request !308

Add a mangled/minimal PSX game image that lets us test the
generic-disc extractor with these.

Test that all RDF types specified in the expected.json file are
there in the tracker-extract output. This already spotted some
typos in our expected JSON data, so fix these along the way.

Besides their regular usage as audio playlists, these files are
often in combination with "binary data" files (usually, compact disc
images), some notable cases are (retro)gaming oriented (e.g.
Playstation game images).

Add support for these as a metadata extractor, the CUE files start
as nfo:Software on the tracker:Software graph, the extractor will
determine whether the information element becomes a nfo:GameImage.

Only PSX and Turbografx CD images are contemplated here, images
for other platforms (e.g. Sega CD and Saturn) already have distinct
mimetypes that are already handled as nfo:GameImage.

The first 2.x release was on 2015, even debian stable got rid of
libcue 1.x, let's drop support for it.

This function guesses the CUE file (and TOC) out of an audio
file URI. Rename so it's clearer what it does.

These were added to GNOME Games in the mean time, catch up with
it.

libtracker-miners-common: Flip ellipsizing

See merge request !307

Due to some brain fart, ellipsizing was made to cut the string the
opposite way around to the given TRACKER_ELLIPSIZING_* value. Go
for the minimal fix and fully flip the condition/strings.

tracker-control: Fix arguments in signal handler

See merge request !306

libtracker-miners-common: Improve terminal ellipsizing helper

See merge request !305

This was in a sorry state for some reasons:
- It was pretty oblivious to UTF-8, so it might cut the string
  mid-character.
- It uses g_memdup(), which should be best avoided. See
  glib!1928

For the former, use g_utf8_* API to count characters (which is
what we want for terminal formatting purposes). For the latter,
use g_strndup(), which is gchar* oriented and takes gsize, to
avoid vulnerabilities and incompatibilities.

The first argument here is not the main loop, this means 1) invalid
memory accesses and 2) the daemon does not really quit.

The particular local case was even worse, the random memory area
being interpreted as the main loops mutex looks locked, so the daemon
simply stalled on it.