1. 18 Jun, 2022 2 commits
    • Sam Thursfield's avatar
      Merge branch 'wip/carlosg/cancel-fixes' into 'master' · fd444514
      Sam Thursfield authored
      libtracker-miner: Fix TrackerFileNotifier cancellation paths
      Closes #223
      See merge request !394
    • Carlos Garnacho's avatar
      libtracker-miner: Fix TrackerFileNotifier cancellation paths · 32a15b9d
      Carlos Garnacho authored
      Currently, the code paths handling cancellation of a TrackerCrawler async
      request attempt to still emit ::directory-finished and update stats. However
      this causes invalid memory accesses on finalization paths, since the
      TrackerFileNotifier has been already disposed at the time the async callback
      is handled. This may result in crashes.
      To fix this, avoid all TrackerFileNotifier manipulation in the cancellation
      paths of the async callback, the callback is meant to execute and bail out
      cleanly now in these situations. This makes it a responsibility of the
      g_cancellable_cancel() caller to instruct the TrackerFileNotifier how to
      Other callers, like the paths handling unmount and deletion of the folder
      being crawled, have also been updated to ensure TrackerFileNotifier
      resumes operation correctly after those situations.
      Fixes: #223
  2. 27 May, 2022 1 commit
  3. 26 May, 2022 1 commit
    • Carlos Garnacho's avatar
      tracker-miner-fs: Always delete graph nie:InformationElement on create/update · 96143ae5
      Carlos Garnacho authored
      There are some situations where the file monitors cannot distinguish between
      a file being created where none existed before, or a file newly created
      replacing a previously existing file.
      Treat all create/update events the same WRT trimming the previously
      existing nie:InformationElements, in order to ensure these updates that
      pass as creates also result in the file being reindexed by the
      metadata extractor. This only applies to files that would have metadata
      While at it, simplify the SPARQL and move the code so that it is not
      scattered across the function.
  4. 22 May, 2022 2 commits
  5. 02 May, 2022 2 commits
  6. 24 Apr, 2022 4 commits
  7. 08 Apr, 2022 2 commits
    • Carlos Garnacho's avatar
      tracker: Show full output in "tracker3 status" if redirected to file · 3e14dac8
      Carlos Garnacho authored
      Handle "tracker3 status" output being redirected to a file showing the
      full error reports for all existing errors, instead of the clamped/paged
      list meant for interactive navigation.
    • Carlos Garnacho's avatar
      tracker: Handle stale reports for disappeared files in "tracker3 status" · 878e7eeb
      Carlos Garnacho authored
      As every race condition is possible in filesystems, it is possible that a
      file disappears under tracker-extract-3 feet after existence checks, but
      before the extractor module opens the file for metadata extraction.
      In that case we could generate error reports for files that do no longer
      exist, and whose report won't be automatically deleted ever again.
      Ensure to trim these stale files during "tracker3 status" output
      generation, so there's something able to remove these from the filesystem
      and they don't confuse users into thinking these are legit errors.
  8. 19 Mar, 2022 1 commit
  9. 16 Mar, 2022 2 commits
  10. 06 Mar, 2022 4 commits
  11. 05 Mar, 2022 4 commits
  12. 04 Mar, 2022 3 commits
    • Carlos Garnacho's avatar
      Merge branch 'ignore-track-titles' into 'master' · 1d8c0e85
      Carlos Garnacho authored
      tracker-extract: ignore subtrack titles for videos
      Closes #202
      See merge request !382
    • Ignacy Kuchciński's avatar
      tests: Add extractor test for videos with tracks that have titles · 72734789
      Ignacy Kuchciński authored and Carlos Garnacho's avatar Carlos Garnacho committed
      Add a test that lets us check the resulting title of a video that
      containes audio or subtitle tracks with their own title tags.
    • Ignacy Kuchciński's avatar
      tracker-extract: ignore subtrack titles for videos · 47b13910
      Ignacy Kuchciński authored and Carlos Garnacho's avatar Carlos Garnacho committed
      Currently, the resulting nie:title includes titles from the individual
      tracks due to both gstreamer not differentiating between
      global/container tags and track tags until introducing
      gst_discoverer_container_info_get_tags() as new API and tracker-extract
      gstreamer backend looping through available tracks and collecting all
      tags it could find.
      As a result, in cases where there is no title tag in the container, but
      there are some title tags in subtitle or audio tracks, they are included
      in the nie:title and prevent the file name based fallback title in grilo
      and cause the video to show up with nonsense titles in totem.
      To fix this, replace gst_discoverer_info_get_tags() with the new API,
      and ignore title tags from subtracks if the file is a video.
      Fixes #202
  13. 16 Feb, 2022 4 commits
  14. 14 Feb, 2022 3 commits
  15. 13 Feb, 2022 1 commit
  16. 29 Jan, 2022 2 commits
  17. 25 Jan, 2022 2 commits