GitLab

allow viewers to be loaded from ~/.local/share/sushi/viewers

Closes #19

See merge request !10

Joel Ong authored Jul 21, 2019 and Cosimo Cecchi committed Jul 21, 2019

Closes #19

fix #20

check all viewers for explicit membership before falling back to parent types

See merge request !9

Turn the symlink into an actual launcher that uses the ShowFile()
D-Bus method to open a preview window for the passed-in file.

https://bugzilla.gnome.org/show_bug.cgi?id=758253

The renderer is destroyed when the cancelled is cancelled, so make
sure not to trigger any updates, or we'll hit critical warnings.

Not only when we can create an ExternalWindow instance. There are
expectations in mainWindow.js that the window is already realized when
the renderer is ready.

Instead of hardcoding a single size, scale it with the monitor
geometry.

#7

Instead of only relying on constants, since we want to add some
resolution-dependent logic.

Instead of connecting to key-press-event manually.

Makes us more robust to leaks and simplifies the code.

This is a final type, so both the object struct and the private struct
are private. It's not necessary to use a separate private struct.

The code is lifted from xdg-desktop-portal-gtk. This will allow
us to parent the window to an external Nautilus window even under
Wayland.

This is fallout from a recent refactor.

Otherwise it will create a visual glitch if we hide it later.
Instead, show it if necessary.

No need to keep headers in a separate array.

We don't have any in the headers, so this can be removed.

Instead of having every renderer do this. We add a hasToolbar
property to the renderer and make populateToolbar() an optional
method as part of this.

We were setting the icon_name property on the wrong widget.

This is particularly visible in the PDF renderer, where clicking
on the next page will make the toolbar disappear after the timeout.

Make it use per-frame delays, and clean code up.

Instead of the window class. This allows us to remove some
complexity from the window code, and will make it easier for us to
implement the behavior of cancelling the autohide timeout on the
toolbar once one of its buttons is clicked.

Failing silently is not good UX, so we add a small fail whale screen
to handle the case when a renderer fails to load.

At the moment errors are ignored while loading data from files.

To fix that We want to add an error state to the main window,
so this commit adds error reporting from renderers as a first step.

This needs to be initialized to -1, or upon an error we'll kill our
own process through a kill(0) call.