[faces] Faces name box should be active after drawing it
Submitted by an unknown user
Link to original bug (#717717)
Description
---- Reported by shotwell-maint@gnome.bugs 2011-08-04 00:23:00 -0700 ----
Original Redmine bug id: 3916
Original URL: http://redmine.yorba.org/issues/3916
Searchable id: yorba-bug-3916
Original author: Mattias P õldaru
Original description:
Trunk build on Ubuntu 11.04.
When I drag face area and release, text area is not active. Is it once again Ubuntu-only bug?
Related issues:
- related to shotwell - 3920: [faces, oneiric] face name entry broken (Invalid)
---- Additional Comments From shotwell-maint@gnome.bugs 2013-01-22 14:06:00 -0800 ----
History
Comment 1
Updated by Adam Dingle over 2 years ago
- Priority changed from Normal to High
- Target version set to 0.11
Mattias,
what do you mean exactly when you say that the text area "is not active"?
This might be related to (or even the same as) #3920 (closed), reported on Ubuntu Oneiric.
Comment 2
Updated by Mattias Põldaru over 2 years ago
By "not active" I mean cursor is not in the text area.
The above is description of behaviour when using classic gnome (metacity and gnome-panel).
When I use unity (with compiz), text area ends up with cursor after dragging face rectangle, but clicking in the face rectangle later does nothing (it is supposed to edit name).
These bugs may be related, but the other report seems more to be graphics buffer syncing problem (he must use compiz and unity).
On Oneiric there are dozens of Ubuntu-specific hacks, which all do not work well together.
Comment 3
Updated by Adam Dingle over 2 years ago
-
Target version deleted (
<strike>
_0.11_</strike>
)
Comment 4
Updated by Valentín Barros over 2 years ago
- File 0007-Fix-to-3916.patch added
I attach a patch to fix this.
I've tested it in
- Linux Mint 10 with Gnome 2.32.0.
- Ubuntu 11.04 with Gnome 2.32.1, with and without Unity (VirtualBox)
- Ubuntu 11.10 Alpha 3 with Gnome 3.1.4, with Unity but without 3D effects (VirtualBox, I'm not able to get 3D effects work)
And it seems to work fine.
Comment 5
Updated by Lucas Beeler over 2 years ago
Hey Valentin...my VMWare Fusion Natty VM won't run Unity, so I'll review this patch when I get back to the US in a week and have access to my desktop machine.
Comment 6
Updated by Jim Nelson about 2 years ago
- Description updated (diff)
- Category set to 4
- Status changed from Open to Review
- Target version set to 0.12
We need to review these patches.
Comment 7
Updated by Adam Dingle about 2 years ago
- Subject changed from Faces name box should be active after drawing it to [faces] Faces name box should be active after drawing it
Comment 8
Updated by Adam Dingle almost 2 years ago
-
Target version deleted (
<strike>
_0.12_</strike>
)
Comment 9
Updated by Valentín Barros over 1 year ago
- File 0023-Fix-to-bugs-3916-and-3920.patch added
Hello!
I've remade the patch I had submitted last year and I've added a couple of modifications.
Please note that I've swapped two lines of code in PhotoPage.vala. This change has the effect of allowing a current working tool to "steal" the focus the app has moved to the "tool window" —this is to allow Faces Tool
to move the focus to one face-name entry window. I've tested it and I haven't found any issue, but of course I think it's better to warn about it.
Please note also that this patch should be applied after the steps I've just sent by e-mail to recover faces tool in master.
Comment 10
Updated by Jim Nelson 10 months ago
- Category set to faces
--- Bug imported by chaz@yorba.org 2013-11-25 21:53 UTC ---
This bug was previously known as bug 3916 at http://redmine.yorba.org/show_bug.cgi?id=3916 Imported an attachment (id=262065) Imported an attachment (id=262066)
Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution