allow red-eye correction on non-circular areas
Submitted by Adam Dingle
Link to original bug (#716395)
Description
---- Reported by adam@yorba.org 2010-06-21 09:11:00 -0700 ----
Original Redmine bug id: 2171
Original URL: http://redmine.yorba.org/issues/2171
Searchable id: yorba-bug-2171
Original author: Adam Dingle
Original description:
From Lu Timdale lutimdale@yahoo.com:
- red eye fix coloured area outside of the pupil which is unacceptable to me. You should be able to … hone in on a general area. It cannot be only the eyeball area… most people have their eyes partially closed (the area requiring fixing is not circular) and it is unrealistic to expect a general user to exactly pinpoint an eyeball.
Related issues:
- related to shotwell - Feature #549 (closed): fully automatic red eye reduction (Open)
---- Additional Comments From shotwell-maint@gnome.bugs 2011-01-15 11:50:00 -0800 ----
History
Comment 1
Updated by dave42 - almost 3 years ago
I'm not able to achieve useful results using the red eye correction as it is currently implemented. I always end up with very noticeable blue circles in place of the eye. It really should never be affecting any pixels in the selection that aren't red. The exact shape of the selection shouldn't matter.
For some inspiration and/or code, I'd suggest looking at the GIMP's red eye removal filter. I think it works really well, and I especially like being able to set the threshold to fine-tune what, within the selection, gets corrected.
My ultimate dream implementation would offer three different levels of automation:
-
fully automatic (recognizes the eyes and uses a default correction threshold)
-
assisted automatic (point at the centre of an eye and, if need be, adjust the threshold)
-
manual (draw the selection and, if need be, adjust the threshold)
Number 3 (what GIMP has) is the most important, since it would always work. Number 1 and 2 would be very nice to have. Hopefully number 1 (already requested in ticket #549 (closed)) would work most of the time, and the other two would only be needed when the software gets it wrong and the user needs to help.
Comment 2
Updated by Lucas Beeler almost 3 years ago
Hi dave42,
I'd like to open a ticket to address your concerns about the red-eye tool. If you're “not able to achieve useful results†with the Shotwell red-eye tool, then we want to fix it. Just so we have some good sample data to work with, could you attach a copy of one of the photos that's given you unacceptable results?
Cheers,
Lucas
Comment 3
Updated by dave42 - almost 3 years ago
Thanks for the quick response, Lucas. I thought my concerns already fit under this ticket, since it has to do with the way that the whole selection is affected by red eye removal, not just the red part. That's why I commented here, instead of opening a new ticket. I'll attach a sample. If you don't think it makes sense to keep this under this ticket, I'm happy to open a new one.
Comment 4
Updated by Lucas Beeler almost 3 years ago
After analysis of dave42's attachments, I've opened ticket #3053 (closed).
--- Bug imported by chaz@yorba.org 2013-11-25 21:45 UTC ---
This bug was previously known as bug 2171 at http://redmine.yorba.org/show_bug.cgi?id=2171 Imported an attachment (id=261699)
Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution