From fa6884f73af83ccbc72b8fe0f7bc63a00630ee0b Mon Sep 17 00:00:00 2001 From: Jens Georg Date: Sat, 7 Sep 2024 12:19:50 +0200 Subject: [PATCH] Revert "Do not drop tool pixbuf in editing host" This reverts commit b2d1f8d2c9acf32f8387e395ca4910acf22ce39e. Causes massive memory leak in slideshow. Also this was never the fix for the ticket it claimed to be. I have a vague recollection that something was crashing in the red eye tool but I could not reproduce it anymore. Fixes #5123 --- src/EditingHostPage.vala | 2 +- src/PixbufCache.vala | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/EditingHostPage.vala b/src/EditingHostPage.vala index 66d24529..81fd1985 100644 --- a/src/EditingHostPage.vala +++ b/src/EditingHostPage.vala @@ -466,7 +466,7 @@ public abstract class EditingHostPage : SinglePhotoPage { return photo.has_transformations() || photo.has_editable(); } - private void on_pixbuf_fetched(Photo photo, owned Gdk.Pixbuf? pixbuf, Error? err) { + private void on_pixbuf_fetched(Photo photo, Gdk.Pixbuf? pixbuf, Error? err) { // if not of the current photo, nothing more to do if (!photo.equals(get_photo())) return; diff --git a/src/PixbufCache.vala b/src/PixbufCache.vala index cee33c61..6ff740ed 100644 --- a/src/PixbufCache.vala +++ b/src/PixbufCache.vala @@ -80,7 +80,7 @@ public class PixbufCache : Object { private Gee.ArrayList lru = new Gee.ArrayList(); private Gee.HashMap in_progress = new Gee.HashMap(); - public signal void fetched(Photo photo, owned Gdk.Pixbuf? pixbuf, Error? err); + public signal void fetched(Photo photo, Gdk.Pixbuf? pixbuf, Error? err); public PixbufCache(SourceCollection sources, PhotoType type, Scaling scaling, int max_count, CacheFilter? filter = null) { -- GitLab