Pull "24hr: no" and "calendar:week_start:0" translations from GTK_WEEK_START instead
I am checking the translation and notice this string:
#. Translators: set this to anything else if you want to use a
#. * 24 hour clock.
#.
#: libegg/egg-datetime.c:792
msgid "24hr: no"
msgstr "24hr: yes"
https://gitlab.gnome.org/GNOME/seahorse/-/blob/master/libegg/egg-datetime.c#L792
And this:
#. Translate to calendar:week_start:1 if you want Monday to be the
#. * first day of the week; otherwise translate to calendar:week_start:0.
#. * Do *not* translate it to anything else, if it isn't calendar:week_start:1
#. * or calendar:week_start:0 it will not work.
#.
#: libegg/egg-datetime.c:473
msgid "calendar:week_start:0"
msgstr "calendar:week_start:1"
https://gitlab.gnome.org/GNOME/seahorse/-/blob/master/libegg/egg-datetime.c#L473-479
I am not a big fan of having these strings that are settings in translation files for translators to "translate". Could these settings be taken from GNOME instead where they have properly already been set so Seahorse follows GNOME?
For the first one anything other then "24hr: no" toggles the setting. For the second one it must be either "calendar:week_start:0" or "calendar:week_start:1" else it gives a warning.
So i guess untranslated/empty strings toggles the setting/give warning.
Also even though there are comments for the translators the translators might not read it or whatever and we end up with incorrect "translations" in some of the languages:
msgid "calendar:week_start:0"
msgstr "पात्रो:हप्ता सुरु:०"
msgid "calendar:week_start:0"
msgstr "1"
msgid "calendar:week_start:0"
msgstr "0"
msgid "calendar:week_start:0"
msgstr "0"
msgid "calendar:week_start:0"
msgstr "يىلنامە:week_start:0"