Translatable strings that should not be translatable
Submitted by Gabor Kelemen
Link to original bug (#754420)
Description
I have noticed that there are many translatable strings in Rygel that seem to have no sensible meaning for ordinary users. For example[1]:
#. error is only emitted if even the basic information extraction #. failed; there's not much to do here, just print the information and #. go to the next file #: ../src/plugins/media-export/rygel-media-export-harvesting-task.vala:334 #, c-format msgid "Skipping URI %s; extraction completely failed: %s" msgstr ""
#: ../src/plugins/media-export/rygel-media-export-item-factory.vala:120 #, c-format msgid "Invalid metadata serialisation, cannot process %s" msgstr ""
#: ../src/plugins/media-export/rygel-media-export-item-factory.vala:136 #, c-format msgid "Invalid metadata serialisation: expected 7 children, got %d" msgid_plural "Invalid metadata serialisation: expected 7 children, got %d" msgstr[0] "" msgstr[1] ""
Is this something the user can do anything about? Are these even visible to users? If the answer is no, then there is no point in translating them either.
A little research shows that these and many similarly confusing strings are in fact coming from the warning()[2] method.
Could you remove the translatable mark from these strings?
Here is a list of affected files - in total these make up about the third(!) of all translatable strings in the whole project:
gabor@gabor-laptop:/src/gnome/rygel$ grep -rc "warning (_" * | grep -v 0$src/media-engines/gstreamer/rygel-gst-media-engine.vala:3
src/media-engines/gstreamer/rygel-gst-data-source.vala:2
src/media-engines/simple/rygel-simple-media-engine.vala:3
src/librygel-renderer/rygel-av-transport.vala:2
src/librygel-db/database-cursor.vala:1
src/librygel-core/rygel-energy-management-helper.c:3
src/librygel-core/rygel-basic-management.vala:3
src/librygel-core/rygel-log-handler.vala:1
src/librygel-core/rygel-recursive-module-loader.vala:1
src/librygel-core/rygel-basic-management-test.vala:2
src/librygel-core/rygel-plugin-loader.vala:3
src/plugins/tracker/rygel-tracker-plugin-factory.vala:1
src/plugins/tracker/rygel-tracker-category-all-container.vala:1
src/plugins/external/rygel-external-variant-util.vala:1
src/plugins/media-export/rygel-media-export-extract.vala:8
src/plugins/media-export/rygel-media-export-writable-db-container.vala:2
src/plugins/media-export/rygel-media-export-plugin.vala:1
src/plugins/media-export/rygel-media-export-harvesting-task.vala:5
src/plugins/media-export/rygel-media-export-metadata-extractor.vala:9
src/plugins/media-export/rygel-media-export-root-container.vala:2
src/plugins/media-export/rygel-media-export-media-cache.vala:15
src/plugins/media-export/rygel-media-export-trackable-db-container.vala:4
src/plugins/media-export/rygel-media-export-recursive-file-monitor.vala:1
src/plugins/media-export/rygel-media-export-item-factory.vala:8
src/plugins/media-export/rygel-media-export-media-cache-upgrader.vala:4
src/plugins/media-export/rygel-media-export-leaf-query-container.vala:1
src/plugins/media-export/rygel-media-export-node-query-container.vala:1
src/plugins/media-export/rygel-media-export-harvester.vala:4
src/plugins/playbin/rygel-playbin-plugin.vala:1
src/librygel-ruih/rygel-ruih-servicemanager.vala:3
src/librygel-server/rygel-thumbnailer.vala:1
src/librygel-server/rygel-media-file-item.vala:1
src/librygel-server/rygel-media-container.vala:1
src/librygel-server/rygel-object-creator.vala:1
src/librygel-server/rygel-http-post.vala:1
src/librygel-server/rygel-media-art-store.vala:2
src/librygel-server/rygel-import-resource.vala:2
src/librygel-server/rygel-media-object.vala:2
src/librygel-server/rygel-search.vala:1
src/librygel-server/rygel-browse.vala:1
src/librygel-server/rygel-item-updater.vala:1
src/librygel-server/rygel-item-destroyer.vala:1
src/librygel-server/rygel-reference-creator.vala:1
src/rygel/rygel-user-config.vala:1
src/rygel/rygel-cmdline-config.vala:1
src/rygel/rygel-main.vala:3
src/rygel/rygel-acl.vala:2
gabor@gabor-laptop:/src/gnome/rygel$ grep -rc "warning (ngettext" * | grep -v 0$
src/plugins/media-export/rygel-media-export-item-factory.vala:1
src/rygel/rygel-main.vala:1
[1] https://l10n.gnome.org/POT/rygel.master/rygel.master.pot [2] http://valadoc.org/#!api=glib-2.0/GLib.warning
Thanks in advance!