Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
R
rhythmbox
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 1,655
    • Issues 1,655
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 16
    • Merge Requests 16
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • rhythmbox
  • Merge Requests
  • !20

Open
Opened Nov 14, 2018 by Peter@p37321
  • Report abuse
Report abuse

WIP: Use Headerbar

Replace the toolbar with a headerbar, hereby unifying button sizes and modernizing some involved code. The album art no longer has a border in order to maximize its size in the headerbar. The tooltips for the play/pause/stop buttons are in the headerbar.ui file now, and therefore are marked translatable.

Fixes #1664.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.gnome.org/p3732/rhythmbox.git WIP-headerbar
git checkout -b p3732/rhythmbox-WIP-headerbar FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff p3732/rhythmbox-WIP-headerbar

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 6
  • Commits 7
  • Pipelines 6
  • Changes 11
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: GNOME/rhythmbox!20