GitLab

Meson warning_level option is a fine replacement. Use ...

    -Dwarning_level=1 for -Wall
    -Dwarning_level=2 for -Wextra
    -Dwarning_level=3 for -Wextra -Wpedantic

Building in this mode and running ./shell/rhythmbox still fails, with
an error like this:

    /usr/lib64/python3.9/site-packages/gi/module.py:163: Warning: cannot register existing type 'RBShell'
     g_type = info.get_g_type()

    (rhythmbox:56952): GLib-CRITICAL **: 19:19:36.617: g_once_init_leave: assertion 'result != 0' failed

The problem is that libpeas has the wrong library path when loading
plugins. It tries to load symbols from /usr/lib64/librhythmboxcore.so
and these conflict with those from ./shell/librhythmboxcore.so which
is already loaded.

We already set rpath to $ORIGIN in the `rhythmbox` binary, so I'm not
sure what more can be done. Setting LD_LIBRARY_PATH manually also
doesn't get it to work.

This is consistent with upstream project's use.

Option names can't start with 'vala_' so rename to 'plugins_vala' and
'plugins_python'.

Autotools build doesn't do this, and the test breaks if there's no CD drive.

On bionic I see this error:

    ../lib/libmediaplayerid/meson.build:38:0: ERROR: Static libraries can only be introspected with GObject-Introspection >=1.58.1

See <http://www.mesonbuild.com/> for more information about Meson.

Some podcast hosts do not handle HEAD requests correctly, giving
incorrect filenames and sizes, so request the first byte of the file
instead.

Now the parser updates an existing RBPodcastChannel rather than filling out
a new one, which simplifies things a little bit for the podcast add dialog.

Switch to totem_pl_parser_parse_async so we don't have to manage
threads, and move mime type checking and other error handling out
to the podcast manager code to simplify the parser interface.

RhythmDBQueryResultList gives us a simpler way to do this.

This stops the search results jumping around as the images load, and
makes the layout consistent when non-square images appear.

Leaving the partial download lying around means we'll resume it on next
startup.  Deleting it seems like a better match for the intent.

This can race with the download task, so we should wait until the
task callback instead.

Song info ui fixes

See merge request GNOME/rhythmbox!50

rating: emit 'rated' signal when rating is updated via keyboard too

Closes #1773

See merge request !49

lyrics: disable winampcn parser as its servers aren't talking

Closes #1829

See merge request GNOME/rhythmbox!84

Closes: #1822

Now that we do a HEAD request first, we can check for a partial download
even if the download location isn't set on the episode.

This lets us get the file size before we ask for a range from the server,
so if we have the full file already, we don't get a 'range not satisfiable'
error.

This was particularly annoying when selecting a property to show a
popup menu for it - the view would scroll so the property was in the
middle, but the menu would be shown next to the pointer.

Fixes: #1829

also write error details to the debug log to make it easier to figure out
what should or should not be retried later.

This simplifies some parts of the implementation, since libsoup
lets us directly access the HTTP headers that we were trying to get
at through the gvfs layer.

It also makes it simple enough to retry the download (resuming from
where we got up to if possible) if we get an error that is likely to
be transient while reading from the input stream.